* [PATCH net 0/6] bnxt_en: Bug fixes.
@ 2020-09-21 1:08 Michael Chan
2020-09-21 1:08 ` [PATCH net 1/6] bnxt_en: Use memcpy to copy VPD field info Michael Chan
` (6 more replies)
0 siblings, 7 replies; 18+ messages in thread
From: Michael Chan @ 2020-09-21 1:08 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba
A series of small driver fixes covering VPD length logic,
ethtool_get_regs on VF, hwmon temperature error handling,
mutex locking for EEE and pause ethtool settings, and
parameters for statistics related firmware calls.
Please queue patches 1, 2, and 3 for -stable. Thanks.
Edwin Peer (1):
bnxt_en: return proper error codes in bnxt_show_temp
Michael Chan (3):
bnxt_en: Protect bnxt_set_eee() and bnxt_set_pauseparam() with mutex.
bnxt_en: Fix HWRM_FUNC_QSTATS_EXT firmware call.
bnxt_en: Fix wrong flag value passed to HWRM_PORT_QSTATS_EXT fw call.
Vasundhara Volam (2):
bnxt_en: Use memcpy to copy VPD field info.
bnxt_en: Return -EOPNOTSUPP for ETHTOOL_GREGS on VFs.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 30 +++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 34 +++++++++++++++--------
2 files changed, 43 insertions(+), 21 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH net 1/6] bnxt_en: Use memcpy to copy VPD field info.
2020-09-21 1:08 [PATCH net 0/6] bnxt_en: Bug fixes Michael Chan
@ 2020-09-21 1:08 ` Michael Chan
2020-09-21 1:08 ` [PATCH net 2/6] bnxt_en: return proper error codes in bnxt_show_temp Michael Chan
` (5 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2020-09-21 1:08 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, Vasundhara Volam
From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Using strlcpy() to copy from VPD is not correct because VPD strings
are not necessarily NULL terminated. Use memcpy() to copy the VPD
length up to the destination buffer size - 1. The destination is
zeroed memory so it will always be NULL terminated.
Fixes: a0d0fd70fed5 ("bnxt_en: Read partno and serialno of the board from VPD")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 8eb73fe..4af42b1 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -12090,7 +12090,7 @@ static int bnxt_init_mac_addr(struct bnxt *bp)
static void bnxt_vpd_read_info(struct bnxt *bp)
{
struct pci_dev *pdev = bp->pdev;
- int i, len, pos, ro_size;
+ int i, len, pos, ro_size, size;
ssize_t vpd_size;
u8 *vpd_data;
@@ -12125,7 +12125,8 @@ static void bnxt_vpd_read_info(struct bnxt *bp)
if (len + pos > vpd_size)
goto read_sn;
- strlcpy(bp->board_partno, &vpd_data[pos], min(len, BNXT_VPD_FLD_LEN));
+ size = min(len, BNXT_VPD_FLD_LEN - 1);
+ memcpy(bp->board_partno, &vpd_data[pos], size);
read_sn:
pos = pci_vpd_find_info_keyword(vpd_data, i, ro_size,
@@ -12138,7 +12139,8 @@ static void bnxt_vpd_read_info(struct bnxt *bp)
if (len + pos > vpd_size)
goto exit;
- strlcpy(bp->board_serialno, &vpd_data[pos], min(len, BNXT_VPD_FLD_LEN));
+ size = min(len, BNXT_VPD_FLD_LEN - 1);
+ memcpy(bp->board_serialno, &vpd_data[pos], size);
exit:
kfree(vpd_data);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH net 2/6] bnxt_en: return proper error codes in bnxt_show_temp
2020-09-21 1:08 [PATCH net 0/6] bnxt_en: Bug fixes Michael Chan
2020-09-21 1:08 ` [PATCH net 1/6] bnxt_en: Use memcpy to copy VPD field info Michael Chan
@ 2020-09-21 1:08 ` Michael Chan
2020-09-21 1:08 ` [PATCH net 3/6] bnxt_en: Protect bnxt_set_eee() and bnxt_set_pauseparam() with mutex Michael Chan
` (4 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2020-09-21 1:08 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, Edwin Peer
From: Edwin Peer <edwin.peer@broadcom.com>
Returning "unknown" as a temperature value violates the hwmon interface
rules. Appropriate error codes should be returned via device_attribute
show instead. These will ultimately be propagated to the user via the
file system interface.
In addition to the corrected error handling, it is an even better idea to
not present the sensor in sysfs at all if it is known that the read will
definitely fail. Given that temp1_input is currently the only sensor
reported, ensure no hwmon registration if TEMP_MONITOR_QUERY is not
supported or if it will fail due to access permissions. Something smarter
may be needed if and when other sensors are added.
Fixes: 12cce90b934b ("bnxt_en: fix HWRM error when querying VF temperature")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 4af42b1..2865e24 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -9311,18 +9311,16 @@ static ssize_t bnxt_show_temp(struct device *dev,
struct hwrm_temp_monitor_query_output *resp;
struct bnxt *bp = dev_get_drvdata(dev);
u32 len = 0;
+ int rc;
resp = bp->hwrm_cmd_resp_addr;
bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_TEMP_MONITOR_QUERY, -1, -1);
mutex_lock(&bp->hwrm_cmd_lock);
- if (!_hwrm_send_message_silent(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT))
+ rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT);
+ if (!rc)
len = sprintf(buf, "%u\n", resp->temp * 1000); /* display millidegree */
mutex_unlock(&bp->hwrm_cmd_lock);
-
- if (len)
- return len;
-
- return sprintf(buf, "unknown\n");
+ return rc ?: len;
}
static SENSOR_DEVICE_ATTR(temp1_input, 0444, bnxt_show_temp, NULL, 0);
@@ -9342,7 +9340,16 @@ static void bnxt_hwmon_close(struct bnxt *bp)
static void bnxt_hwmon_open(struct bnxt *bp)
{
+ struct hwrm_temp_monitor_query_input req = {0};
struct pci_dev *pdev = bp->pdev;
+ int rc;
+
+ bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_TEMP_MONITOR_QUERY, -1, -1);
+ rc = hwrm_send_message_silent(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT);
+ if (rc == -EACCES || rc == -EOPNOTSUPP) {
+ bnxt_hwmon_close(bp);
+ return;
+ }
if (bp->hwmon_dev)
return;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH net 3/6] bnxt_en: Protect bnxt_set_eee() and bnxt_set_pauseparam() with mutex.
2020-09-21 1:08 [PATCH net 0/6] bnxt_en: Bug fixes Michael Chan
2020-09-21 1:08 ` [PATCH net 1/6] bnxt_en: Use memcpy to copy VPD field info Michael Chan
2020-09-21 1:08 ` [PATCH net 2/6] bnxt_en: return proper error codes in bnxt_show_temp Michael Chan
@ 2020-09-21 1:08 ` Michael Chan
2020-09-21 1:08 ` [PATCH net 4/6] bnxt_en: Return -EOPNOTSUPP for ETHTOOL_GREGS on VFs Michael Chan
` (3 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2020-09-21 1:08 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba
All changes related to bp->link_info require the protection of the
link_lock mutex. It's not sufficient to rely just on RTNL.
Fixes: 163e9ef63641 ("bnxt_en: Fix race when modifying pause settings.")
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 31 +++++++++++++++--------
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index d092833..6c75101 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -1788,9 +1788,12 @@ static int bnxt_set_pauseparam(struct net_device *dev,
if (!BNXT_PHY_CFG_ABLE(bp))
return -EOPNOTSUPP;
+ mutex_lock(&bp->link_lock);
if (epause->autoneg) {
- if (!(link_info->autoneg & BNXT_AUTONEG_SPEED))
- return -EINVAL;
+ if (!(link_info->autoneg & BNXT_AUTONEG_SPEED)) {
+ rc = -EINVAL;
+ goto pause_exit;
+ }
link_info->autoneg |= BNXT_AUTONEG_FLOW_CTRL;
if (bp->hwrm_spec_code >= 0x10201)
@@ -1811,11 +1814,11 @@ static int bnxt_set_pauseparam(struct net_device *dev,
if (epause->tx_pause)
link_info->req_flow_ctrl |= BNXT_LINK_PAUSE_TX;
- if (netif_running(dev)) {
- mutex_lock(&bp->link_lock);
+ if (netif_running(dev))
rc = bnxt_hwrm_set_pause(bp);
- mutex_unlock(&bp->link_lock);
- }
+
+pause_exit:
+ mutex_unlock(&bp->link_lock);
return rc;
}
@@ -2552,8 +2555,7 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata)
struct bnxt *bp = netdev_priv(dev);
struct ethtool_eee *eee = &bp->eee;
struct bnxt_link_info *link_info = &bp->link_info;
- u32 advertising =
- _bnxt_fw_to_ethtool_adv_spds(link_info->advertising, 0);
+ u32 advertising;
int rc = 0;
if (!BNXT_PHY_CFG_ABLE(bp))
@@ -2562,19 +2564,23 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata)
if (!(bp->flags & BNXT_FLAG_EEE_CAP))
return -EOPNOTSUPP;
+ mutex_lock(&bp->link_lock);
+ advertising = _bnxt_fw_to_ethtool_adv_spds(link_info->advertising, 0);
if (!edata->eee_enabled)
goto eee_ok;
if (!(link_info->autoneg & BNXT_AUTONEG_SPEED)) {
netdev_warn(dev, "EEE requires autoneg\n");
- return -EINVAL;
+ rc = -EINVAL;
+ goto eee_exit;
}
if (edata->tx_lpi_enabled) {
if (bp->lpi_tmr_hi && (edata->tx_lpi_timer > bp->lpi_tmr_hi ||
edata->tx_lpi_timer < bp->lpi_tmr_lo)) {
netdev_warn(dev, "Valid LPI timer range is %d and %d microsecs\n",
bp->lpi_tmr_lo, bp->lpi_tmr_hi);
- return -EINVAL;
+ rc = -EINVAL;
+ goto eee_exit;
} else if (!bp->lpi_tmr_hi) {
edata->tx_lpi_timer = eee->tx_lpi_timer;
}
@@ -2584,7 +2590,8 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata)
} else if (edata->advertised & ~advertising) {
netdev_warn(dev, "EEE advertised %x must be a subset of autoneg advertised speeds %x\n",
edata->advertised, advertising);
- return -EINVAL;
+ rc = -EINVAL;
+ goto eee_exit;
}
eee->advertised = edata->advertised;
@@ -2596,6 +2603,8 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata)
if (netif_running(dev))
rc = bnxt_hwrm_set_link_setting(bp, false, true);
+eee_exit:
+ mutex_unlock(&bp->link_lock);
return rc;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH net 4/6] bnxt_en: Return -EOPNOTSUPP for ETHTOOL_GREGS on VFs.
2020-09-21 1:08 [PATCH net 0/6] bnxt_en: Bug fixes Michael Chan
` (2 preceding siblings ...)
2020-09-21 1:08 ` [PATCH net 3/6] bnxt_en: Protect bnxt_set_eee() and bnxt_set_pauseparam() with mutex Michael Chan
@ 2020-09-21 1:08 ` Michael Chan
2020-09-21 1:08 ` [PATCH net 5/6] bnxt_en: Fix HWRM_FUNC_QSTATS_EXT firmware call Michael Chan
` (2 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2020-09-21 1:08 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, Vasundhara Volam
From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Debug firmware commands are not supported on VFs to read registers.
This patch avoids logging unnecessary access_denied error on VFs
when user calls ETHTOOL_GREGS.
By returning error in get_regs_len() method on the VF, the get_regs()
method will not be called.
Fixes: b5d600b027eb ("bnxt_en: Add support for 'ethtool -d'")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index 6c75101..fecdfd8 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -1322,6 +1322,9 @@ static int bnxt_get_regs_len(struct net_device *dev)
struct bnxt *bp = netdev_priv(dev);
int reg_len;
+ if (!BNXT_PF(bp))
+ return -EOPNOTSUPP;
+
reg_len = BNXT_PXP_REG_LEN;
if (bp->fw_cap & BNXT_FW_CAP_PCIE_STATS_SUPPORTED)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH net 5/6] bnxt_en: Fix HWRM_FUNC_QSTATS_EXT firmware call.
2020-09-21 1:08 [PATCH net 0/6] bnxt_en: Bug fixes Michael Chan
` (3 preceding siblings ...)
2020-09-21 1:08 ` [PATCH net 4/6] bnxt_en: Return -EOPNOTSUPP for ETHTOOL_GREGS on VFs Michael Chan
@ 2020-09-21 1:08 ` Michael Chan
2020-09-21 1:08 ` [PATCH net 6/6] bnxt_en: Fix wrong flag value passed to HWRM_PORT_QSTATS_EXT fw call Michael Chan
2020-09-21 2:05 ` [PATCH net 0/6] bnxt_en: Bug fixes David Miller
6 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2020-09-21 1:08 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba
Fix it to set the required fid input parameter. The firmware call
fails without this patch.
Fixes: d752d0536c97 ("bnxt_en: Retrieve hardware counter masks from firmware if available.")
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 2865e24..d527c9c 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -3782,6 +3782,7 @@ static int bnxt_hwrm_func_qstat_ext(struct bnxt *bp,
return -EOPNOTSUPP;
bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_FUNC_QSTATS_EXT, -1, -1);
+ req.fid = cpu_to_le16(0xffff);
req.flags = FUNC_QSTATS_EXT_REQ_FLAGS_COUNTER_MASK;
mutex_lock(&bp->hwrm_cmd_lock);
rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH net 6/6] bnxt_en: Fix wrong flag value passed to HWRM_PORT_QSTATS_EXT fw call.
2020-09-21 1:08 [PATCH net 0/6] bnxt_en: Bug fixes Michael Chan
` (4 preceding siblings ...)
2020-09-21 1:08 ` [PATCH net 5/6] bnxt_en: Fix HWRM_FUNC_QSTATS_EXT firmware call Michael Chan
@ 2020-09-21 1:08 ` Michael Chan
2020-09-21 2:05 ` [PATCH net 0/6] bnxt_en: Bug fixes David Miller
6 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2020-09-21 1:08 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba
The wrong flag value caused the firmware call to return actual port
counters instead of the counter masks. This messed up the counter
overflow logic and caused erratic extended port counters to be
displayed under ethtool -S.
Fixes: 531d1d269c1d ("bnxt_en: Retrieve hardware masks for port counters.")
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index d527c9c..7b7e8b7 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -3853,7 +3853,7 @@ static void bnxt_init_stats(struct bnxt *bp)
tx_masks = stats->hw_masks;
tx_count = sizeof(struct tx_port_stats_ext) / 8;
- flags = FUNC_QSTATS_EXT_REQ_FLAGS_COUNTER_MASK;
+ flags = PORT_QSTATS_EXT_REQ_FLAGS_COUNTER_MASK;
rc = bnxt_hwrm_port_qstats_ext(bp, flags);
if (rc) {
mask = (1ULL << 40) - 1;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH net 0/6] bnxt_en: Bug fixes.
2020-09-21 1:08 [PATCH net 0/6] bnxt_en: Bug fixes Michael Chan
` (5 preceding siblings ...)
2020-09-21 1:08 ` [PATCH net 6/6] bnxt_en: Fix wrong flag value passed to HWRM_PORT_QSTATS_EXT fw call Michael Chan
@ 2020-09-21 2:05 ` David Miller
6 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2020-09-21 2:05 UTC (permalink / raw)
To: michael.chan; +Cc: netdev, kuba
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 20 Sep 2020 21:08:53 -0400
> A series of small driver fixes covering VPD length logic,
> ethtool_get_regs on VF, hwmon temperature error handling,
> mutex locking for EEE and pause ethtool settings, and
> parameters for statistics related firmware calls.
Series applied.
> Please queue patches 1, 2, and 3 for -stable. Thanks.
Queued up, thanks.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/6] bnxt_en: Bug fixes
@ 2023-06-07 7:54 Michael Chan
2023-06-08 9:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2023-06-07 7:54 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, kuba, pabeni, gospo
[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]
This patchset has the following fixes for bnxt_en:
1. Add missing VNIC ID parameter in the FW message when getting an
updated RSS configuration from the FW.
2. Fix a warning when doing ethtool reset on newer chips.
3. Fix VLAN issue on a VF when a default VLAN is assigned.
4. Fix a problem during DPC (Downstream Port containment) scenario.
5. Fix a NULL pointer dereference when receiving a PTP event from FW.
6. Fix VXLAN/Geneve UDP port delete/add with newer FW.
Pavan Chebbi (2):
bnxt_en: Fix bnxt_hwrm_update_rss_hash_cfg()
bnxt_en: Prevent kernel panic when receiving unexpected PHC_UPDATE
event
Somnath Kotur (2):
bnxt_en: Query default VLAN before VNIC setup on a VF
bnxt_en: Implement .set_port / .unset_port UDP tunnel callbacks
Sreekanth Reddy (1):
bnxt_en: Don't issue AP reset during ethtool's reset operation
Vikas Gupta (1):
bnxt_en: Skip firmware fatal error recovery if chip is not accessible
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 40 ++++++++++++++-----
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 1 +
3 files changed, 33 insertions(+), 10 deletions(-)
--
2.30.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH net 0/6] bnxt_en: Bug fixes
2023-06-07 7:54 Michael Chan
@ 2023-06-08 9:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 18+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-08 9:20 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, edumazet, kuba, pabeni, gospo
Hello:
This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 7 Jun 2023 00:54:03 -0700 you wrote:
> This patchset has the following fixes for bnxt_en:
>
> 1. Add missing VNIC ID parameter in the FW message when getting an
> updated RSS configuration from the FW.
>
> 2. Fix a warning when doing ethtool reset on newer chips.
>
> [...]
Here is the summary with links:
- [net,1/6] bnxt_en: Fix bnxt_hwrm_update_rss_hash_cfg()
https://git.kernel.org/netdev/net/c/095d5dc0c1d9
- [net,2/6] bnxt_en: Don't issue AP reset during ethtool's reset operation
https://git.kernel.org/netdev/net/c/1d997801c7cc
- [net,3/6] bnxt_en: Query default VLAN before VNIC setup on a VF
https://git.kernel.org/netdev/net/c/1a9e4f501bc6
- [net,4/6] bnxt_en: Skip firmware fatal error recovery if chip is not accessible
https://git.kernel.org/netdev/net/c/83474a9b252a
- [net,5/6] bnxt_en: Prevent kernel panic when receiving unexpected PHC_UPDATE event
https://git.kernel.org/netdev/net/c/319a7827df97
- [net,6/6] bnxt_en: Implement .set_port / .unset_port UDP tunnel callbacks
https://git.kernel.org/netdev/net/c/1eb4ef125913
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/6] bnxt_en: Bug fixes.
@ 2019-08-16 22:33 Michael Chan
2019-08-18 20:06 ` David Miller
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2019-08-16 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
2 Bug fixes related to 57500 shutdown sequence and doorbell sequence,
2 TC Flower bug fixes related to the setting of the flow direction,
1 NVRAM update bug fix, and a minor fix to suppress an unnecessary
error message. Please queue for -stable as well. Thanks.
Michael Chan (2):
bnxt_en: Fix VNIC clearing logic for 57500 chips.
bnxt_en: Improve RX doorbell sequence.
Somnath Kotur (1):
bnxt_en: Fix to include flow direction in L2 key
Vasundhara Volam (2):
bnxt_en: Fix handling FRAG_ERR when NVM_INSTALL_UPDATE cmd fails
bnxt_en: Suppress HWRM errors for HWRM_NVM_GET_VARIABLE command
Venkat Duvvuru (1):
bnxt_en: Use correct src_fid to determine direction of the flow
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 36 ++++++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 9 ++++--
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 12 ++++----
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 8 ++---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h | 2 +-
5 files changed, 40 insertions(+), 27 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net 0/6] bnxt_en: Bug fixes.
2019-08-16 22:33 Michael Chan
@ 2019-08-18 20:06 ` David Miller
0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2019-08-18 20:06 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Fri, 16 Aug 2019 18:33:31 -0400
> 2 Bug fixes related to 57500 shutdown sequence and doorbell sequence,
> 2 TC Flower bug fixes related to the setting of the flow direction,
> 1 NVRAM update bug fix, and a minor fix to suppress an unnecessary
> error message. Please queue for -stable as well. Thanks.
Series applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/6] bnxt_en: Bug fixes.
@ 2018-11-15 8:25 Michael Chan
2018-11-15 17:40 ` David Miller
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2018-11-15 8:25 UTC (permalink / raw)
To: davem; +Cc: netdev
Most of the bug fixes are related to the new 57500 chips, including some
initialization and counter fixes, disabling RDMA support, and a
workaround for occasional missing interrupts. The last patch from
Vasundhara fixes the year/month parameters for firmware coredump.
Michael Chan (5):
bnxt_en: Fix RSS context allocation.
bnxt_en: Fix rx_l4_csum_errors counter on 57500 devices.
bnxt_en: Disable RDMA support on the 57500 chips.
bnxt_en: Workaround occasional TX timeout on 57500 A0.
bnxt_en: Add software "missed_irqs" counter.
Vasundhara Volam (1):
bnxt_en: Fix filling time in bnxt_fill_coredump_record()
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 70 ++++++++++++++++++++++-
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 ++
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 9 ++-
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 3 +
4 files changed, 81 insertions(+), 5 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net 0/6] bnxt_en: Bug fixes.
2018-11-15 8:25 Michael Chan
@ 2018-11-15 17:40 ` David Miller
0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2018-11-15 17:40 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Thu, 15 Nov 2018 03:25:36 -0500
> Most of the bug fixes are related to the new 57500 chips, including some
> initialization and counter fixes, disabling RDMA support, and a
> workaround for occasional missing interrupts. The last patch from
> Vasundhara fixes the year/month parameters for firmware coredump.
Series applied, thanks Michael.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/6] bnxt_en: Bug fixes.
@ 2018-07-09 6:24 Michael Chan
2018-07-09 23:28 ` David Miller
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2018-07-09 6:24 UTC (permalink / raw)
To: davem; +Cc: netdev
These are bug fixes in error code paths, TC Flower VLAN TCI flow
checking bug fix, proper filtering of Broadcast packets if IFF_BROADCAST
is not set, and a bug fix in bnxt_get_max_rings() to return 0 ring
parameters when the return value is -ENOMEM.
Michael Chan (4):
bnxt_en: Fix inconsistent BNXT_FLAG_AGG_RINGS logic.
bnxt_en: Always set output parameters in bnxt_get_max_rings().
bnxt_en: Support clearing of the IFF_BROADCAST flag.
bnxt_en: Do not modify max IRQ count after RDMA driver requests/frees
IRQs.
Venkat Duvvuru (1):
bnxt_en: Fix the vlan_tci exact match check.
Vikas Gupta (1):
bnxt_en: Fix for system hang if request_irq fails
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 24 ++++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 -
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 30 ++++++++++++++++++++++++---
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 2 --
4 files changed, 44 insertions(+), 13 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH net 0/6] bnxt_en: Bug fixes.
2018-07-09 6:24 Michael Chan
@ 2018-07-09 23:28 ` David Miller
0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2018-07-09 23:28 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Mon, 9 Jul 2018 02:24:46 -0400
> These are bug fixes in error code paths, TC Flower VLAN TCI flow
> checking bug fix, proper filtering of Broadcast packets if IFF_BROADCAST
> is not set, and a bug fix in bnxt_get_max_rings() to return 0 ring
> parameters when the return value is -ENOMEM.
Series applied, thank you.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/6] bnxt_en: bug fixes.
@ 2017-10-14 1:09 Michael Chan
2017-10-15 1:52 ` David Miller
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2017-10-14 1:09 UTC (permalink / raw)
To: davem; +Cc: netdev
Various bug fixes for the VF/PF link change logic, VF resource checking,
potential firmware response corruption on NVRAM and DCB parameters,
and reading the wrong register for PCIe link speed on the VF.
Michael Chan (4):
bnxt_en: Improve VF/PF link change logic.
bnxt_en: Don't use rtnl lock to protect link change logic in
workqueue.
bnxt_en: Fix VF resource checking.
bnxt_en: Fix possible corrupted NVRAM parameters from firmware
response.
Sankar Patchineelam (1):
bnxt_en: Fix possible corruption in DCB parameters from firmware.
Vasundhara Volam (1):
bnxt_en: Fix VF PCIe link speed and width logic.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 99 +++++++++++++++++------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 ++
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 23 ++++--
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 11 ++-
5 files changed, 112 insertions(+), 34 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2023-06-08 9:20 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 1:08 [PATCH net 0/6] bnxt_en: Bug fixes Michael Chan
2020-09-21 1:08 ` [PATCH net 1/6] bnxt_en: Use memcpy to copy VPD field info Michael Chan
2020-09-21 1:08 ` [PATCH net 2/6] bnxt_en: return proper error codes in bnxt_show_temp Michael Chan
2020-09-21 1:08 ` [PATCH net 3/6] bnxt_en: Protect bnxt_set_eee() and bnxt_set_pauseparam() with mutex Michael Chan
2020-09-21 1:08 ` [PATCH net 4/6] bnxt_en: Return -EOPNOTSUPP for ETHTOOL_GREGS on VFs Michael Chan
2020-09-21 1:08 ` [PATCH net 5/6] bnxt_en: Fix HWRM_FUNC_QSTATS_EXT firmware call Michael Chan
2020-09-21 1:08 ` [PATCH net 6/6] bnxt_en: Fix wrong flag value passed to HWRM_PORT_QSTATS_EXT fw call Michael Chan
2020-09-21 2:05 ` [PATCH net 0/6] bnxt_en: Bug fixes David Miller
-- strict thread matches above, loose matches on Subject: below --
2023-06-07 7:54 Michael Chan
2023-06-08 9:20 ` patchwork-bot+netdevbpf
2019-08-16 22:33 Michael Chan
2019-08-18 20:06 ` David Miller
2018-11-15 8:25 Michael Chan
2018-11-15 17:40 ` David Miller
2018-07-09 6:24 Michael Chan
2018-07-09 23:28 ` David Miller
2017-10-14 1:09 [PATCH net 0/6] bnxt_en: bug fixes Michael Chan
2017-10-15 1:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).