* [PATCH] net/fsl: quieten expected MDIO access failures
@ 2020-09-24 14:56 Jamie Iles
2020-09-24 15:04 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jamie Iles @ 2020-09-24 14:56 UTC (permalink / raw)
To: netdev; +Cc: Jamie Iles, Jeremy Linton
MDIO reads can happen during PHY probing, and printing an error with
dev_err can result in a large number of error messages during device
probe. On a platform with a serial console this can result in
excessively long boot times in a way that looks like an infinite loop
when multiple busses are present. Since 0f183fd151c (net/fsl: enable
extended scanning in xgmac_mdio) we perform more scanning so there are
potentially more failures.
Reduce the logging level to dev_dbg which is consistent with the
Freescale enetc driver.
Cc: Jeremy Linton <jeremy.linton@arm.com>
Signed-off-by: Jamie Iles <jamie@nuviainc.com>
---
drivers/net/ethernet/freescale/xgmac_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 98be51d8b08c..bfa2826c5545 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -229,7 +229,7 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum)
/* Return all Fs if nothing was there */
if ((xgmac_read32(®s->mdio_stat, endian) & MDIO_STAT_RD_ER) &&
!priv->has_a011043) {
- dev_err(&bus->dev,
+ dev_dbg(&bus->dev,
"Error while reading PHY%d reg at %d.%hhu\n",
phy_id, dev_addr, regnum);
return 0xffff;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net/fsl: quieten expected MDIO access failures
2020-09-24 14:56 [PATCH] net/fsl: quieten expected MDIO access failures Jamie Iles
@ 2020-09-24 15:04 ` Andrew Lunn
2020-09-24 15:12 ` Jamie Iles
2020-09-24 15:32 ` Andrew Lunn
2020-09-25 3:14 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2020-09-24 15:04 UTC (permalink / raw)
To: Jamie Iles; +Cc: netdev, Jeremy Linton
On Thu, Sep 24, 2020 at 03:56:45PM +0100, Jamie Iles wrote:
> MDIO reads can happen during PHY probing, and printing an error with
> dev_err can result in a large number of error messages during device
> probe. On a platform with a serial console this can result in
> excessively long boot times in a way that looks like an infinite loop
> when multiple busses are present. Since 0f183fd151c (net/fsl: enable
> extended scanning in xgmac_mdio) we perform more scanning so there are
> potentially more failures.
>
> Reduce the logging level to dev_dbg which is consistent with the
> Freescale enetc driver.
Hi Jamie
Does the system you are using suffer from Errata A011043?
The change does however seem reasonable.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/fsl: quieten expected MDIO access failures
2020-09-24 15:04 ` Andrew Lunn
@ 2020-09-24 15:12 ` Jamie Iles
2020-09-24 15:40 ` Jeremy Linton
0 siblings, 1 reply; 6+ messages in thread
From: Jamie Iles @ 2020-09-24 15:12 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Jamie Iles, netdev, Jeremy Linton
Hi Andrew,
On Thu, Sep 24, 2020 at 05:04:53PM +0200, Andrew Lunn wrote:
> On Thu, Sep 24, 2020 at 03:56:45PM +0100, Jamie Iles wrote:
> > MDIO reads can happen during PHY probing, and printing an error with
> > dev_err can result in a large number of error messages during device
> > probe. On a platform with a serial console this can result in
> > excessively long boot times in a way that looks like an infinite loop
> > when multiple busses are present. Since 0f183fd151c (net/fsl: enable
> > extended scanning in xgmac_mdio) we perform more scanning so there are
> > potentially more failures.
> >
> > Reduce the logging level to dev_dbg which is consistent with the
> > Freescale enetc driver.
>
> Hi Jamie
>
> Does the system you are using suffer from Errata A011043?
It's the HoneyComb SolidRun (LX2160A) and I can't find an errata list
for that chip. It's booting from ACPI in any case so wouldn't have that
workaround set.
Thanks,
Jamie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/fsl: quieten expected MDIO access failures
2020-09-24 14:56 [PATCH] net/fsl: quieten expected MDIO access failures Jamie Iles
2020-09-24 15:04 ` Andrew Lunn
@ 2020-09-24 15:32 ` Andrew Lunn
2020-09-25 3:14 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2020-09-24 15:32 UTC (permalink / raw)
To: Jamie Iles; +Cc: netdev, Jeremy Linton
On Thu, Sep 24, 2020 at 03:56:45PM +0100, Jamie Iles wrote:
> MDIO reads can happen during PHY probing, and printing an error with
> dev_err can result in a large number of error messages during device
> probe. On a platform with a serial console this can result in
> excessively long boot times in a way that looks like an infinite loop
> when multiple busses are present. Since 0f183fd151c (net/fsl: enable
> extended scanning in xgmac_mdio) we perform more scanning so there are
> potentially more failures.
>
> Reduce the logging level to dev_dbg which is consistent with the
> Freescale enetc driver.
>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Signed-off-by: Jamie Iles <jamie@nuviainc.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/fsl: quieten expected MDIO access failures
2020-09-24 15:12 ` Jamie Iles
@ 2020-09-24 15:40 ` Jeremy Linton
0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Linton @ 2020-09-24 15:40 UTC (permalink / raw)
To: Jamie Iles, Andrew Lunn; +Cc: netdev, Calvin Johnson
Hi,
On 9/24/20 10:12 AM, Jamie Iles wrote:
> Hi Andrew,
>
> On Thu, Sep 24, 2020 at 05:04:53PM +0200, Andrew Lunn wrote:
>> On Thu, Sep 24, 2020 at 03:56:45PM +0100, Jamie Iles wrote:
>>> MDIO reads can happen during PHY probing, and printing an error with
>>> dev_err can result in a large number of error messages during device
>>> probe. On a platform with a serial console this can result in
>>> excessively long boot times in a way that looks like an infinite loop
>>> when multiple busses are present. Since 0f183fd151c (net/fsl: enable
>>> extended scanning in xgmac_mdio) we perform more scanning so there are
>>> potentially more failures.
>>>
>>> Reduce the logging level to dev_dbg which is consistent with the
>>> Freescale enetc driver.
>>
>> Hi Jamie
>>
>> Does the system you are using suffer from Errata A011043?
>
> It's the HoneyComb SolidRun (LX2160A) and I can't find an errata list
> for that chip. It's booting from ACPI in any case so wouldn't have that
> workaround set.
I don't see those messages, but granted my firmware is a bit out of
date. Let me upgrade it and see if I can reproduce it too.
(also +CC Calvin)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/fsl: quieten expected MDIO access failures
2020-09-24 14:56 [PATCH] net/fsl: quieten expected MDIO access failures Jamie Iles
2020-09-24 15:04 ` Andrew Lunn
2020-09-24 15:32 ` Andrew Lunn
@ 2020-09-25 3:14 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-09-25 3:14 UTC (permalink / raw)
To: jamie; +Cc: netdev, jeremy.linton
From: Jamie Iles <jamie@nuviainc.com>
Date: Thu, 24 Sep 2020 15:56:45 +0100
> MDIO reads can happen during PHY probing, and printing an error with
> dev_err can result in a large number of error messages during device
> probe. On a platform with a serial console this can result in
> excessively long boot times in a way that looks like an infinite loop
> when multiple busses are present. Since 0f183fd151c (net/fsl: enable
> extended scanning in xgmac_mdio) we perform more scanning so there are
> potentially more failures.
>
> Reduce the logging level to dev_dbg which is consistent with the
> Freescale enetc driver.
>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Signed-off-by: Jamie Iles <jamie@nuviainc.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-25 3:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-24 14:56 [PATCH] net/fsl: quieten expected MDIO access failures Jamie Iles
2020-09-24 15:04 ` Andrew Lunn
2020-09-24 15:12 ` Jamie Iles
2020-09-24 15:40 ` Jeremy Linton
2020-09-24 15:32 ` Andrew Lunn
2020-09-25 3:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).