From: kernel test robot <lkp@intel.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
intel-wired-lan@lists.osuosl.org
Cc: kbuild-all@lists.01.org,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
sasha.neftin@intel.com, andre.guedes@intel.com,
anthony.l.nguyen@intel.com, linux-pci@vger.kernel.org,
bhelgaas@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH next-queue v1 3/3] igc: Add support for PTP getcrosststamp()
Date: Sat, 26 Sep 2020 12:11:22 +0800 [thread overview]
Message-ID: <202009261229.ixDMmAy4%lkp@intel.com> (raw)
In-Reply-To: <20200925232834.2704711-4-vinicius.gomes@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3692 bytes --]
Hi Vinicius,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on jkirsher-next-queue/dev-queue]
[cannot apply to pci/next ipvs/master v5.9-rc6 next-20200925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vinicius-Costa-Gomes/igc-Add-support-for-PCIe-PTM/20200926-073053
base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f6b01c642e977d12e008e6e6dbec747de73d836f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vinicius-Costa-Gomes/igc-Add-support-for-PCIe-PTM/20200926-073053
git checkout f6b01c642e977d12e008e6e6dbec747de73d836f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/intel/igc/igc_ptp.c: In function 'igc_ptm_gather_report':
>> drivers/net/ethernet/intel/igc/igc_ptp.c:459:27: error: implicit declaration of function 'convert_art_ns_to_tsc' [-Werror=implicit-function-declaration]
459 | adapter->ptm_host_time = convert_art_ns_to_tsc(t2_curr);
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/intel/igc/igc_ptp.c:459:27: error: incompatible types when assigning to type 'struct system_counterval_t' from type 'int'
cc1: some warnings being treated as errors
vim +/convert_art_ns_to_tsc +459 drivers/net/ethernet/intel/igc/igc_ptp.c
425
426 static void igc_ptm_gather_report(struct igc_adapter *adapter)
427 {
428 struct igc_hw *hw = &adapter->hw;
429 u32 t2_curr_h, t2_curr_l;
430 ktime_t t1, t2_curr;
431
432 t1 = ktime_set(rd32(IGC_PTM_T1_TIM0_H),
433 rd32(IGC_PTM_T1_TIM0_L));
434
435 t2_curr_l = rd32(IGC_PTM_CURR_T2_L);
436 t2_curr_h = rd32(IGC_PTM_CURR_T2_H);
437
438 /* FIXME: There's an ambiguity on what endianness some PCIe PTM
439 * messages should use. Find a more robust way to handle this.
440 */
441 t2_curr_h = be32_to_cpu(t2_curr_h);
442
443 t2_curr = ((s64)t2_curr_h << 32 | t2_curr_l);
444
445 wr32(IGC_PTM_STAT, IGC_PTM_STAT_VALID);
446
447 mutex_lock(&adapter->ptm_time_lock);
448
449 /* Because get_device_system_crosststamp() requires that the
450 * historic timestamp is before the PTM device/host
451 * timestamps, we keep track of the current and previous
452 * snapshot (historic timestamp).
453 */
454 memcpy(&adapter->prev_snapshot,
455 &adapter->curr_snapshot, sizeof(adapter->prev_snapshot));
456 ktime_get_snapshot(&adapter->curr_snapshot);
457
458 adapter->ptm_device_time = t1;
> 459 adapter->ptm_host_time = convert_art_ns_to_tsc(t2_curr);
460 mutex_unlock(&adapter->ptm_time_lock);
461
462 mod_delayed_work(system_wq, &adapter->ptm_report,
463 msecs_to_jiffies(IGC_PTM_CYCLE_TIME_MSECS));
464 }
465
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65176 bytes --]
prev parent reply other threads:[~2020-09-26 4:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 23:28 [PATCH next-queue v1 0/3] igc: Add support for PCIe PTM Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 1/3] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2020-09-28 21:54 ` Bjorn Helgaas
2020-09-28 22:32 ` Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 2/3] igc: Enable PCIe PTM Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 3/3] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
2020-09-26 4:11 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009261229.ixDMmAy4%lkp@intel.com \
--to=lkp@intel.com \
--cc=andre.guedes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bhelgaas@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).