From: Bjorn Helgaas <helgaas@kernel.org>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, sasha.neftin@intel.com,
andre.guedes@intel.com, anthony.l.nguyen@intel.com,
linux-pci@vger.kernel.org, bhelgaas@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH next-queue v1 1/3] Revert "PCI: Make pci_enable_ptm() private"
Date: Mon, 28 Sep 2020 16:54:32 -0500 [thread overview]
Message-ID: <20200928215432.GA2499272@bjorn-Precision-5520> (raw)
In-Reply-To: <20200925232834.2704711-2-vinicius.gomes@intel.com>
On Fri, Sep 25, 2020 at 04:28:32PM -0700, Vinicius Costa Gomes wrote:
> Make pci_enable_ptm() accessible from the drivers.
>
> Even if PTM still works on the platform I am using without calling
> this this function, it might be possible that it's not always the
> case.
*Does* PTM work on your system without calling pci_enable_ptm()? If
so, I think that would mean the BIOS enabled PTM, and that seems
slightly surprising.
> Exposing this to the driver enables the driver to use the
> 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not.
>
> This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c.
>
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
AFAICT we just never had any callers at all for pci_enable_ptm(). I
probably shouldn't have merged it in the first place.
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/pci.h | 3 ---
> include/linux/pci.h | 7 +++++++
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index fa12f7cbc1a0..8871109fe390 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -582,11 +582,8 @@ static inline void pcie_ecrc_get_policy(char *str) { }
>
> #ifdef CONFIG_PCIE_PTM
> void pci_ptm_init(struct pci_dev *dev);
> -int pci_enable_ptm(struct pci_dev *dev, u8 *granularity);
> #else
> static inline void pci_ptm_init(struct pci_dev *dev) { }
> -static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity)
> -{ return -EINVAL; }
> #endif
>
> struct pci_dev_reset_methods {
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 835530605c0d..ec4b28153cc4 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1593,6 +1593,13 @@ static inline bool pci_aer_available(void) { return false; }
>
> bool pci_ats_disabled(void);
>
> +#ifdef CONFIG_PCIE_PTM
> +int pci_enable_ptm(struct pci_dev *dev, u8 *granularity);
> +#else
> +static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity)
> +{ return -EINVAL; }
> +#endif
> +
> void pci_cfg_access_lock(struct pci_dev *dev);
> bool pci_cfg_access_trylock(struct pci_dev *dev);
> void pci_cfg_access_unlock(struct pci_dev *dev);
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-28 23:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 23:28 [PATCH next-queue v1 0/3] igc: Add support for PCIe PTM Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 1/3] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2020-09-28 21:54 ` Bjorn Helgaas [this message]
2020-09-28 22:32 ` Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 2/3] igc: Enable PCIe PTM Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 3/3] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
2020-09-26 4:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928215432.GA2499272@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=andre.guedes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bhelgaas@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).