From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
f.fainelli@gmail.com, vivien.didelot@gmail.com, kuba@kernel.org
Subject: Re: [PATCH v3 net-next 02/15] net: dsa: allow drivers to request promiscuous mode on master
Date: Sat, 26 Sep 2020 22:22:27 +0200 [thread overview]
Message-ID: <20200926202227.GA3887691@lunn.ch> (raw)
In-Reply-To: <20200926193215.1405730-3-vladimir.oltean@nxp.com>
On Sat, Sep 26, 2020 at 10:32:02PM +0300, Vladimir Oltean wrote:
> Currently DSA assumes that taggers don't mess with the destination MAC
> address of the frames on RX. That is not always the case. Some DSA
> headers are placed before the Ethernet header (ocelot), and others
> simply mangle random bytes from the destination MAC address (sja1105
> with its incl_srcpt option).
>
> Currently the DSA master goes to promiscuous mode automatically when the
> slave devices go too (such as when enslaved to a bridge), but in
> standalone mode this is a problem that needs to be dealt with.
>
> So give drivers the possibility to signal that their tagging protocol
> will get randomly dropped otherwise, and let DSA deal with fixing that.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-09-26 20:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 19:32 [PATCH v3 net-next 00/15] Generic adjustment for flow dissector in DSA Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 01/15] net: mscc: ocelot: move NPI port configuration to DSA Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 02/15] net: dsa: allow drivers to request promiscuous mode on master Vladimir Oltean
2020-09-26 20:22 ` Andrew Lunn [this message]
2020-09-26 19:32 ` [PATCH v3 net-next 03/15] net: dsa: tag_sja1105: request promiscuous mode for master Vladimir Oltean
2020-09-26 20:22 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 04/15] net: dsa: tag_ocelot: use a short prefix on both ingress and egress Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 05/15] net: dsa: make the .flow_dissect tagger callback return void Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 06/15] net: dsa: add a generic procedure for the flow dissector Vladimir Oltean
2020-09-26 20:25 ` Andrew Lunn
2020-09-26 20:33 ` Andrew Lunn
2020-09-26 20:49 ` Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 07/15] net: dsa: point out the tail taggers Vladimir Oltean
2020-09-26 20:27 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 08/15] net: flow_dissector: avoid indirect call to DSA .flow_dissect for generic case Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 09/15] net: dsa: tag_brcm: use generic flow dissector procedure Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 10/15] net: dsa: tag_dsa: use the " Vladimir Oltean
2020-09-26 21:08 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 11/15] net: dsa: tag_edsa: " Vladimir Oltean
2020-09-26 21:08 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 12/15] net: dsa: tag_mtk: " Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 13/15] net: dsa: tag_qca: " Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 14/15] net: dsa: tag_sja1105: use a custom " Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 15/15] net: dsa: tag_rtl4_a: use the generic " Vladimir Oltean
2020-09-30 8:36 ` Linus Walleij
2020-09-26 21:18 ` [PATCH v3 net-next 00/15] Generic adjustment for flow dissector in DSA David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926202227.GA3887691@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).