From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>
Subject: Re: [PATCH v3 net-next 06/15] net: dsa: add a generic procedure for the flow dissector
Date: Sat, 26 Sep 2020 20:49:49 +0000 [thread overview]
Message-ID: <20200926204948.zu6zvj2yqrv4733t@skbuf> (raw)
In-Reply-To: <20200926203300.GE3887691@lunn.ch>
On Sat, Sep 26, 2020 at 10:33:00PM +0200, Andrew Lunn wrote:
> > +static inline void dsa_tag_generic_flow_dissect(const struct sk_buff *skb,
> > + __be16 *proto, int *offset)
> > +{
> > +#if IS_ENABLED(CONFIG_NET_DSA)
> > + const struct dsa_device_ops *ops = skb->dev->dsa_ptr->tag_ops;
> > + int tag_len = ops->overhead;
> > +
> > + *offset = tag_len;
> > + *proto = ((__be16 *)skb->data)[(tag_len / 2) - 1];
> > +#endif
> > +}
> > +
>
> Do you actually need the IS_ENABLED()? There is only one caller of
> this function, and it is already protected by
> IS_ENABLED(CONFIG_NET_DSA). So i don't think it adds anything.
It doesn't matter how many callers it has, it doesn't compile when
NET_DSA=n:
./include/net/dsa.h: In function ‘dsa_tag_generic_flow_dissect’:
./include/net/dsa.h:732:47: error: ‘struct net_device’ has no member named ‘dsa_ptr’; did you mean ‘ip_ptr’?
const struct dsa_device_ops *ops = skb->dev->dsa_ptr->tag_ops;
^~~~~~~
ip_ptr
next prev parent reply other threads:[~2020-09-26 20:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 19:32 [PATCH v3 net-next 00/15] Generic adjustment for flow dissector in DSA Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 01/15] net: mscc: ocelot: move NPI port configuration to DSA Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 02/15] net: dsa: allow drivers to request promiscuous mode on master Vladimir Oltean
2020-09-26 20:22 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 03/15] net: dsa: tag_sja1105: request promiscuous mode for master Vladimir Oltean
2020-09-26 20:22 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 04/15] net: dsa: tag_ocelot: use a short prefix on both ingress and egress Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 05/15] net: dsa: make the .flow_dissect tagger callback return void Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 06/15] net: dsa: add a generic procedure for the flow dissector Vladimir Oltean
2020-09-26 20:25 ` Andrew Lunn
2020-09-26 20:33 ` Andrew Lunn
2020-09-26 20:49 ` Vladimir Oltean [this message]
2020-09-26 19:32 ` [PATCH v3 net-next 07/15] net: dsa: point out the tail taggers Vladimir Oltean
2020-09-26 20:27 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 08/15] net: flow_dissector: avoid indirect call to DSA .flow_dissect for generic case Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 09/15] net: dsa: tag_brcm: use generic flow dissector procedure Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 10/15] net: dsa: tag_dsa: use the " Vladimir Oltean
2020-09-26 21:08 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 11/15] net: dsa: tag_edsa: " Vladimir Oltean
2020-09-26 21:08 ` Andrew Lunn
2020-09-26 19:32 ` [PATCH v3 net-next 12/15] net: dsa: tag_mtk: " Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 13/15] net: dsa: tag_qca: " Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 14/15] net: dsa: tag_sja1105: use a custom " Vladimir Oltean
2020-09-26 19:32 ` [PATCH v3 net-next 15/15] net: dsa: tag_rtl4_a: use the generic " Vladimir Oltean
2020-09-30 8:36 ` Linus Walleij
2020-09-26 21:18 ` [PATCH v3 net-next 00/15] Generic adjustment for flow dissector in DSA David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926204948.zu6zvj2yqrv4733t@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).