* [PATCH] mdio: fix mdio-thunder.c dependency & build error
@ 2020-09-27 4:33 Randy Dunlap
2020-09-27 15:08 ` Andrew Lunn
2020-09-27 20:23 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-09-27 4:33 UTC (permalink / raw)
To: netdev, David Miller
Cc: Bartosz Golaszewski, Andrew Lunn, Heiner Kallweit, David Daney
From: Randy Dunlap <rdunlap@infradead.org>
Fix build error by selecting MDIO_DEVRES for MDIO_THUNDER.
Fixes this build error:
ld: drivers/net/phy/mdio-thunder.o: in function `thunder_mdiobus_pci_probe':
drivers/net/phy/mdio-thunder.c:78: undefined reference to `devm_mdiobus_alloc_size'
Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: netdev@vger.kernel.org
Cc: David Daney <david.daney@cavium.com>
---
or applies to drivers/net/phy/Kconfig in mainline (or stable) # v4.6
drivers/net/mdio/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20200925.orig/drivers/net/mdio/Kconfig
+++ linux-next-20200925/drivers/net/mdio/Kconfig
@@ -164,6 +164,7 @@ config MDIO_THUNDER
depends on 64BIT
depends on PCI
select MDIO_CAVIUM
+ select MDIO_DEVRES
help
This driver supports the MDIO interfaces found on Cavium
ThunderX SoCs when the MDIO bus device appears as a PCI
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mdio: fix mdio-thunder.c dependency & build error
2020-09-27 4:33 [PATCH] mdio: fix mdio-thunder.c dependency & build error Randy Dunlap
@ 2020-09-27 15:08 ` Andrew Lunn
2020-09-27 20:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-09-27 15:08 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, David Miller, Bartosz Golaszewski, Heiner Kallweit, David Daney
On Sat, Sep 26, 2020 at 09:33:43PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error by selecting MDIO_DEVRES for MDIO_THUNDER.
> Fixes this build error:
>
> ld: drivers/net/phy/mdio-thunder.o: in function `thunder_mdiobus_pci_probe':
> drivers/net/phy/mdio-thunder.c:78: undefined reference to `devm_mdiobus_alloc_size'
>
> Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mdio: fix mdio-thunder.c dependency & build error
2020-09-27 4:33 [PATCH] mdio: fix mdio-thunder.c dependency & build error Randy Dunlap
2020-09-27 15:08 ` Andrew Lunn
@ 2020-09-27 20:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-27 20:23 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, bgolaszewski, andrew, hkallweit1, david.daney
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sat, 26 Sep 2020 21:33:43 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error by selecting MDIO_DEVRES for MDIO_THUNDER.
> Fixes this build error:
>
> ld: drivers/net/phy/mdio-thunder.o: in function `thunder_mdiobus_pci_probe':
> drivers/net/phy/mdio-thunder.c:78: undefined reference to `devm_mdiobus_alloc_size'
>
> Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied to 'net' and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-27 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-27 4:33 [PATCH] mdio: fix mdio-thunder.c dependency & build error Randy Dunlap
2020-09-27 15:08 ` Andrew Lunn
2020-09-27 20:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).