* [PATCH bpf-next] xsk: remove internal DMA headers
@ 2020-10-05 9:05 Björn Töpel
2020-10-05 9:06 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Björn Töpel @ 2020-10-05 9:05 UTC (permalink / raw)
To: netdev, bpf, ast, daniel
Cc: Björn Töpel, magnus.karlsson, jonathan.lemon, hch
From: Björn Töpel <bjorn.topel@intel.com>
Christoph Hellwig correctly pointed out [1] that the AF_XDP core was
pointlessly including internal headers. Let us remove those includes.
[1] https://lore.kernel.org/bpf/20201005084341.GA3224@infradead.org/
Reported-by: Christoph Hellwig <hch@infradead.org>
Fixes: 1c1efc2af158 ("xsk: Create and free buffer pool independently from umem")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
---
net/xdp/xsk_buff_pool.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
index e63fadd000db..64c9e55d4d4e 100644
--- a/net/xdp/xsk_buff_pool.c
+++ b/net/xdp/xsk_buff_pool.c
@@ -3,9 +3,6 @@
#include <net/xsk_buff_pool.h>
#include <net/xdp_sock.h>
#include <net/xdp_sock_drv.h>
-#include <linux/dma-direct.h>
-#include <linux/dma-noncoherent.h>
-#include <linux/swiotlb.h>
#include "xsk_queue.h"
#include "xdp_umem.h"
base-commit: 1028ae4069991e26d1522e957939fb61d2da1d12
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] xsk: remove internal DMA headers
2020-10-05 9:05 [PATCH bpf-next] xsk: remove internal DMA headers Björn Töpel
@ 2020-10-05 9:06 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2020-10-05 9:06 UTC (permalink / raw)
To: Bj??rn T??pel
Cc: netdev, bpf, ast, daniel, Bj??rn T??pel, magnus.karlsson,
jonathan.lemon, hch
On Mon, Oct 05, 2020 at 11:05:25AM +0200, Bj??rn T??pel wrote:
> From: Bj??rn T??pel <bjorn.topel@intel.com>
>
> Christoph Hellwig correctly pointed out [1] that the AF_XDP core was
> pointlessly including internal headers. Let us remove those includes.
>
> [1] https://lore.kernel.org/bpf/20201005084341.GA3224@infradead.org/
>
> Reported-by: Christoph Hellwig <hch@infradead.org>
> Fixes: 1c1efc2af158 ("xsk: Create and free buffer pool independently from umem")
> Signed-off-by: Bj??rn T??pel <bjorn.topel@intel.com>
Thanks:
Acked-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-05 9:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 9:05 [PATCH bpf-next] xsk: remove internal DMA headers Björn Töpel
2020-10-05 9:06 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).