* [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values
@ 2020-10-02 16:54 Colin King
2020-10-02 17:26 ` Dan Murphy
2020-10-04 0:09 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2020-10-02 16:54 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, David S . Miller, Jakub Kicinski,
Dan Murphy, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the comparisons of u16 integers value and sopass_val with
less than zero for error checking is always false because the values
are unsigned. Fix this by making these variables int. This does not
affect the shift and mask operations performed on these variables
Addresses-Coverity: ("Unsigned compared against zero")
Fixes: 49fc23018ec6 ("net: phy: dp83869: support Wake on LAN")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/phy/dp83869.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index 0aee5f645b71..cf6dec7b7d8e 100644
--- a/drivers/net/phy/dp83869.c
+++ b/drivers/net/phy/dp83869.c
@@ -305,7 +305,7 @@ static int dp83869_set_wol(struct phy_device *phydev,
static void dp83869_get_wol(struct phy_device *phydev,
struct ethtool_wolinfo *wol)
{
- u16 value, sopass_val;
+ int value, sopass_val;
wol->supported = (WAKE_UCAST | WAKE_BCAST | WAKE_MAGIC |
WAKE_MAGICSECURE);
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values
2020-10-02 16:54 [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values Colin King
@ 2020-10-02 17:26 ` Dan Murphy
2020-10-02 17:39 ` Andrew Lunn
2020-10-06 18:26 ` Dan Carpenter
2020-10-04 0:09 ` David Miller
1 sibling, 2 replies; 5+ messages in thread
From: Dan Murphy @ 2020-10-02 17:26 UTC (permalink / raw)
To: Colin King, Andrew Lunn, Heiner Kallweit, David S . Miller,
Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
Colin
On 10/2/20 11:54 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the comparisons of u16 integers value and sopass_val with
> less than zero for error checking is always false because the values
> are unsigned. Fix this by making these variables int. This does not
> affect the shift and mask operations performed on these variables
>
> Addresses-Coverity: ("Unsigned compared against zero")
> Fixes: 49fc23018ec6 ("net: phy: dp83869: support Wake on LAN")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/phy/dp83869.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
> index 0aee5f645b71..cf6dec7b7d8e 100644
> --- a/drivers/net/phy/dp83869.c
> +++ b/drivers/net/phy/dp83869.c
> @@ -305,7 +305,7 @@ static int dp83869_set_wol(struct phy_device *phydev,
> static void dp83869_get_wol(struct phy_device *phydev,
> struct ethtool_wolinfo *wol)
> {
> - u16 value, sopass_val;
> + int value, sopass_val;
>
> wol->supported = (WAKE_UCAST | WAKE_BCAST | WAKE_MAGIC |
> WAKE_MAGICSECURE);
Wonder why this was not reported before as the previous comparison issue
reported by zero day.
Acked-by: Dan Murphy <dmurphy@ti.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values
2020-10-02 17:26 ` Dan Murphy
@ 2020-10-02 17:39 ` Andrew Lunn
2020-10-06 18:26 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2020-10-02 17:39 UTC (permalink / raw)
To: Dan Murphy
Cc: Colin King, Heiner Kallweit, David S . Miller, Jakub Kicinski,
netdev, kernel-janitors, linux-kernel
On Fri, Oct 02, 2020 at 12:26:49PM -0500, Dan Murphy wrote:
> Colin
>
> On 10/2/20 11:54 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the comparisons of u16 integers value and sopass_val with
> > less than zero for error checking is always false because the values
> > are unsigned. Fix this by making these variables int. This does not
> > affect the shift and mask operations performed on these variables
> >
> > Addresses-Coverity: ("Unsigned compared against zero")
> > Fixes: 49fc23018ec6 ("net: phy: dp83869: support Wake on LAN")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/net/phy/dp83869.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
> > index 0aee5f645b71..cf6dec7b7d8e 100644
> > --- a/drivers/net/phy/dp83869.c
> > +++ b/drivers/net/phy/dp83869.c
> > @@ -305,7 +305,7 @@ static int dp83869_set_wol(struct phy_device *phydev,
> > static void dp83869_get_wol(struct phy_device *phydev,
> > struct ethtool_wolinfo *wol)
> > {
> > - u16 value, sopass_val;
> > + int value, sopass_val;
> > wol->supported = (WAKE_UCAST | WAKE_BCAST | WAKE_MAGIC |
> > WAKE_MAGICSECURE);
>
> Wonder why this was not reported before as the previous comparison issue
> reported by zero day.
I think it needs W=1
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values
2020-10-02 16:54 [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values Colin King
2020-10-02 17:26 ` Dan Murphy
@ 2020-10-04 0:09 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2020-10-04 0:09 UTC (permalink / raw)
To: colin.king
Cc: andrew, hkallweit1, kuba, dmurphy, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Fri, 2 Oct 2020 17:54:22 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the comparisons of u16 integers value and sopass_val with
> less than zero for error checking is always false because the values
> are unsigned. Fix this by making these variables int. This does not
> affect the shift and mask operations performed on these variables
>
> Addresses-Coverity: ("Unsigned compared against zero")
> Fixes: 49fc23018ec6 ("net: phy: dp83869: support Wake on LAN")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values
2020-10-02 17:26 ` Dan Murphy
2020-10-02 17:39 ` Andrew Lunn
@ 2020-10-06 18:26 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2020-10-06 18:26 UTC (permalink / raw)
To: Dan Murphy
Cc: Colin King, Andrew Lunn, Heiner Kallweit, David S . Miller,
Jakub Kicinski, netdev, kernel-janitors, linux-kernel
On Fri, Oct 02, 2020 at 12:26:49PM -0500, Dan Murphy wrote:
> Colin
>
> On 10/2/20 11:54 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the comparisons of u16 integers value and sopass_val with
> > less than zero for error checking is always false because the values
> > are unsigned. Fix this by making these variables int. This does not
> > affect the shift and mask operations performed on these variables
> >
> > Addresses-Coverity: ("Unsigned compared against zero")
> > Fixes: 49fc23018ec6 ("net: phy: dp83869: support Wake on LAN")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/net/phy/dp83869.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
> > index 0aee5f645b71..cf6dec7b7d8e 100644
> > --- a/drivers/net/phy/dp83869.c
> > +++ b/drivers/net/phy/dp83869.c
> > @@ -305,7 +305,7 @@ static int dp83869_set_wol(struct phy_device *phydev,
> > static void dp83869_get_wol(struct phy_device *phydev,
> > struct ethtool_wolinfo *wol)
> > {
> > - u16 value, sopass_val;
> > + int value, sopass_val;
> > wol->supported = (WAKE_UCAST | WAKE_BCAST | WAKE_MAGIC |
> > WAKE_MAGICSECURE);
>
> Wonder why this was not reported before as the previous comparison issue
> reported by zero day.
It was reported on Sep 25. I forward those zero day bot emails.
https://lore.kernel.org/lkml/20200925123858.GX18329@kadam/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-06 18:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 16:54 [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values Colin King
2020-10-02 17:26 ` Dan Murphy
2020-10-02 17:39 ` Andrew Lunn
2020-10-06 18:26 ` Dan Carpenter
2020-10-04 0:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).