From: Jakub Kicinski <kuba@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Subject: Re: [net-next PATCH v3] net: dsa: rtl8366rb: Roof MTU for switch
Date: Thu, 8 Oct 2020 09:14:37 -0700 [thread overview]
Message-ID: <20201008091437.559e3d6c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201008091955.44692-1-linus.walleij@linaro.org>
On Thu, 8 Oct 2020 11:19:55 +0200 Linus Walleij wrote:
> diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c
> index 053bf5041f8d..28f510a580be 100644
> --- a/drivers/net/dsa/rtl8366rb.c
> +++ b/drivers/net/dsa/rtl8366rb.c
> @@ -311,6 +311,13 @@
> #define RTL8366RB_GREEN_FEATURE_TX BIT(0)
> #define RTL8366RB_GREEN_FEATURE_RX BIT(2)
>
> +/**
> + * struct rtl8366rb - RTL8366RB-specific data
> + */
> +struct rtl8366rb {
> + unsigned int max_mtu[RTL8366RB_NUM_PORTS];
> +};
If you make the comment kdoc, you gotta describe all fields (or mark
'em private) otherwise:
drivers/net/dsa/rtl8366rb.c:319: warning: Function parameter or member 'max_mtu' not described in 'rtl8366rb'
prev parent reply other threads:[~2020-10-08 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 9:19 [net-next PATCH v3] net: dsa: rtl8366rb: Roof MTU for switch Linus Walleij
2020-10-08 16:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008091437.559e3d6c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).