* [PATCH 1/1] net: dsa: seville: fix buffer size of the queue system
@ 2020-10-14 5:14 Maxim Kochetkov
2020-10-14 9:15 ` Vladimir Oltean
0 siblings, 1 reply; 2+ messages in thread
From: Maxim Kochetkov @ 2020-10-14 5:14 UTC (permalink / raw)
To: netdev
Cc: Vladimir Oltean, Horatiu Vultur, Florian Fainelli,
Alexandre Belloni, David S . Miller, Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360
words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabytes.
2 megabytes is (2048 / 8) * 1024 = 256 * 1024.
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")
---
drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c
index 9e9fd19e1d00..e2cd49eec037 100644
--- a/drivers/net/dsa/ocelot/seville_vsc9953.c
+++ b/drivers/net/dsa/ocelot/seville_vsc9953.c
@@ -1010,7 +1010,7 @@ static const struct felix_info seville_info_vsc9953 = {
.vcap_is2_keys = vsc9953_vcap_is2_keys,
.vcap_is2_actions = vsc9953_vcap_is2_actions,
.vcap = vsc9953_vcap_props,
- .shared_queue_sz = 2048 * 1024,
+ .shared_queue_sz = 256 * 1024,
.num_mact_rows = 2048,
.num_ports = 10,
.mdio_bus_alloc = vsc9953_mdio_bus_alloc,
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] net: dsa: seville: fix buffer size of the queue system
2020-10-14 5:14 [PATCH 1/1] net: dsa: seville: fix buffer size of the queue system Maxim Kochetkov
@ 2020-10-14 9:15 ` Vladimir Oltean
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Oltean @ 2020-10-14 9:15 UTC (permalink / raw)
To: Maxim Kochetkov
Cc: netdev, Horatiu Vultur, Florian Fainelli, Alexandre Belloni,
David S . Miller
On Wed, Oct 14, 2020 at 08:14:04AM +0300, Maxim Kochetkov wrote:
> The VSC9953 Seville switch has 2 megabits of buffer split into 4360
> words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabytes.
~~~~~~~~~
megabits
> 2 megabytes is (2048 / 8) * 1024 = 256 * 1024.
~~~~~~~~~ ^
megabits bytes
>
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")
> ---
Others:
Can you please use a different commit message? Like
"net: dsa: seville: the packet buffer is 2 megabits, not megabytes"
It simplifies the work of backporters to not have more than 1 commit
with the same title.
> drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c
> index 9e9fd19e1d00..e2cd49eec037 100644
> --- a/drivers/net/dsa/ocelot/seville_vsc9953.c
> +++ b/drivers/net/dsa/ocelot/seville_vsc9953.c
> @@ -1010,7 +1010,7 @@ static const struct felix_info seville_info_vsc9953 = {
> .vcap_is2_keys = vsc9953_vcap_is2_keys,
> .vcap_is2_actions = vsc9953_vcap_is2_actions,
> .vcap = vsc9953_vcap_props,
> - .shared_queue_sz = 2048 * 1024,
> + .shared_queue_sz = 256 * 1024,
I suppose I haven't caught this because I've been running with this
patch in my tree:
https://patchwork.ozlabs.org/project/netdev/patch/20201013134849.395986-2-vladimir.oltean@nxp.com/
> .num_mact_rows = 2048,
> .num_ports = 10,
> .mdio_bus_alloc = vsc9953_mdio_bus_alloc,
> --
> 2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-14 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 5:14 [PATCH 1/1] net: dsa: seville: fix buffer size of the queue system Maxim Kochetkov
2020-10-14 9:15 ` Vladimir Oltean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).