Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net] net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags
@ 2020-10-16 17:16 Christian Eggers
  2020-10-16 17:24 ` Vladimir Oltean
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Eggers @ 2020-10-16 17:16 UTC (permalink / raw)
  To: Woojung Huh, Vladimir Oltean
  Cc: Microchip Linux Driver Support, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, David S . Miller, Jakub Kicinski, netdev,
	linux-kernel, Christian Eggers

The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and
KSZ9893 switches also use tail tags.

Fixes: 7a6ffe764be3 ("net: dsa: point out the tail taggers")
Signed-off-by: Christian Eggers <ceggers@arri.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
On Friday, 16 October 2020, 18:56:51 CEST, Vladimir Oltean wrote:
> Hi Christian,
> 
> The idea is perfect but the commit isn't.
>  ...
> Now if you run
> "git show 7a6ffe764be35af0527d8cfd047945e8f8797ddf --pretty=fixes",
> you'll see:
> 
> Fixes: 7a6ffe764be3 ("net: dsa: point out the tail taggers")
thanks for pointing out how to use this feature. I did this manually up to now.

> Notice how there's no [net] tag?
> People complain when the format of the Fixes: tag is not standardized.
I added it manually because the commit ID is not from Linus' tree. Is there any
value using Fixes tags with id's from other trees?

regards
Christian

 net/dsa/tag_ksz.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c
index 945a9bd5ba35..0a5aa982c60d 100644
--- a/net/dsa/tag_ksz.c
+++ b/net/dsa/tag_ksz.c
@@ -123,6 +123,7 @@ static const struct dsa_device_ops ksz8795_netdev_ops = {
 	.xmit	= ksz8795_xmit,
 	.rcv	= ksz8795_rcv,
 	.overhead = KSZ_INGRESS_TAG_LEN,
+	.tail_tag = true,
 };
 
 DSA_TAG_DRIVER(ksz8795_netdev_ops);
@@ -199,6 +200,7 @@ static const struct dsa_device_ops ksz9477_netdev_ops = {
 	.xmit	= ksz9477_xmit,
 	.rcv	= ksz9477_rcv,
 	.overhead = KSZ9477_INGRESS_TAG_LEN,
+	.tail_tag = true,
 };
 
 DSA_TAG_DRIVER(ksz9477_netdev_ops);
-- 
Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags
  2020-10-16 17:16 [PATCH net] net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags Christian Eggers
@ 2020-10-16 17:24 ` Vladimir Oltean
  2020-10-20  0:36   ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Oltean @ 2020-10-16 17:24 UTC (permalink / raw)
  To: Christian Eggers
  Cc: Woojung Huh, Microchip Linux Driver Support, Andrew Lunn,
	Vivien Didelot, Florian Fainelli, David S . Miller,
	Jakub Kicinski, netdev, linux-kernel

On Fri, Oct 16, 2020 at 07:16:03PM +0200, Christian Eggers wrote:
> I added it manually because the commit ID is not from Linus' tree. Is there any
> value using Fixes tags with id's from other trees?

Yes, that's what "git merge" does, it keeps sha1sums.
You should check out "git log --oneline --graph --decorate" some time.
Every maintainer's history is linear, and so is Linus's.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags
  2020-10-16 17:24 ` Vladimir Oltean
@ 2020-10-20  0:36   ` Jakub Kicinski
  0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-10-20  0:36 UTC (permalink / raw)
  To: Vladimir Oltean
  Cc: Christian Eggers, Woojung Huh, Microchip Linux Driver Support,
	Andrew Lunn, Vivien Didelot, Florian Fainelli, David S . Miller,
	netdev, linux-kernel

On Fri, 16 Oct 2020 20:24:49 +0300 Vladimir Oltean wrote:
> On Fri, Oct 16, 2020 at 07:16:03PM +0200, Christian Eggers wrote:
> > I added it manually because the commit ID is not from Linus' tree. Is there any
> > value using Fixes tags with id's from other trees?  
> 
> Yes, that's what "git merge" does, it keeps sha1sums.
> You should check out "git log --oneline --graph --decorate" some time.
> Every maintainer's history is linear, and so is Linus's.

One thing to add is that we never rebase net or net-next trees
(some maintainers would do that occasionally).

Applied, thanks everyone!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 17:16 [PATCH net] net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags Christian Eggers
2020-10-16 17:24 ` Vladimir Oltean
2020-10-20  0:36   ` Jakub Kicinski

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git