* [PATCH] net: korina: cast KSEG0 address to pointer in kfree
[not found] <20201016194611.GK8773@valentin-vidic.from.hr>
@ 2020-10-18 18:42 ` Valentin Vidic
2020-10-20 0:04 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Valentin Vidic @ 2020-10-18 18:42 UTC (permalink / raw)
To: Jakub Kicinski
Cc: David S. Miller, Philip Rischel, Florian Fainelli,
Roman Yeryomin, Willem de Bruijn, Andrew Morton, Mike Rapoport,
Martin Habets, Michael S. Tsirkin, Network Development,
linux-kernel, Valentin Vidic, kernel test robot
Fixes gcc warning:
passing argument 1 of 'kfree' makes pointer from integer without a cast
Fixes: 3af5f0f5c74e ("net: korina: fix kfree of rx/tx descriptor array")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
---
drivers/net/ethernet/korina.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
index af441d699a57..bf48f0ded9c7 100644
--- a/drivers/net/ethernet/korina.c
+++ b/drivers/net/ethernet/korina.c
@@ -1113,7 +1113,7 @@ static int korina_probe(struct platform_device *pdev)
return rc;
probe_err_register:
- kfree(KSEG0ADDR(lp->td_ring));
+ kfree((struct dma_desc *)KSEG0ADDR(lp->td_ring));
probe_err_td_ring:
iounmap(lp->tx_dma_regs);
probe_err_dma_tx:
@@ -1133,7 +1133,7 @@ static int korina_remove(struct platform_device *pdev)
iounmap(lp->eth_regs);
iounmap(lp->rx_dma_regs);
iounmap(lp->tx_dma_regs);
- kfree(KSEG0ADDR(lp->td_ring));
+ kfree((struct dma_desc *)KSEG0ADDR(lp->td_ring));
unregister_netdev(bif->dev);
free_netdev(bif->dev);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: korina: cast KSEG0 address to pointer in kfree
2020-10-18 18:42 ` [PATCH] net: korina: cast KSEG0 address to pointer in kfree Valentin Vidic
@ 2020-10-20 0:04 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-10-20 0:04 UTC (permalink / raw)
To: Valentin Vidic
Cc: David S. Miller, Philip Rischel, Florian Fainelli,
Roman Yeryomin, Willem de Bruijn, Andrew Morton, Mike Rapoport,
Martin Habets, Michael S. Tsirkin, Network Development,
linux-kernel, kernel test robot
On Sun, 18 Oct 2020 20:42:55 +0200 Valentin Vidic wrote:
> Fixes gcc warning:
>
> passing argument 1 of 'kfree' makes pointer from integer without a cast
>
> Fixes: 3af5f0f5c74e ("net: korina: fix kfree of rx/tx descriptor array")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Applied, thank you!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-20 0:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201016194611.GK8773@valentin-vidic.from.hr>
2020-10-18 18:42 ` [PATCH] net: korina: cast KSEG0 address to pointer in kfree Valentin Vidic
2020-10-20 0:04 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).