* [PATCH bpf-next] bpf: add struct bpf_redir_neigh forward declaration to BPF helper defs
@ 2020-10-28 18:12 Andrii Nakryiko
2020-10-28 22:28 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 2+ messages in thread
From: Andrii Nakryiko @ 2020-10-28 18:12 UTC (permalink / raw)
To: bpf, netdev, ast, daniel; +Cc: andrii, kernel-team
Forward-declare struct bpf_redir_neigh in bpf_helper_defs.h to avoid
compiler warning about unknown structs.
Fixes: ba452c9e996d ("bpf: Fix bpf_redirect_neigh helper api to support supplying nexthop")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
scripts/bpf_helpers_doc.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/bpf_helpers_doc.py b/scripts/bpf_helpers_doc.py
index 6769caae142f..31484377b8b1 100755
--- a/scripts/bpf_helpers_doc.py
+++ b/scripts/bpf_helpers_doc.py
@@ -408,6 +408,7 @@ class PrinterHelpers(Printer):
'struct bpf_perf_event_data',
'struct bpf_perf_event_value',
'struct bpf_pidns_info',
+ 'struct bpf_redir_neigh',
'struct bpf_sock',
'struct bpf_sock_addr',
'struct bpf_sock_ops',
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] bpf: add struct bpf_redir_neigh forward declaration to BPF helper defs
2020-10-28 18:12 [PATCH bpf-next] bpf: add struct bpf_redir_neigh forward declaration to BPF helper defs Andrii Nakryiko
@ 2020-10-28 22:28 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 2+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-10-28 22:28 UTC (permalink / raw)
To: Andrii Nakryiko, bpf, netdev, ast, daniel; +Cc: andrii, kernel-team
Andrii Nakryiko <andrii@kernel.org> writes:
> Forward-declare struct bpf_redir_neigh in bpf_helper_defs.h to avoid
> compiler warning about unknown structs.
>
> Fixes: ba452c9e996d ("bpf: Fix bpf_redirect_neigh helper api to support supplying nexthop")
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Ah! I did actually include that in my local tree at some point, but
guess it never made it into the patch; sorry about that!
I guess this should go into the bpf tree, rather than bpf-next, no?
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 0:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 18:12 [PATCH bpf-next] bpf: add struct bpf_redir_neigh forward declaration to BPF helper defs Andrii Nakryiko
2020-10-28 22:28 ` Toke Høiland-Jørgensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).