netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	james.jurack@ametek.com
Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow_head for PTP
Date: Tue, 3 Nov 2020 08:30:50 -0800	[thread overview]
Message-ID: <20201103083050.100b2568@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201103161319.wisvmjbdqhju6vyh@skbuf>

On Tue, 3 Nov 2020 18:13:19 +0200 Vladimir Oltean wrote:
> [14538.046926] PC is at skb_release_data+0x6c/0x14c
> [14538.051518] LR is at consume_skb+0x38/0xd8
> [14538.055588] pc : [<c10e439c>]    lr : [<c10e3fac>]    psr: 200f0013
> [14538.061817] sp : c28f1da8  ip : 00000000  fp : c265aa40
> [14538.067010] r10: 00000000  r9 : 00000000  r8 : c2f98000
> [14538.072204] r7 : c511d900  r6 : c3d3d900  r5 : c3d3d900  r4 : 00000000
> [14538.078693] r3 : 000000d3  r2 : 00000001  r1 : 00000000  r0 : 00000000

> [14538.263039] [<c10e439c>] (skb_release_data) from [<c10e3fac>] (consume_skb+0x38/0xd8)
> [14538.270834] [<c10e3fac>] (consume_skb) from [<c0d529bc>] (gfar_start_xmit+0x704/0x784)
> [14538.278714] [<c0d529bc>] (gfar_start_xmit) from [<c10fcdf8>] (dev_hard_start_xmit+0xfc/0x254)
> [14538.287198] [<c10fcdf8>] (dev_hard_start_xmit) from [<c1158524>] (sch_direct_xmit+0x104/0x2e0)

Looks like one of the error paths freeing a wonky skb.

Could you decode these addresses to line numbers?

  reply	other threads:[~2020-11-03 16:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 13:53 PROBLEM: Crash when timestamping outgoing PTP packets under heavy network load (ppc, gianfar) James Jurack
2020-10-20 17:36 ` [PATCH net] gianfar: Account for Tx PTP timestamp in the skb headroom Claudiu Manoil
2020-10-21 17:59   ` Jakub Kicinski
2020-10-22 12:09     ` Claudiu Manoil
2020-10-23  2:54       ` Jakub Kicinski
2020-10-23 11:37         ` Claudiu Manoil
2020-10-29  8:10 ` [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow_head for PTP Claudiu Manoil
2020-10-29  8:10   ` [PATCH net v2 2/2] gianfar: Account for Tx PTP timestamp in the skb headroom Claudiu Manoil
2020-10-30 16:41   ` [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow_head for PTP Jakub Kicinski
2020-11-03 16:13   ` Vladimir Oltean
2020-11-03 16:30     ` Jakub Kicinski [this message]
2020-11-03 17:18       ` Claudiu Manoil
2020-11-03 17:30         ` Vladimir Oltean
2020-11-03 17:36           ` Jakub Kicinski
2020-11-03 17:39             ` Jakub Kicinski
2020-11-03 17:51             ` Vladimir Oltean
2020-11-03 17:41           ` Claudiu Manoil
2020-11-03 17:49             ` Vladimir Oltean
2020-11-03 18:16               ` Eric Dumazet
2020-11-04 16:45                 ` Claudiu Manoil
2020-11-03 18:16               ` Vladimir Oltean
2020-11-03 16:36     ` Julian Wiedmann
2020-11-03 17:08       ` Claudiu Manoil
2020-11-03 17:12         ` Jakub Kicinski
2020-11-03 17:24           ` Vladimir Oltean
2020-11-03 17:38             ` Vladimir Oltean
2020-11-03 17:18       ` Vladimir Oltean
2020-11-03 17:27         ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103083050.100b2568@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
    --to=kuba@kernel.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=james.jurack@ametek.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).