From: Vladimir Oltean <olteanv@gmail.com>
To: Julian Wiedmann <jwi@linux.ibm.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
james.jurack@ametek.com
Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow_head for PTP
Date: Tue, 3 Nov 2020 19:27:41 +0200 [thread overview]
Message-ID: <20201103172741.iia5joaxeww6c454@skbuf> (raw)
In-Reply-To: <20201103171849.vthpu7beenzeayrs@skbuf>
On Tue, Nov 03, 2020 at 07:18:49PM +0200, Vladimir Oltean wrote:
> On Tue, Nov 03, 2020 at 06:36:30PM +0200, Julian Wiedmann wrote:
> > Given the various skb modifications in its xmit path, I wonder why
> > gianfar doesn't clear IFF_TX_SKB_SHARING.
>
> Thanks for the hint Julian :) I'll try to see if it makes any
> difference.
And unsurprisingly given what Jakub said, it crashed again, even with
this change.
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index 41dd3d0f3452..7cc8986910f8 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -3337,6 +3337,7 @@ static int gfar_probe(struct platform_device *ofdev)
dev->mtu = 1500;
dev->min_mtu = 50;
dev->max_mtu = GFAR_JUMBO_FRAME_SIZE - ETH_HLEN;
+ dev->priv_flags &= ~IFF_TX_SKB_SHARING;
dev->netdev_ops = &gfar_netdev_ops;
dev->ethtool_ops = &gfar_ethtool_ops;
prev parent reply other threads:[~2020-11-03 17:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 13:53 PROBLEM: Crash when timestamping outgoing PTP packets under heavy network load (ppc, gianfar) James Jurack
2020-10-20 17:36 ` [PATCH net] gianfar: Account for Tx PTP timestamp in the skb headroom Claudiu Manoil
2020-10-21 17:59 ` Jakub Kicinski
2020-10-22 12:09 ` Claudiu Manoil
2020-10-23 2:54 ` Jakub Kicinski
2020-10-23 11:37 ` Claudiu Manoil
2020-10-29 8:10 ` [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow_head for PTP Claudiu Manoil
2020-10-29 8:10 ` [PATCH net v2 2/2] gianfar: Account for Tx PTP timestamp in the skb headroom Claudiu Manoil
2020-10-30 16:41 ` [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow_head for PTP Jakub Kicinski
2020-11-03 16:13 ` Vladimir Oltean
2020-11-03 16:30 ` Jakub Kicinski
2020-11-03 17:18 ` Claudiu Manoil
2020-11-03 17:30 ` Vladimir Oltean
2020-11-03 17:36 ` Jakub Kicinski
2020-11-03 17:39 ` Jakub Kicinski
2020-11-03 17:51 ` Vladimir Oltean
2020-11-03 17:41 ` Claudiu Manoil
2020-11-03 17:49 ` Vladimir Oltean
2020-11-03 18:16 ` Eric Dumazet
2020-11-04 16:45 ` Claudiu Manoil
2020-11-03 18:16 ` Vladimir Oltean
2020-11-03 16:36 ` Julian Wiedmann
2020-11-03 17:08 ` Claudiu Manoil
2020-11-03 17:12 ` Jakub Kicinski
2020-11-03 17:24 ` Vladimir Oltean
2020-11-03 17:38 ` Vladimir Oltean
2020-11-03 17:18 ` Vladimir Oltean
2020-11-03 17:27 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103172741.iia5joaxeww6c454@skbuf \
--to=olteanv@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=james.jurack@ametek.com \
--cc=jwi@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).