From: Jakub Kicinski <kuba@kernel.org>
To: "Georg Kohmann (geokohma)" <geokohma@cisco.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"kadlec@netfilter.org" <kadlec@netfilter.org>,
"fw@strlen.de" <fw@strlen.de>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuznet@ms2.inr.ac.ru" <kuznet@ms2.inr.ac.ru>,
"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>
Subject: Re: [PATCH net v3] ipv6/netfilter: Discard first fragment not including all headers
Date: Mon, 9 Nov 2020 14:16:58 -0800 [thread overview]
Message-ID: <20201109141658.0265373d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <3c81d2ae-ba14-60d8-247d-87fabf407fea@cisco.com>
On Mon, 9 Nov 2020 22:08:47 +0000 Georg Kohmann (geokohma) wrote:
> >> +bool ipv6_frag_validate(struct sk_buff *skb, int start, u8 *nexthdrp)
> > (a) why place this function in exthdrs_core? I don't see any header
> > specific code here, IMO it belongs in reassembly.c.
>
> ipv6_frag_validate() is used in both reassembly.c and nf_conntrack_reasm.c
> Where should I put the prototype so it can be used both places?
The prototype can stay in net/ipv6.h
prev parent reply other threads:[~2020-11-09 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 11:52 [PATCH net v3] ipv6/netfilter: Discard first fragment not including all headers Georg Kohmann
2020-11-09 20:50 ` Jakub Kicinski
2020-11-09 22:08 ` Georg Kohmann (geokohma)
2020-11-09 22:16 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109141658.0265373d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=geokohma@cisco.com \
--cc=kadlec@netfilter.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).