* [PATCH 0/6] Rid i2400m driver set of W=1 issues
@ 2020-11-12 13:19 Lee Jones
2020-11-12 13:19 ` [PATCH 1/6] staging: net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Lee Jones @ 2020-11-12 13:19 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, Lee Jones, David S. Miller, devel,
Inaky Perez-Gonzalez, Jakub Kicinski, linux-wimax, netdev,
Yanir Lubetkin
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This is a rebased set that went to Net before the move to Staging.
Lee Jones (6):
staging: net: wimax: i2400m: control: Fix some misspellings in
i2400m_set_init_config()'s docs
staging: net: wimax: i2400m: driver: Demote some non-conformant
kernel-docs, fix others
staging: net: wimax: i2400m: fw: Fix some function header
misdemeanours
staging: net: wimax: i2400m: netdev: Demote non-conformant function
header
staging: net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours
staging: net: wimax: i2400m: fw: Fix incorrectly spelt function
parameter in documentation
drivers/staging/wimax/i2400m/control.c | 4 ++--
drivers/staging/wimax/i2400m/driver.c | 9 +++++----
drivers/staging/wimax/i2400m/fw.c | 14 +++++++++++---
drivers/staging/wimax/i2400m/netdev.c | 2 +-
drivers/staging/wimax/i2400m/tx.c | 6 +++++-
5 files changed, 24 insertions(+), 11 deletions(-)
Cc: "David S. Miller" <davem@davemloft.net>
Cc: devel@driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wimax@intel.com
Cc: netdev@vger.kernel.org
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/6] staging: net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs
2020-11-12 13:19 [PATCH 0/6] Rid i2400m driver set of W=1 issues Lee Jones
@ 2020-11-12 13:19 ` Lee Jones
2020-11-12 13:19 ` [PATCH 2/6] staging: net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2020-11-12 13:19 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, Lee Jones, Inaky Perez-Gonzalez, linux-wimax,
David S. Miller, Jakub Kicinski, netdev, devel
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/control.c:1195: warning: Function parameter or member 'arg' not described in 'i2400m_set_init_config'
drivers/net/wimax/i2400m/control.c:1195: warning: Excess function parameter 'arg_size' description in 'i2400m_set_init_config'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/control.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/control.c b/drivers/staging/wimax/i2400m/control.c
index fe885aa56cf37..1e270b2101e86 100644
--- a/drivers/staging/wimax/i2400m/control.c
+++ b/drivers/staging/wimax/i2400m/control.c
@@ -1183,11 +1183,11 @@ static int i2400m_cmd_get_state(struct i2400m *i2400m)
* Set basic configuration settings
*
* @i2400m: device descriptor
- * @args: array of pointers to the TLV headers to send for
+ * @arg: array of pointers to the TLV headers to send for
* configuration (each followed by its payload).
* TLV headers and payloads must be properly initialized, with the
* right endianess (LE).
- * @arg_size: number of pointers in the @args array
+ * @args: number of pointers in the @arg array
*/
static int i2400m_set_init_config(struct i2400m *i2400m,
const struct i2400m_tlv_hdr **arg,
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/6] staging: net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others
2020-11-12 13:19 [PATCH 0/6] Rid i2400m driver set of W=1 issues Lee Jones
2020-11-12 13:19 ` [PATCH 1/6] staging: net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
@ 2020-11-12 13:19 ` Lee Jones
2020-11-12 13:19 ` [PATCH 3/6] staging: net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2020-11-12 13:19 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, Lee Jones, Inaky Perez-Gonzalez, linux-wimax,
David S. Miller, Jakub Kicinski, netdev, devel
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/driver.c:681: warning: Function parameter or member 'i2400m' not described in 'i2400m_dev_reset_handle'
drivers/net/wimax/i2400m/driver.c:681: warning: Function parameter or member 'reason' not described in 'i2400m_dev_reset_handle'
drivers/net/wimax/i2400m/driver.c:775: warning: Function parameter or member 'i2400m' not described in 'i2400m_init'
drivers/net/wimax/i2400m/driver.c:842: warning: Function parameter or member 'bm_flags' not described in 'i2400m_setup'
drivers/net/wimax/i2400m/driver.c:942: warning: Function parameter or member 'i2400m' not described in 'i2400m_release'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/driver.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/driver.c b/drivers/staging/wimax/i2400m/driver.c
index dc8939ff78c0e..f5186458bb3d4 100644
--- a/drivers/staging/wimax/i2400m/driver.c
+++ b/drivers/staging/wimax/i2400m/driver.c
@@ -665,7 +665,7 @@ void __i2400m_dev_reset_handle(struct work_struct *ws)
}
-/**
+/*
* i2400m_dev_reset_handle - Handle a device's reset in a thread context
*
* Schedule a device reset handling out on a thread context, so it
@@ -685,7 +685,7 @@ int i2400m_dev_reset_handle(struct i2400m *i2400m, const char *reason)
EXPORT_SYMBOL_GPL(i2400m_dev_reset_handle);
- /*
+/*
* The actual work of error recovery.
*
* The current implementation of error recovery is to trigger a bus reset.
@@ -766,7 +766,7 @@ void i2400m_bm_buf_free(struct i2400m *i2400m)
}
-/**
+/*
* i2400m_init - Initialize a 'struct i2400m' from all zeroes
*
* This is a bus-generic API call.
@@ -831,6 +831,7 @@ EXPORT_SYMBOL_GPL(i2400m_reset);
* i2400m_setup - bus-generic setup function for the i2400m device
*
* @i2400m: device descriptor (bus-specific parts have been initialized)
+ * @bm_flags: boot mode flags
*
* Returns: 0 if ok, < 0 errno code on error.
*
@@ -933,7 +934,7 @@ int i2400m_setup(struct i2400m *i2400m, enum i2400m_bri bm_flags)
EXPORT_SYMBOL_GPL(i2400m_setup);
-/**
+/*
* i2400m_release - release the bus-generic driver resources
*
* Sends a disconnect message and undoes any setup done by i2400m_setup()
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/6] staging: net: wimax: i2400m: fw: Fix some function header misdemeanours
2020-11-12 13:19 [PATCH 0/6] Rid i2400m driver set of W=1 issues Lee Jones
2020-11-12 13:19 ` [PATCH 1/6] staging: net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
2020-11-12 13:19 ` [PATCH 2/6] staging: net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
@ 2020-11-12 13:19 ` Lee Jones
2020-11-12 13:19 ` [PATCH 4/6] staging: net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2020-11-12 13:19 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, Lee Jones, Inaky Perez-Gonzalez, linux-wimax,
David S. Miller, Jakub Kicinski, Yanir Lubetkin, netdev, devel
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/fw.c:584: warning: Function parameter or member 'i2400m' not described in 'i2400m_bm_cmd'
drivers/net/wimax/i2400m/fw.c:584: warning: Excess function parameter 'returns' description in 'i2400m_bm_cmd'
drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member 'chunk' not described in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member '__chunk_len' not described in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf' description in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf_len' description in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:1548: warning: Function parameter or member 'flags' not described in 'i2400m_dev_bootstrap'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/fw.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
index 6c9a41bff2e0a..9970857063374 100644
--- a/drivers/staging/wimax/i2400m/fw.c
+++ b/drivers/staging/wimax/i2400m/fw.c
@@ -534,6 +534,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
/**
* i2400m_bm_cmd - Execute a boot mode command
*
+ * @i2400m: device descriptor
* @cmd: buffer containing the command data (pointing at the header).
* This data can be ANYWHERE (for USB, we will copy it to an
* specific buffer). Make sure everything is in proper little
@@ -566,7 +567,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
*
* @flags: see I2400M_BM_CMD_* above.
*
- * @returns: bytes received by the notification; if < 0, an errno code
+ * Returns: bytes received by the notification; if < 0, an errno code
* denoting an error or:
*
* -ERESTARTSYS The device has rebooted
@@ -634,8 +635,8 @@ ssize_t i2400m_bm_cmd(struct i2400m *i2400m,
* i2400m_download_chunk - write a single chunk of data to the device's memory
*
* @i2400m: device descriptor
- * @buf: the buffer to write
- * @buf_len: length of the buffer to write
+ * @chunk: the buffer to write
+ * @chunk_len: length of the buffer to write
* @addr: address in the device memory space
* @direct: bootrom write mode
* @do_csum: should a checksum validation be performed
@@ -1533,6 +1534,13 @@ void i2400m_fw_put(struct i2400m_fw *i2400m_fw)
* i2400m_dev_bootstrap - Bring the device to a known state and upload firmware
*
* @i2400m: device descriptor
+ * @flags:
+ * I2400M_BRI_SOFT: a reboot barker has been seen
+ * already, so don't wait for it.
+ *
+ * I2400M_BRI_NO_REBOOT: Don't send a reboot command, but wait
+ * for a reboot barker notification. This is a one shot; if
+ * the state machine needs to send a reboot command it will.
*
* Returns: >= 0 if ok, < 0 errno code on error.
*
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/6] staging: net: wimax: i2400m: netdev: Demote non-conformant function header
2020-11-12 13:19 [PATCH 0/6] Rid i2400m driver set of W=1 issues Lee Jones
` (2 preceding siblings ...)
2020-11-12 13:19 ` [PATCH 3/6] staging: net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
@ 2020-11-12 13:19 ` Lee Jones
2020-11-12 13:19 ` [PATCH 5/6] staging: net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
2020-11-12 13:19 ` [PATCH 6/6] staging: net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
5 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2020-11-12 13:19 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, Lee Jones, Inaky Perez-Gonzalez, linux-wimax,
David S. Miller, Jakub Kicinski, Yanir Lubetkin, netdev, devel
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/netdev.c:583: warning: Function parameter or member 'net_dev' not described in 'i2400m_netdev_setup'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/netdev.c b/drivers/staging/wimax/i2400m/netdev.c
index a7fcbceb6e6be..8339d600e77b5 100644
--- a/drivers/staging/wimax/i2400m/netdev.c
+++ b/drivers/staging/wimax/i2400m/netdev.c
@@ -574,7 +574,7 @@ static const struct ethtool_ops i2400m_ethtool_ops = {
.get_link = ethtool_op_get_link,
};
-/**
+/*
* i2400m_netdev_setup - Setup setup @net_dev's i2400m private data
*
* Called by alloc_netdev()
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 5/6] staging: net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours
2020-11-12 13:19 [PATCH 0/6] Rid i2400m driver set of W=1 issues Lee Jones
` (3 preceding siblings ...)
2020-11-12 13:19 ` [PATCH 4/6] staging: net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
@ 2020-11-12 13:19 ` Lee Jones
2020-11-12 13:19 ` [PATCH 6/6] staging: net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
5 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2020-11-12 13:19 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, Lee Jones, Inaky Perez-Gonzalez, linux-wimax,
David S. Miller, Jakub Kicinski, Yanir Lubetkin, netdev, devel
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/tx.c:715: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx'
drivers/net/wimax/i2400m/tx.c:964: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx_setup'
drivers/net/wimax/i2400m/tx.c:1005: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx_release'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/tx.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/tx.c b/drivers/staging/wimax/i2400m/tx.c
index 1255302e251e4..e9436212fe54d 100644
--- a/drivers/staging/wimax/i2400m/tx.c
+++ b/drivers/staging/wimax/i2400m/tx.c
@@ -681,6 +681,8 @@ void i2400m_tx_close(struct i2400m *i2400m)
/**
* i2400m_tx - send the data in a buffer to the device
*
+ * @i2400m: device descriptor
+ *
* @buf: pointer to the buffer to transmit
*
* @buf_len: buffer size
@@ -955,6 +957,8 @@ EXPORT_SYMBOL_GPL(i2400m_tx_msg_sent);
/**
* i2400m_tx_setup - Initialize the TX queue and infrastructure
*
+ * @i2400m: device descriptor
+ *
* Make sure we reset the TX sequence to zero, as when this function
* is called, the firmware has been just restarted. Same rational
* for tx_in, tx_out, tx_msg_size and tx_msg. We reset them since
@@ -998,7 +1002,7 @@ int i2400m_tx_setup(struct i2400m *i2400m)
}
-/**
+/*
* i2400m_tx_release - Tear down the TX queue and infrastructure
*/
void i2400m_tx_release(struct i2400m *i2400m)
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 6/6] staging: net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation
2020-11-12 13:19 [PATCH 0/6] Rid i2400m driver set of W=1 issues Lee Jones
` (4 preceding siblings ...)
2020-11-12 13:19 ` [PATCH 5/6] staging: net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
@ 2020-11-12 13:19 ` Lee Jones
5 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2020-11-12 13:19 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, Lee Jones, Inaky Perez-Gonzalez, linux-wimax,
David S. Miller, Jakub Kicinski, Yanir Lubetkin, netdev, devel
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/fw.c:647: warning: Function parameter or member '__chunk_len' not described in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:647: warning: Excess function parameter 'chunk_len' description in 'i2400m_download_chunk'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
index 9970857063374..edb5eba0898b0 100644
--- a/drivers/staging/wimax/i2400m/fw.c
+++ b/drivers/staging/wimax/i2400m/fw.c
@@ -636,7 +636,7 @@ ssize_t i2400m_bm_cmd(struct i2400m *i2400m,
*
* @i2400m: device descriptor
* @chunk: the buffer to write
- * @chunk_len: length of the buffer to write
+ * @__chunk_len: length of the buffer to write
* @addr: address in the device memory space
* @direct: bootrom write mode
* @do_csum: should a checksum validation be performed
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-12 13:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 13:19 [PATCH 0/6] Rid i2400m driver set of W=1 issues Lee Jones
2020-11-12 13:19 ` [PATCH 1/6] staging: net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
2020-11-12 13:19 ` [PATCH 2/6] staging: net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
2020-11-12 13:19 ` [PATCH 3/6] staging: net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
2020-11-12 13:19 ` [PATCH 4/6] staging: net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
2020-11-12 13:19 ` [PATCH 5/6] staging: net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
2020-11-12 13:19 ` [PATCH 6/6] staging: net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).