* [PATCH] IPv6: RTM_GETROUTE: Add RTA_ENCAP to result
@ 2020-11-15 10:55 Oliver Herms
2020-11-17 1:46 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Herms @ 2020-11-15 10:55 UTC (permalink / raw)
To: netdev; +Cc: davem, kuznet, yoshfuji, kuba
This patch adds an IPv6 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(e.g. ip route get 2001:db8::).
Signed-off-by: Oliver Herms <oliver.peter.herms@gmail.com>
---
net/ipv6/route.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 82cbb46a2a4f..4d45696a70eb 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -5489,6 +5489,11 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
rtm->rtm_scope = RT_SCOPE_UNIVERSE;
rtm->rtm_protocol = rt->fib6_protocol;
+ if (dst && dst->lwtstate &&
+ lwtunnel_fill_encap(skb, dst->lwtstate, RTA_ENCAP, RTA_ENCAP_TYPE) < 0) {
+ goto nla_put_failure;
+ }
+
if (rt6_flags & RTF_CACHE)
rtm->rtm_flags |= RTM_F_CLONED;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IPv6: RTM_GETROUTE: Add RTA_ENCAP to result
2020-11-15 10:55 [PATCH] IPv6: RTM_GETROUTE: Add RTA_ENCAP to result Oliver Herms
@ 2020-11-17 1:46 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-11-17 1:46 UTC (permalink / raw)
To: Oliver Herms; +Cc: netdev, davem, kuznet, yoshfuji
On Sun, 15 Nov 2020 11:55:27 +0100 Oliver Herms wrote:
> This patch adds an IPv6 routes encapsulation attribute
> to the result of netlink RTM_GETROUTE requests
> (e.g. ip route get 2001:db8::).
>
> Signed-off-by: Oliver Herms <oliver.peter.herms@gmail.com>
> ---
> net/ipv6/route.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 82cbb46a2a4f..4d45696a70eb 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -5489,6 +5489,11 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
> rtm->rtm_scope = RT_SCOPE_UNIVERSE;
> rtm->rtm_protocol = rt->fib6_protocol;
>
> + if (dst && dst->lwtstate &&
> + lwtunnel_fill_encap(skb, dst->lwtstate, RTA_ENCAP, RTA_ENCAP_TYPE) < 0) {
> + goto nla_put_failure;
> + }
curly brackets are not required around a single statement
Please fix and CC David Ahern, since he reviewed your corresponding
IPv4 patch.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-17 1:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-15 10:55 [PATCH] IPv6: RTM_GETROUTE: Add RTA_ENCAP to result Oliver Herms
2020-11-17 1:46 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).