* [PATCH] net: flow_offload: remove trailing semicolon in macro definition
@ 2020-11-27 19:37 trix
2020-11-30 9:24 ` Edward Cree
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-11-27 19:37 UTC (permalink / raw)
To: davem, kuba, wenxu, pablo, jiri, herbert, paulb, john.hurley
Cc: netdev, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
net/core/flow_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c
index d4474c812b64..59ddfd3f3876 100644
--- a/net/core/flow_offload.c
+++ b/net/core/flow_offload.c
@@ -32,7 +32,7 @@ EXPORT_SYMBOL(flow_rule_alloc);
struct flow_dissector *__d = (__m)->dissector; \
\
(__out)->key = skb_flow_dissector_target(__d, __type, (__m)->key); \
- (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask); \
+ (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask) \
void flow_rule_match_meta(const struct flow_rule *rule,
struct flow_match_meta *out)
--
2.18.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: flow_offload: remove trailing semicolon in macro definition
2020-11-27 19:37 [PATCH] net: flow_offload: remove trailing semicolon in macro definition trix
@ 2020-11-30 9:24 ` Edward Cree
0 siblings, 0 replies; 2+ messages in thread
From: Edward Cree @ 2020-11-30 9:24 UTC (permalink / raw)
To: trix, davem, kuba, wenxu, pablo, jiri, herbert, paulb, john.hurley
Cc: netdev, linux-kernel
On 27/11/2020 19:37, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> net/core/flow_offload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c
> index d4474c812b64..59ddfd3f3876 100644
> --- a/net/core/flow_offload.c
> +++ b/net/core/flow_offload.c
> @@ -32,7 +32,7 @@ EXPORT_SYMBOL(flow_rule_alloc);
> struct flow_dissector *__d = (__m)->dissector; \
> \
> (__out)->key = skb_flow_dissector_target(__d, __type, (__m)->key); \
> - (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask); \
> + (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask) \
> Strictly speaking shouldn't this macro have a do {} while (0)
around it anyway?
-ed
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 19:37 [PATCH] net: flow_offload: remove trailing semicolon in macro definition trix
2020-11-30 9:24 ` Edward Cree
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).