From: Steen Hegelund <steen.hegelund@microchip.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Lars Povlsen <lars.povlsen@microchip.com>,
Bjarni Jonasson <bjarni.jonasson@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Microsemi List <microsemi@lists.bootlin.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver
Date: Mon, 30 Nov 2020 14:13:35 +0100 [thread overview]
Message-ID: <20201130131335.afasdxbf5ilhsxue@mchp-dev-shegelun> (raw)
In-Reply-To: <20201127171506.GW2073444@lunn.ch>
On 27.11.2020 18:15, Andrew Lunn wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>This is a very large driver, which is going to make it slow to review.
Hi Andrew,
Yes I am aware of that, but I think that what is available with this
series, makes for a nice package that can be tested by us, and used by
our customers.
>
>> +static int sparx5_probe_port(struct sparx5 *sparx5,
>> + struct device_node *portnp,
>> + struct phy *serdes,
>> + u32 portno,
>> + struct sparx5_port_config *conf)
>> +{
>> + phy_interface_t phy_mode = conf->phy_mode;
>> + struct sparx5_port *spx5_port;
>> + struct net_device *ndev;
>> + struct phylink *phylink;
>> + int err;
>> +
>> + err = sparx5_create_targets(sparx5);
>> + if (err)
>> + return err;
>> + ndev = sparx5_create_netdev(sparx5, portno);
>> + if (IS_ERR(ndev)) {
>> + dev_err(sparx5->dev, "Could not create net device: %02u\n", portno);
>> + return PTR_ERR(ndev);
>> + }
>> + spx5_port = netdev_priv(ndev);
>> + spx5_port->of_node = portnp;
>> + spx5_port->serdes = serdes;
>> + spx5_port->pvid = NULL_VID;
>> + spx5_port->signd_internal = true;
>> + spx5_port->signd_active_high = true;
>> + spx5_port->signd_enable = true;
>> + spx5_port->flow_control = false;
>> + spx5_port->max_vlan_tags = SPX5_PORT_MAX_TAGS_NONE;
>> + spx5_port->vlan_type = SPX5_VLAN_PORT_TYPE_UNAWARE;
>> + spx5_port->custom_etype = 0x8880; /* Vitesse */
>> + conf->portmode = conf->phy_mode;
>> + spx5_port->conf.speed = SPEED_UNKNOWN;
>> + spx5_port->conf.power_down = true;
>> + sparx5->ports[portno] = spx5_port;
>
>
>> +struct net_device *sparx5_create_netdev(struct sparx5 *sparx5, u32 portno)
>> +{
>> + struct net_device *ndev;
>> + struct sparx5_port *spx5_port;
>> + int err;
>> +
>> + ndev = devm_alloc_etherdev(sparx5->dev, sizeof(struct sparx5_port));
>> + if (!ndev)
>> + return ERR_PTR(-ENOMEM);
>> +
>
>...
>
>> + err = register_netdev(ndev);
>> + if (err) {
>> + dev_err(sparx5->dev, "netdev registration failed\n");
>> + return ERR_PTR(err);
>> + }
>
>This is one of the classic bugs in network drivers. As soon as you
>call register_netdev() the interface is live. The network stack can
>start using it. But you have not finished initialzing spx5_port. So
>bad things are going to happen.
Oops. I will fix that.
Thanks for the comments.
Steen
>
> Andrew
BR
Steen
---------------------------------------
Steen Hegelund
steen.hegelund@microchip.com
next prev parent reply other threads:[~2020-11-30 13:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 13:33 [RFC PATCH 0/3] net: Adding the Sparx5 Switch Driver Steen Hegelund
2020-11-27 13:33 ` [RFC PATCH 1/3] dt-bindings: net: sparx5: Add sparx5-switch bindings Steen Hegelund
2020-11-27 17:00 ` Andrew Lunn
2020-11-30 13:09 ` Steen Hegelund
2020-11-30 14:05 ` Andrew Lunn
2020-11-30 15:33 ` Steen Hegelund
2020-11-27 13:33 ` [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver Steen Hegelund
2020-11-27 17:15 ` Andrew Lunn
2020-11-30 13:13 ` Steen Hegelund [this message]
2020-12-07 13:33 ` Jiri Pirko
2020-11-28 18:45 ` Andrew Lunn
2020-11-30 13:17 ` Steen Hegelund
2020-11-28 19:03 ` Andrew Lunn
2020-11-30 13:28 ` Steen Hegelund
2020-11-30 15:34 ` Andrew Lunn
2020-11-28 19:06 ` Andrew Lunn
2020-11-28 19:37 ` Russell King - ARM Linux admin
2020-11-28 20:07 ` Alexandre Belloni
2020-11-28 20:21 ` Andrew Lunn
2020-11-28 22:28 ` Russell King - ARM Linux admin
2020-11-29 10:52 ` Russell King - ARM Linux admin
2020-11-29 11:28 ` Russell King - ARM Linux admin
2020-11-30 14:39 ` Steen Hegelund
2020-11-30 14:54 ` Russell King - ARM Linux admin
2020-11-29 11:30 ` Russell King - ARM Linux admin
2020-11-30 14:30 ` Steen Hegelund
2020-11-30 14:50 ` Russell King - ARM Linux admin
2020-11-30 14:15 ` Steen Hegelund
2020-11-30 14:52 ` Russell King - ARM Linux admin
2020-11-30 14:10 ` Steen Hegelund
2020-11-28 19:24 ` Andrew Lunn
2020-12-01 11:11 ` Lars Povlsen
2020-11-29 17:16 ` Andrew Lunn
2020-11-30 13:33 ` Steen Hegelund
2020-11-29 17:26 ` Andrew Lunn
2020-11-30 13:31 ` Steen Hegelund
2020-11-29 17:35 ` Andrew Lunn
2020-11-30 14:42 ` Steen Hegelund
2020-11-27 13:33 ` [RFC PATCH 3/3] arm64: dts: sparx5: Add the Sparx5 switch node Steen Hegelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130131335.afasdxbf5ilhsxue@mchp-dev-shegelun \
--to=steen.hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=microsemi@lists.bootlin.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).