From: Steen Hegelund <steen.hegelund@microchip.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Lars Povlsen <lars.povlsen@microchip.com>,
Bjarni Jonasson <bjarni.jonasson@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Microsemi List <microsemi@lists.bootlin.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver
Date: Mon, 30 Nov 2020 14:28:35 +0100 [thread overview]
Message-ID: <20201130132835.7ln72bbdr36spuwm@mchp-dev-shegelun> (raw)
In-Reply-To: <20201128190334.GE2191767@lunn.ch>
On 28.11.2020 20:03, Andrew Lunn wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> +static int sparx5_port_open(struct net_device *ndev)
>> +{
>> + struct sparx5_port *port = netdev_priv(ndev);
>> + int err = 0;
>> +
>> + sparx5_port_enable(port, true);
>> + if (port->conf.phy_mode != PHY_INTERFACE_MODE_NA) {
>> + err = phylink_of_phy_connect(port->phylink, port->of_node, 0);
>> + if (err) {
>> + netdev_err(ndev, "Could not attach to PHY\n");
>> + return err;
>> + }
>> + }
>
>This looks a bit odd. PHY_INTERFACE_MODE_NA means don't touch,
>something else has already configured the MAC-PHY mode in the PHY.
>You should not not connect the PHY because of this.
Hmm. I will have to revisit this again. The intent was to be able to
destinguish between regular PHYs and SFPs (as read from the DT).
But maybe the phylink_of_phy_connect function handles this
automatically...
>
>> +void sparx5_destroy_netdev(struct sparx5 *sparx5, struct sparx5_port *port)
>> +{
>> + if (port->phylink) {
>> + /* Disconnect the phy */
>> + if (rtnl_trylock()) {
>
>Why do you use rtnl_trylock()?
The sparx5_port_stop() in turn calls phylink_stop() that expects the lock
to be taken. Should I rather just call rtnl_lock()?
Thanks for your comments
/Steen
>
> Andrew
BR
Steen
---------------------------------------
Steen Hegelund
steen.hegelund@microchip.com
next prev parent reply other threads:[~2020-11-30 13:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 13:33 [RFC PATCH 0/3] net: Adding the Sparx5 Switch Driver Steen Hegelund
2020-11-27 13:33 ` [RFC PATCH 1/3] dt-bindings: net: sparx5: Add sparx5-switch bindings Steen Hegelund
2020-11-27 17:00 ` Andrew Lunn
2020-11-30 13:09 ` Steen Hegelund
2020-11-30 14:05 ` Andrew Lunn
2020-11-30 15:33 ` Steen Hegelund
2020-11-27 13:33 ` [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver Steen Hegelund
2020-11-27 17:15 ` Andrew Lunn
2020-11-30 13:13 ` Steen Hegelund
2020-12-07 13:33 ` Jiri Pirko
2020-11-28 18:45 ` Andrew Lunn
2020-11-30 13:17 ` Steen Hegelund
2020-11-28 19:03 ` Andrew Lunn
2020-11-30 13:28 ` Steen Hegelund [this message]
2020-11-30 15:34 ` Andrew Lunn
2020-11-28 19:06 ` Andrew Lunn
2020-11-28 19:37 ` Russell King - ARM Linux admin
2020-11-28 20:07 ` Alexandre Belloni
2020-11-28 20:21 ` Andrew Lunn
2020-11-28 22:28 ` Russell King - ARM Linux admin
2020-11-29 10:52 ` Russell King - ARM Linux admin
2020-11-29 11:28 ` Russell King - ARM Linux admin
2020-11-30 14:39 ` Steen Hegelund
2020-11-30 14:54 ` Russell King - ARM Linux admin
2020-11-29 11:30 ` Russell King - ARM Linux admin
2020-11-30 14:30 ` Steen Hegelund
2020-11-30 14:50 ` Russell King - ARM Linux admin
2020-11-30 14:15 ` Steen Hegelund
2020-11-30 14:52 ` Russell King - ARM Linux admin
2020-11-30 14:10 ` Steen Hegelund
2020-11-28 19:24 ` Andrew Lunn
2020-12-01 11:11 ` Lars Povlsen
2020-11-29 17:16 ` Andrew Lunn
2020-11-30 13:33 ` Steen Hegelund
2020-11-29 17:26 ` Andrew Lunn
2020-11-30 13:31 ` Steen Hegelund
2020-11-29 17:35 ` Andrew Lunn
2020-11-30 14:42 ` Steen Hegelund
2020-11-27 13:33 ` [RFC PATCH 3/3] arm64: dts: sparx5: Add the Sparx5 switch node Steen Hegelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130132835.7ln72bbdr36spuwm@mchp-dev-shegelun \
--to=steen.hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=microsemi@lists.bootlin.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).