* [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE
@ 2021-01-05 9:15 Michael Ellerman
2021-01-05 14:22 ` Andrew Lunn
2021-01-06 0:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-01-05 9:15 UTC (permalink / raw)
To: netdev; +Cc: davem, pantelis.antoniou, kuba, linux-kernel, linuxppc-dev, andrew
Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE()
into error") the ppc32_allmodconfig build fails with:
ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o
ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o
Add the missing MODULE_LICENSEs to fix the build. Both files include a
copyright header indicating they are GPL v2.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 +
drivers/net/ethernet/freescale/fs_enet/mii-fec.c | 1 +
2 files changed, 2 insertions(+)
v2: Use simply "GPL" as pointed out by Andrew:
https://lore.kernel.org/lkml/X%2FPRX+RziaU3IJGi@lunn.ch/
diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
index c8e5d889bd81..21de56345503 100644
--- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
+++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
@@ -223,3 +223,4 @@ static struct platform_driver fs_enet_bb_mdio_driver = {
};
module_platform_driver(fs_enet_bb_mdio_driver);
+MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
index 8b51ee142fa3..152f4d83765a 100644
--- a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
+++ b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
@@ -224,3 +224,4 @@ static struct platform_driver fs_enet_fec_mdio_driver = {
};
module_platform_driver(fs_enet_fec_mdio_driver);
+MODULE_LICENSE("GPL");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE
2021-01-05 9:15 [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE Michael Ellerman
@ 2021-01-05 14:22 ` Andrew Lunn
2021-01-06 0:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2021-01-05 14:22 UTC (permalink / raw)
To: Michael Ellerman
Cc: netdev, davem, pantelis.antoniou, kuba, linux-kernel, linuxppc-dev
On Tue, Jan 05, 2021 at 08:15:15PM +1100, Michael Ellerman wrote:
> Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE()
> into error") the ppc32_allmodconfig build fails with:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o
> ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o
>
> Add the missing MODULE_LICENSEs to fix the build. Both files include a
> copyright header indicating they are GPL v2.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE
2021-01-05 9:15 [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE Michael Ellerman
2021-01-05 14:22 ` Andrew Lunn
@ 2021-01-06 0:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2021-01-06 0:57 UTC (permalink / raw)
To: mpe; +Cc: netdev, pantelis.antoniou, kuba, linux-kernel, linuxppc-dev, andrew
From: Michael Ellerman <mpe@ellerman.id.au>
Date: Tue, 5 Jan 2021 20:15:15 +1100
> Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE()
> into error") the ppc32_allmodconfig build fails with:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o
> ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o
>
> Add the missing MODULE_LICENSEs to fix the build. Both files include a
> copyright header indicating they are GPL v2.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-06 0:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 9:15 [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE Michael Ellerman
2021-01-05 14:22 ` Andrew Lunn
2021-01-06 0:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).