* [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE
@ 2021-01-07 19:58 Aleksander Jan Bajkowski
2021-01-07 20:00 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Aleksander Jan Bajkowski @ 2021-01-07 19:58 UTC (permalink / raw)
To: hauke, martin.blumenstingl, andrew, vivien.didelot, f.fainelli,
olteanv, davem, kuba, netdev, linux-kernel
Cc: Aleksander Jan Bajkowski
Exclude RMII from modes that report 1 GbE support. Reduced MII supports
up to 100 MbE.
Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
drivers/net/dsa/lantiq_gswip.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 4b36d89bec06..662e68a0e7e6 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -1436,11 +1436,12 @@ static void gswip_phylink_validate(struct dsa_switch *ds, int port,
phylink_set(mask, Pause);
phylink_set(mask, Asym_Pause);
- /* With the exclusion of MII and Reverse MII, we support Gigabit,
- * including Half duplex
+ /* With the exclusion of MII, Reverse MII and Reduced MII, we
+ * support Gigabit, including Half duplex
*/
if (state->interface != PHY_INTERFACE_MODE_MII &&
- state->interface != PHY_INTERFACE_MODE_REVMII) {
+ state->interface != PHY_INTERFACE_MODE_REVMII &&
+ state->interface != PHY_INTERFACE_MODE_RMII) {
phylink_set(mask, 1000baseT_Full);
phylink_set(mask, 1000baseT_Half);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE
2021-01-07 19:58 [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE Aleksander Jan Bajkowski
@ 2021-01-07 20:00 ` Florian Fainelli
2021-01-08 3:02 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2021-01-07 20:00 UTC (permalink / raw)
To: Aleksander Jan Bajkowski, hauke, martin.blumenstingl, andrew,
vivien.didelot, olteanv, davem, kuba, netdev, linux-kernel
On 1/7/21 11:58 AM, Aleksander Jan Bajkowski wrote:
> Exclude RMII from modes that report 1 GbE support. Reduced MII supports
> up to 100 MbE.
>
> Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE
2021-01-07 20:00 ` Florian Fainelli
@ 2021-01-08 3:02 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-08 3:02 UTC (permalink / raw)
To: Florian Fainelli, Aleksander Jan Bajkowski
Cc: hauke, martin.blumenstingl, andrew, vivien.didelot, olteanv,
davem, netdev, linux-kernel
On Thu, 7 Jan 2021 12:00:44 -0800 Florian Fainelli wrote:
> On 1/7/21 11:58 AM, Aleksander Jan Bajkowski wrote:
> > Exclude RMII from modes that report 1 GbE support. Reduced MII supports
> > up to 100 MbE.
> >
> > Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Please make sure that the hash is at least 12 chars in the future.
> > Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-08 3:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 19:58 [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE Aleksander Jan Bajkowski
2021-01-07 20:00 ` Florian Fainelli
2021-01-08 3:02 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).