* [PATCH wireless v2] scsi: megaraid: Remove unnecessary memset
@ 2021-01-15 1:45 Zheng Yongjun
2021-01-25 14:38 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2021-01-15 1:45 UTC (permalink / raw)
To: davem, kuba, wcn36xx, linux-wireless, netdev, linux-kernel
Cc: kvalo, Zheng Yongjun
memcpy operation is next to memset code, and the size to copy
is equals to the size to memset, so the memset operation is
unnecessary, remove it.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/wireless/ath/wcn36xx/smd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 273fed22711f..5447a6696c35 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -478,7 +478,6 @@ static void init_hal_msg(struct wcn36xx_hal_msg_header *hdr,
#define PREPARE_HAL_BUF(send_buf, msg_body) \
do { \
- memset(send_buf, 0, msg_body.header.len); \
memcpy(send_buf, &msg_body, sizeof(msg_body)); \
} while (0) \
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH wireless v2] scsi: megaraid: Remove unnecessary memset
2021-01-15 1:45 [PATCH wireless v2] scsi: megaraid: Remove unnecessary memset Zheng Yongjun
@ 2021-01-25 14:38 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-01-25 14:38 UTC (permalink / raw)
To: Zheng Yongjun
Cc: davem, kuba, wcn36xx, linux-wireless, netdev, linux-kernel,
Zheng Yongjun
Zheng Yongjun <zhengyongjun3@huawei.com> wrote:
> memcpy operation is next to memset code, and the size to copy
> is equals to the size to memset, so the memset operation is
> unnecessary, remove it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Wrong title.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210115014559.7803-1-zhengyongjun3@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-26 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 1:45 [PATCH wireless v2] scsi: megaraid: Remove unnecessary memset Zheng Yongjun
2021-01-25 14:38 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).