* [PATCH net] selftests/net/fib_tests: remove duplicate log test
@ 2021-01-19 2:59 Hangbin Liu
2021-01-19 3:03 ` David Ahern
0 siblings, 1 reply; 3+ messages in thread
From: Hangbin Liu @ 2021-01-19 2:59 UTC (permalink / raw)
To: netdev; +Cc: David Ahern, Hangbin Liu, Antoine Tenart
The previous test added an address with a specified metric and check if
correspond route was created. I somehow added two logs for the same
test. Remove the duplicated one.
Reported-by: Antoine Tenart <atenart@redhat.com>
Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/fib_tests.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
index 84205c3a55eb..2b5707738609 100755
--- a/tools/testing/selftests/net/fib_tests.sh
+++ b/tools/testing/selftests/net/fib_tests.sh
@@ -1055,7 +1055,6 @@ ipv6_addr_metric_test()
check_route6 "2001:db8:104::1 dev dummy2 proto kernel metric 260"
log_test $? 0 "Set metric with peer route on local side"
- log_test $? 0 "User specified metric on local address"
check_route6 "2001:db8:104::2 dev dummy2 proto kernel metric 260"
log_test $? 0 "Set metric with peer route on peer side"
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] selftests/net/fib_tests: remove duplicate log test
2021-01-19 2:59 [PATCH net] selftests/net/fib_tests: remove duplicate log test Hangbin Liu
@ 2021-01-19 3:03 ` David Ahern
2021-01-20 1:07 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2021-01-19 3:03 UTC (permalink / raw)
To: Hangbin Liu, netdev; +Cc: Antoine Tenart
On 1/18/21 7:59 PM, Hangbin Liu wrote:
> The previous test added an address with a specified metric and check if
> correspond route was created. I somehow added two logs for the same
> test. Remove the duplicated one.
>
> Reported-by: Antoine Tenart <atenart@redhat.com>
> Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> tools/testing/selftests/net/fib_tests.sh | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] selftests/net/fib_tests: remove duplicate log test
2021-01-19 3:03 ` David Ahern
@ 2021-01-20 1:07 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-20 1:07 UTC (permalink / raw)
To: David Ahern; +Cc: Hangbin Liu, netdev, Antoine Tenart
On Mon, 18 Jan 2021 20:03:12 -0700 David Ahern wrote:
> On 1/18/21 7:59 PM, Hangbin Liu wrote:
> > The previous test added an address with a specified metric and check if
> > correspond route was created. I somehow added two logs for the same
> > test. Remove the duplicated one.
> >
> > Reported-by: Antoine Tenart <atenart@redhat.com>
> > Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> > ---
> > tools/testing/selftests/net/fib_tests.sh | 1 -
> > 1 file changed, 1 deletion(-)
> >
>
> Reviewed-by: David Ahern <dsahern@kernel.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-20 1:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 2:59 [PATCH net] selftests/net/fib_tests: remove duplicate log test Hangbin Liu
2021-01-19 3:03 ` David Ahern
2021-01-20 1:07 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).