Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

From: Jakub Kicinski <kuba@kernel.org>
To: Giacinto Cifelli <gciofono@gmail.com>
Cc: "Bjørn Mork" <bjorn@mork.no>,
	"Reinhard Speyerer" <rspmn@t-online.de>,
	netdev@vger.kernel.org, rspmn@arcor.de
Subject: Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
Date: Wed, 20 Jan 2021 16:29:01 -0800	[thread overview]
Message-ID: <20210120162901.694388de@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAKSBH7ENRJCbkuq2HviDc-RiH8qh9u+oU5c=uNWoNKofCgs95A@mail.gmail.com>

On Wed, 20 Jan 2021 15:37:59 +0100 Giacinto Cifelli wrote:
> On Wed, Jan 20, 2021 at 2:13 PM Bjørn Mork <bjorn@mork.no> wrote:
> > Giacinto Cifelli <gciofono@gmail.com> writes:
> > > Hi Bjørn,
> > > I have fixed and resent, but from your comment I might not have
> > > selected the right line from maintaner.pl?
> > > what I have is this:
> > > $ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c

I always run it on the patch file formatted by git format-patch.
That way it will also make sure to list people relevant to Fixes 
tags etc.

> > > "Bjørn Mork" <bjorn@mork.no> (maintainer:USB QMI WWAN NETWORK DRIVER)
> > > "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
> > > Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
> > > netdev@vger.kernel.org (open list:USB QMI WWAN NETWORK DRIVER)
> > > <<<< this seems the right one
> > > linux-usb@vger.kernel.org (open list:USB NETWORKING DRIVERS)
> > > linux-kernel@vger.kernel.org (open list)
> > >
> > > I have at the same time sent a patch for another enumeration of the
> > > same product, for cdc_ether.  In that case, I have picked the
> > > following line, which also looked the best fit:
> > >   linux-usb@vger.kernel.org (open list:USB CDC ETHERNET DRIVER)
> > >
> > > Did I misinterpret the results of the script?  
> >
> > Yes, but I'll be the first to admit that it isn't easy.
> >
> > netdev is definitely correct, and the most important one.
> >
> > But in theory you are supposed to use all the listed addresses.  Except
> > that I don't think you need to CC David (and Jakub?) since they probably
> > read everything in netdev anyway.  

That's fair, I've even said in the past that folks can skip CCing me.
That said with vger being flaky lately maybe it's not a bad idea after
all to CC maintainers - in case someone objects to the patch, and we
don't see it because some email deity decided to hold onto the message..

> > And I believe many (most?) people
> > leave out the linux-kernel catch-all, since it doesn't provide any extra
> > coverage for networking. At least I do.

Same, I wish get_maintainers didn't list it :/

> > Then there's the two remaining addresses.  The linux-usb list is
> > traditionally CCed on patches touching USB drivers, since the USB
> > experts are there and not necessarily in netdev.  And I'd like a copy
> > because that's the only way I'll be able to catch these patches.  I
> > don't read any of the lists regularily.
> >
> > This is my interpretation only.  I am sure there are other opinions. But
> > as usual, you cannot do anything wrong. The worst that can ever happen
> > is that you have to resend a patch or miss my review of it ;-)
> >  
> 
> looks like "welcome to the maze" :D
> 
> So, the letter of the instructions would be send all, but up to you to
> leave some of them out.
> Got it.
> I am going to wait a couple of days on the off chance that my patches
> are reviewed, then I will resend.
> 
> Thank you and regards,
> Giacinto