From: Jakub Kicinski <kuba@kernel.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Marc Zyngier <maz@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Brandon Streiff <brandon.streiff@ni.com>,
Olof Johansson <olof@lixom.net>,
Vladimir Oltean <olteanv@gmail.com>,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.
Date: Fri, 22 Jan 2021 18:14:44 -0800 [thread overview]
Message-ID: <20210122181444.66f9417d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210121150802.GB20321@hoboy.vegasvil.org>
On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote:
> On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:
> > > The mvpp2 is an Ethernet driver, and it implements MAC style time
> > > stamping of PTP frames. It has no need of the expensive option to
> > > enable PHY time stamping. Remove the incorrect dependency.
> > >
> > > Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> > > Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")
> >
> > NAK.
>
> Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING?
Russell, I think we all agree now this is not the solution to the
problem of which entity should provide the timestamp, but the series
doesn't seem objectionable in itself.
Please LMK if you think otherwise.
(I would put it in net-next tho, given the above this at most a space
optimization.)
next prev parent reply other threads:[~2021-01-23 2:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 4:05 [PATCH net 0/4] Remove unneeded PHY time stamping option Richard Cochran
2021-01-21 4:06 ` [PATCH net 1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig dependency Richard Cochran
2021-01-21 19:59 ` Brandon Streiff
2021-01-21 4:06 ` [PATCH net 2/4] net: mvpp2: Remove unneeded " Richard Cochran
2021-01-21 10:27 ` Russell King - ARM Linux admin
2021-01-21 15:08 ` Richard Cochran
2021-01-23 2:14 ` Jakub Kicinski [this message]
2021-01-23 9:39 ` Russell King - ARM Linux admin
2021-01-23 13:26 ` Richard Cochran
2021-01-23 20:12 ` Jakub Kicinski
2021-01-23 21:14 ` Richard Cochran
2021-01-23 21:38 ` Jakub Kicinski
2021-01-21 4:06 ` [PATCH net 3/4] ARM: socfpga_defconfig: Disable PHY time stamping by default Richard Cochran
2021-01-21 4:06 ` [PATCH net 4/4] ARM: axm55xx_defconfig: " Richard Cochran
2021-01-21 15:10 ` [PATCH net 0/4] Remove unneeded PHY time stamping option Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122181444.66f9417d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=brandon.streiff@ni.com \
--cc=davem@davemloft.net \
--cc=dinguyen@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).