* [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus
@ 2021-01-28 17:10 Colin King
2021-01-28 18:44 ` Willem de Bruijn
2021-02-08 10:39 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-01-28 17:10 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo, David S . Miller, Jakub Kicinski,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable rtstatu is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c
index 63283d9e7485..aaa004d4d6d0 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c
@@ -1017,7 +1017,7 @@ bool rtl92s_phy_bb_config(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct rtl_phy *rtlphy = &(rtlpriv->phy);
- bool rtstatus = true;
+ bool rtstatus;
u8 pathmap, index, rf_num = 0;
u8 path1, path2;
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus
2021-01-28 17:10 [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus Colin King
@ 2021-01-28 18:44 ` Willem de Bruijn
2021-02-08 10:39 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2021-01-28 18:44 UTC (permalink / raw)
To: Colin King
Cc: Ping-Ke Shih, Kalle Valo, David S . Miller, Jakub Kicinski,
linux-wireless, Network Development, kernel-janitors, LKML
On Thu, Jan 28, 2021 at 12:15 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable rtstatu is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
(for netdrv)
Acked-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus
2021-01-28 17:10 [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus Colin King
2021-01-28 18:44 ` Willem de Bruijn
@ 2021-02-08 10:39 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2021-02-08 10:39 UTC (permalink / raw)
To: Colin King
Cc: Ping-Ke Shih, David S . Miller, Jakub Kicinski, linux-wireless,
netdev, kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable rtstatu is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Willem de Bruijn <willemb@google.com>
Patch applied to wireless-drivers-next.git, thanks.
711fa16f1dfe rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210128171048.644669-1-colin.king@canonical.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-08 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28 17:10 [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus Colin King
2021-01-28 18:44 ` Willem de Bruijn
2021-02-08 10:39 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).