* [net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config
@ 2021-02-09 13:54 Vadim Fedorenko
2021-02-11 19:12 ` Vadim Fedorenko
0 siblings, 1 reply; 3+ messages in thread
From: Vadim Fedorenko @ 2021-02-09 13:54 UTC (permalink / raw)
To: Jakub Kicinski, David Howells, Willem de Bruijn; +Cc: Vadim Fedorenko, netdev
As udp_port_cfg struct changes its members with dependency on IPv6
configuration, the code in rxrpc should also check for IPv6.
Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
---
net/rxrpc/local_object.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c
index 546fd237a649..a4111408ffd0 100644
--- a/net/rxrpc/local_object.c
+++ b/net/rxrpc/local_object.c
@@ -120,9 +120,11 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
if (udp_conf.family == AF_INET) {
udp_conf.local_ip = srx->transport.sin.sin_addr;
udp_conf.local_udp_port = srx->transport.sin.sin_port;
+#if IS_ENABLED(CONFIG_AF_RXRPC_IPV6)
} else {
udp_conf.local_ip6 = srx->transport.sin6.sin6_addr;
udp_conf.local_udp_port = srx->transport.sin6.sin6_port;
+#endif
}
ret = udp_sock_create(net, &udp_conf, &local->socket);
if (ret < 0) {
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config
2021-02-09 13:54 [net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config Vadim Fedorenko
@ 2021-02-11 19:12 ` Vadim Fedorenko
2021-02-12 1:38 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Vadim Fedorenko @ 2021-02-11 19:12 UTC (permalink / raw)
To: Jakub Kicinski, David Howells, Willem de Bruijn; +Cc: netdev
On 09.02.2021 13:54, Vadim Fedorenko wrote:
> As udp_port_cfg struct changes its members with dependency on IPv6
> configuration, the code in rxrpc should also check for IPv6.
Looks like this patch was mistakely tagged as superseded by
dc0e6056decc rxrpc: Fix missing dependency on NET_UDP_TUNNEL
Although both patches have the same Fixes tag, this one fixes
different problem - rxrpc subsystem could not be compiled without
support for IPv6 because the code tries to access ipv6-specific
members of struct udp_port_cfg.
Should I resend it?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config
2021-02-11 19:12 ` Vadim Fedorenko
@ 2021-02-12 1:38 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-02-12 1:38 UTC (permalink / raw)
To: Vadim Fedorenko; +Cc: David Howells, Willem de Bruijn, netdev
On Thu, 11 Feb 2021 19:12:57 +0000 Vadim Fedorenko wrote:
> On 09.02.2021 13:54, Vadim Fedorenko wrote:
> > As udp_port_cfg struct changes its members with dependency on IPv6
> > configuration, the code in rxrpc should also check for IPv6.
>
> Looks like this patch was mistakely tagged as superseded by
> dc0e6056decc rxrpc: Fix missing dependency on NET_UDP_TUNNEL
> Although both patches have the same Fixes tag, this one fixes
> different problem - rxrpc subsystem could not be compiled without
> support for IPv6 because the code tries to access ipv6-specific
> members of struct udp_port_cfg.
It does happen sometimes, it's the patchwork bot marking things as
superseded :(
> Should I resend it?
Yes, that'd probably be easiest for Dave to handle.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-12 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 13:54 [net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config Vadim Fedorenko
2021-02-11 19:12 ` Vadim Fedorenko
2021-02-12 1:38 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).