From: Pavel Machek <pavel@ucw.cz>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Claudiu.Beznea@microchip.com, linux@armlinux.org.uk,
andrew@lunn.ch, davem@davemloft.net, kuba@kernel.org,
rjw@rjwysocki.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] net: phy: micrel: reconfigure the phy on resume
Date: Thu, 11 Feb 2021 13:17:02 +0100 [thread overview]
Message-ID: <20210211121701.GA31708@amd> (raw)
In-Reply-To: <56366231-4a1f-48c3-bc29-6421ed834bdf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]
On Thu 2021-01-14 12:05:21, Heiner Kallweit wrote:
> On 14.01.2021 11:41, Claudiu.Beznea@microchip.com wrote:
> >
> >
> > On 14.01.2021 12:25, Russell King - ARM Linux admin wrote:
> >>
> >> As I've said, if phylib/PHY driver is not restoring the state of the
> >> PHY on resume from suspend-to-ram, then that's an issue with phylib
> >> and/or the phy driver.
> >
> > In the patch I proposed in this thread the restoring is done in PHY driver.
> > Do you think I should continue the investigation and check if something
> > should be done from the phylib itself?
> >
> It was the right move to approach the PM maintainers to clarify whether
> the resume PM callback has to assume that power had been cut off and
> it has to completely reconfigure the device. If they confirm this
> understanding, then:
Power to some devices can be cut during s2ram, yes.
> - the general question remains why there's separate resume and restore
> callbacks, and what restore is supposed to do that resume doesn't
> have to do
You'll often have same implementation, yes.
> - it should be sufficient to use mdio_bus_phy_restore also as resume
> callback (instead of changing each and every PHY driver's resume),
> because we can expect that somebody cutting off power to the PHY
> properly suspends the MDIO bus before
If restore works with power cut and power not cut then yes, you should
get away with that.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-02-11 12:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 15:45 [PATCH] net: phy: micrel: reconfigure the phy on resume Claudiu Beznea
2021-01-08 16:10 ` Andrew Lunn
2021-01-08 16:31 ` Heiner Kallweit
2021-01-13 9:29 ` Claudiu.Beznea
2021-01-13 11:09 ` Heiner Kallweit
2021-01-13 12:36 ` Claudiu.Beznea
2021-01-13 21:34 ` Heiner Kallweit
2021-01-13 22:01 ` Russell King - ARM Linux admin
2021-01-14 7:30 ` Heiner Kallweit
2021-01-14 10:12 ` Claudiu.Beznea
2021-01-14 10:25 ` Russell King - ARM Linux admin
2021-01-14 10:41 ` Claudiu.Beznea
2021-01-14 11:05 ` Heiner Kallweit
2021-02-11 11:18 ` Claudiu.Beznea
2021-02-11 12:17 ` Pavel Machek [this message]
2021-02-11 12:36 ` Heiner Kallweit
2021-02-11 20:34 ` Pavel Machek
2021-01-13 23:28 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211121701.GA31708@amd \
--to=pavel@ucw.cz \
--cc=Claudiu.Beznea@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).