From: Heiner Kallweit <hkallweit1@gmail.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
andrew@lunn.ch, linux@armlinux.org.uk, davem@davemloft.net,
kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: micrel: reconfigure the phy on resume
Date: Fri, 8 Jan 2021 17:31:48 +0100 [thread overview]
Message-ID: <25ec943f-ddfc-9bcd-ef30-d0baf3c6b2a2@gmail.com> (raw)
In-Reply-To: <1610120754-14331-1-git-send-email-claudiu.beznea@microchip.com>
On 08.01.2021 16:45, Claudiu Beznea wrote:
> KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special
> power saving mode (backup mode) that cuts the power for almost all
> parts of the SoC. The rail powering the ethernet PHY is also cut off.
> When resuming, in case the PHY has been configured on probe with
> slew rate or DLL settings these needs to be restored thus call
> driver's config_init() on resume.
>
When would the SoC enter this backup mode? And would it suspend the
MDIO bus before cutting power to the PHY?
I'm asking because in mdio_bus_phy_restore() we call phy_init_hw()
already (that calls the driver's config_init).
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/net/phy/micrel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 3fe552675dd2..52d3a0480158 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1077,7 +1077,7 @@ static int kszphy_resume(struct phy_device *phydev)
> */
> usleep_range(1000, 2000);
>
> - ret = kszphy_config_reset(phydev);
> + ret = phydev->drv->config_init(phydev);
> if (ret)
> return ret;
>
>
next prev parent reply other threads:[~2021-01-08 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 15:45 [PATCH] net: phy: micrel: reconfigure the phy on resume Claudiu Beznea
2021-01-08 16:10 ` Andrew Lunn
2021-01-08 16:31 ` Heiner Kallweit [this message]
2021-01-13 9:29 ` Claudiu.Beznea
2021-01-13 11:09 ` Heiner Kallweit
2021-01-13 12:36 ` Claudiu.Beznea
2021-01-13 21:34 ` Heiner Kallweit
2021-01-13 22:01 ` Russell King - ARM Linux admin
2021-01-14 7:30 ` Heiner Kallweit
2021-01-14 10:12 ` Claudiu.Beznea
2021-01-14 10:25 ` Russell King - ARM Linux admin
2021-01-14 10:41 ` Claudiu.Beznea
2021-01-14 11:05 ` Heiner Kallweit
2021-02-11 11:18 ` Claudiu.Beznea
2021-02-11 12:17 ` Pavel Machek
2021-02-11 12:36 ` Heiner Kallweit
2021-02-11 20:34 ` Pavel Machek
2021-01-13 23:28 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ec943f-ddfc-9bcd-ef30-d0baf3c6b2a2@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).