From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Michael Chan <mchan@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com (open list:BROADCOM
ETHERNET PHY DRIVERS), linux-kernel@vger.kernel.org (open list),
olteanv@gmail.com, michael@walle.cc
Subject: [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling
Date: Fri, 12 Feb 2021 12:57:20 -0800 [thread overview]
Message-ID: <20210212205721.2406849-3-f.fainelli@gmail.com> (raw)
In-Reply-To: <20210212205721.2406849-1-f.fainelli@gmail.com>
When support for optionally disabling the TXC was introduced, bit 2 was
used to do that operation but the datasheet for 50610M from 2009 does
not show bit 2 as being defined. Bit 8 is the one that allows automatic
disabling of the RXC/TXC auto disabling during auto power down.
Fixes: 52fae0837153 ("tg3 / broadcom: Optionally disable TXC if no link")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
include/linux/brcmphy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
index da7bf9dfef5b..3dd8203cf780 100644
--- a/include/linux/brcmphy.h
+++ b/include/linux/brcmphy.h
@@ -193,7 +193,7 @@
#define BCM54XX_SHD_SCR3 0x05
#define BCM54XX_SHD_SCR3_DEF_CLK125 0x0001
#define BCM54XX_SHD_SCR3_DLLAPD_DIS 0x0002
-#define BCM54XX_SHD_SCR3_TRDDAPD 0x0004
+#define BCM54XX_SHD_SCR3_TRDDAPD 0x0100
/* 01010: Auto Power-Down */
#define BCM54XX_SHD_APD 0x0a
--
2.25.1
next prev parent reply other threads:[~2021-02-12 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 20:57 [PATCH net-next 0/3] net: phy: broadcom: APD improvements Florian Fainelli
2021-02-12 20:57 ` [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags Florian Fainelli
2021-02-13 0:56 ` Vladimir Oltean
2021-02-13 1:08 ` Florian Fainelli
2021-02-13 1:14 ` Vladimir Oltean
2021-02-13 1:16 ` Florian Fainelli
2021-02-12 20:57 ` Florian Fainelli [this message]
2021-02-13 1:11 ` [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling Vladimir Oltean
2021-02-13 1:14 ` Florian Fainelli
2021-02-13 3:43 ` Florian Fainelli
2021-02-12 20:57 ` [PATCH net-next 3/3] net: phy: broadcom: Allow BCM54210E to configure APD Florian Fainelli
2021-02-12 21:59 ` [PATCH net-next 0/3] net: phy: broadcom: APD improvements Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212205721.2406849-3-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchan@broadcom.com \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).