netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Michael Chan <mchan@broadcom.com>,
	"open list:BROADCOM ETHERNET PHY DRIVERS" 
	<bcm-kernel-feedback-list@broadcom.com>,
	open list <linux-kernel@vger.kernel.org>,
	olteanv@gmail.com, michael@walle.cc
Subject: Re: [PATCH net-next 0/3] net: phy: broadcom: APD improvements
Date: Fri, 12 Feb 2021 22:59:30 +0100	[thread overview]
Message-ID: <YCb6Qj6+j/Mhp2PA@lunn.ch> (raw)
In-Reply-To: <20210212205721.2406849-1-f.fainelli@gmail.com>

On Fri, Feb 12, 2021 at 12:57:18PM -0800, Florian Fainelli wrote:
> This patch series cleans up the brcmphy.h header and its numerous unused
> phydev->dev_flags, fixes the RXC/TXC clock disabling bit and allows the
> BCM54210E PHY to utilize APD.
> 
> Thanks!

Hi Florian

I don't know the hardware, but the descriptions seem to fit the code,
and i did not spot anything odd.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

      parent reply	other threads:[~2021-02-12 22:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 20:57 [PATCH net-next 0/3] net: phy: broadcom: APD improvements Florian Fainelli
2021-02-12 20:57 ` [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags Florian Fainelli
2021-02-13  0:56   ` Vladimir Oltean
2021-02-13  1:08     ` Florian Fainelli
2021-02-13  1:14       ` Vladimir Oltean
2021-02-13  1:16         ` Florian Fainelli
2021-02-12 20:57 ` [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling Florian Fainelli
2021-02-13  1:11   ` Vladimir Oltean
2021-02-13  1:14     ` Florian Fainelli
2021-02-13  3:43       ` Florian Fainelli
2021-02-12 20:57 ` [PATCH net-next 3/3] net: phy: broadcom: Allow BCM54210E to configure APD Florian Fainelli
2021-02-12 21:59 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCb6Qj6+j/Mhp2PA@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mchan@broadcom.com \
    --cc=michael@walle.cc \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).