* [PATCH net 1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config
@ 2021-03-15 4:33 Ong Boon Leong
2021-03-15 20:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Ong Boon Leong @ 2021-03-15 4:33 UTC (permalink / raw)
To: Russell King, Andrew Lunn, Heiner Kallweit, David S . Miller,
Jakub Kicinski
Cc: netdev, linux-kernel, Ong Boon Leong
if pl->mac_ops->mac_finish() failed, phylink_err should use
"mac_finish" instead of "mac_prepare".
Fixes: b7ad14c2fe2d4 ("net: phylink: re-implement interface configuration with PCS")
Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
---
drivers/net/phy/phylink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 053c92e02cd8..dc2800beacc3 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -476,7 +476,7 @@ static void phylink_major_config(struct phylink *pl, bool restart,
err = pl->mac_ops->mac_finish(pl->config, pl->cur_link_an_mode,
state->interface);
if (err < 0)
- phylink_err(pl, "mac_prepare failed: %pe\n",
+ phylink_err(pl, "mac_finish failed: %pe\n",
ERR_PTR(err));
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net 1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config
2021-03-15 4:33 [PATCH net 1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config Ong Boon Leong
@ 2021-03-15 20:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-15 20:00 UTC (permalink / raw)
To: Ong Boon Leong
Cc: linux, andrew, hkallweit1, davem, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Mon, 15 Mar 2021 12:33:42 +0800 you wrote:
> if pl->mac_ops->mac_finish() failed, phylink_err should use
> "mac_finish" instead of "mac_prepare".
>
> Fixes: b7ad14c2fe2d4 ("net: phylink: re-implement interface configuration with PCS")
> Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
> ---
> drivers/net/phy/phylink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net,1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config
https://git.kernel.org/netdev/net/c/d82c6c1aaccd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-15 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 4:33 [PATCH net 1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config Ong Boon Leong
2021-03-15 20:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).