From: Vadym Kochan <vadym.kochan@plvision.eu>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Taras Chornyi <tchornyi@marvell.com>,
linux-kernel@vger.kernel.org,
Mickey Rachamim <mickeyr@marvell.com>,
Vadym Kochan <vkochan@marvell.com>
Subject: Re: [PATCH net-next 1/3] net: marvell: prestera: bump supported firmware version to 3.0
Date: Wed, 28 Apr 2021 17:54:34 +0300 [thread overview]
Message-ID: <20210428145434.GD9325@plvision.eu> (raw)
In-Reply-To: <YIluzFlPtSRvS/dR@lunn.ch>
On Wed, Apr 28, 2021 at 04:18:52PM +0200, Andrew Lunn wrote:
> > Regarding the distribution issue when the driver version might be released
> > earlier than the firmware, it looks like that the probability of such
> > case is very low because the distributor of the target Linux system will
> > keep track (actually this is how I see it) that driver and firmware
> > versions are aligned.
>
> You really expect Debian, Redhat, openWRT, SuSE to keep a close eye on
> your kernel driver and update their packages at a time you suggest?
>
No, I don't think these distros will keep track it because they are
targeted for wider usages).
But I think that NOS specifc distro (which may be based on top of which
you listed) will do it (sure this is just my assumption).
> I'm also not sure your management port argument is valid. This is an
> enterprise switch, not a TOR. It is probably installed in some broom
> cupboard at a satellite facility. The management port is not likely to
> have its own dedicated link back to the central management
> site. Upgrades are going to be applied over the network, and you have
> a real danger of turning it into a remote brick, needing local access
> to restore it.
>
> I really think you need to support two firmware generations.
>
> Andrew
I am just trying to clarify if it really worth of it because it will
lead to the hairy code and keep structs for previous FW version.
Ofcourse it may have not a big impact if it will be possible to handle
FW differences in prestera_hw.c only.
I really appreciate your comments, just sharing some concerns/doubts
to discuss.
Thanks,
Vadym Kochan
next prev parent reply other threads:[~2021-04-28 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 15:59 [PATCH net-next 0/3] Marvell Prestera Switchdev initial updates for Vadym Kochan
2021-04-23 15:59 ` [PATCH net-next 1/3] net: marvell: prestera: bump supported firmware version to 3.0 Vadym Kochan
2021-04-23 16:49 ` Andrew Lunn
2021-04-23 17:04 ` Vadym Kochan
2021-04-23 18:01 ` Andrew Lunn
2021-04-28 13:47 ` Vadym Kochan
2021-04-28 14:18 ` Andrew Lunn
2021-04-28 14:54 ` Vadym Kochan [this message]
2021-04-28 15:25 ` Andrew Lunn
2021-04-23 15:59 ` [PATCH net-next 2/3] net: marvell: prestera: disable events interrupt while handling Vadym Kochan
2021-04-23 15:59 ` [PATCH net-next 3/3] net: marvell: prestera: align flood setting according to latest firmware version Vadym Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428145434.GD9325@plvision.eu \
--to=vadym.kochan@plvision.eu \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=tchornyi@marvell.com \
--cc=vkochan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).