From: Andrew Lunn <andrew@lunn.ch>
To: Vadym Kochan <vadym.kochan@plvision.eu>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Taras Chornyi <tchornyi@marvell.com>,
linux-kernel@vger.kernel.org,
Mickey Rachamim <mickeyr@marvell.com>,
Vadym Kochan <vkochan@marvell.com>
Subject: Re: [PATCH net-next 1/3] net: marvell: prestera: bump supported firmware version to 3.0
Date: Fri, 23 Apr 2021 18:49:01 +0200 [thread overview]
Message-ID: <YIL6feaar8Y/yOaZ@lunn.ch> (raw)
In-Reply-To: <20210423155933.29787-2-vadym.kochan@plvision.eu>
On Fri, Apr 23, 2021 at 06:59:31PM +0300, Vadym Kochan wrote:
> From: Vadym Kochan <vkochan@marvell.com>
>
> New firmware version has some ABI and feature changes like:
>
> - LAG support
> - initial L3 support
> - changed events handling logic
>
> Signed-off-by: Vadym Kochan <vkochan@marvell.com>
> ---
> drivers/net/ethernet/marvell/prestera/prestera_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> index 298110119272..80fb5daf1da8 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> @@ -13,7 +13,7 @@
>
> #define PRESTERA_MSG_MAX_SIZE 1500
>
> -#define PRESTERA_SUPP_FW_MAJ_VER 2
> +#define PRESTERA_SUPP_FW_MAJ_VER 3
> #define PRESTERA_SUPP_FW_MIN_VER 0
I could be reading the code wrong, but it looks like anybody with
firmware version 2 on their machine and this new driver version
results in the switch not probing? And if the switch does not probe,
do they have any networking to go get the new firmware version?
I think you need to provide some degree of backwards compatibly to
older firmware. Support version 2 and 3. When version 4 comes out,
drop support for version 2 in the driver etc.
Andrew
next prev parent reply other threads:[~2021-04-23 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 15:59 [PATCH net-next 0/3] Marvell Prestera Switchdev initial updates for Vadym Kochan
2021-04-23 15:59 ` [PATCH net-next 1/3] net: marvell: prestera: bump supported firmware version to 3.0 Vadym Kochan
2021-04-23 16:49 ` Andrew Lunn [this message]
2021-04-23 17:04 ` Vadym Kochan
2021-04-23 18:01 ` Andrew Lunn
2021-04-28 13:47 ` Vadym Kochan
2021-04-28 14:18 ` Andrew Lunn
2021-04-28 14:54 ` Vadym Kochan
2021-04-28 15:25 ` Andrew Lunn
2021-04-23 15:59 ` [PATCH net-next 2/3] net: marvell: prestera: disable events interrupt while handling Vadym Kochan
2021-04-23 15:59 ` [PATCH net-next 3/3] net: marvell: prestera: align flood setting according to latest firmware version Vadym Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIL6feaar8Y/yOaZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=tchornyi@marvell.com \
--cc=vadym.kochan@plvision.eu \
--cc=vkochan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).