From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: David Miller <davem@davemloft.net>
Cc: axboe@kernel.dk, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
kernel@pengutronix.de, netdev@vger.kernel.org,
sparclinux@vger.kernel.org, kuba@kernel.org,
jirislaby@kernel.org
Subject: Re: [PATCH] sparc/vio: make remove callback return void
Date: Thu, 6 May 2021 08:11:21 +0200 [thread overview]
Message-ID: <20210506061121.3flqmvm4jok6zj5z@pengutronix.de> (raw)
In-Reply-To: <20210505.132739.2022645880622422332.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
Hi Dave,
On Wed, May 05, 2021 at 01:27:39PM -0700, David Miller wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Date: Wed, 5 May 2021 22:14:49 +0200
>
> > The driver core ignores the return value of struct bus_type::remove()
> > because there is only little that can be done. To simplify the quest to
> > make this function return void, let struct vio_driver::remove() return
> > void, too. All users already unconditionally return 0, this commit makes
> > it obvious that returning an error code is a bad idea and should prevent
> > that future driver authors consider returning an error code.
> >
> > Note there are two nominally different implementations for a vio bus:
> > one in arch/sparc/kernel/vio.c and the other in
> > arch/powerpc/platforms/pseries/vio.c. This patch only addresses the
> > former.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Thanks for your Ack. My expectation was that this patch will go via a
sparc tree. Does your Ack mean that you think it should take a different
path?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-06 6:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 20:14 [PATCH] sparc/vio: make remove callback return void Uwe Kleine-König
2021-05-05 20:27 ` David Miller
2021-05-06 6:11 ` Uwe Kleine-König [this message]
2021-05-14 11:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506061121.3flqmvm4jok6zj5z@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).