netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: David Miller <davem@davemloft.net>,
	axboe@kernel.dk, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org, kernel@pengutronix.de,
	netdev@vger.kernel.org, sparclinux@vger.kernel.org,
	kuba@kernel.org, jirislaby@kernel.org
Subject: Re: [PATCH] sparc/vio: make remove callback return void
Date: Fri, 14 May 2021 13:45:44 +0200	[thread overview]
Message-ID: <YJ5i6F4zHPAR+HCF@kroah.com> (raw)
In-Reply-To: <20210506061121.3flqmvm4jok6zj5z@pengutronix.de>

On Thu, May 06, 2021 at 08:11:21AM +0200, Uwe Kleine-König wrote:
> Hi Dave,
> 
> On Wed, May 05, 2021 at 01:27:39PM -0700, David Miller wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Date: Wed,  5 May 2021 22:14:49 +0200
> > 
> > > The driver core ignores the return value of struct bus_type::remove()
> > > because there is only little that can be done. To simplify the quest to
> > > make this function return void, let struct vio_driver::remove() return
> > > void, too. All users already unconditionally return 0, this commit makes
> > > it obvious that returning an error code is a bad idea and should prevent
> > > that future driver authors consider returning an error code.
> > > 
> > > Note there are two nominally different implementations for a vio bus:
> > > one in arch/sparc/kernel/vio.c and the other in
> > > arch/powerpc/platforms/pseries/vio.c. This patch only addresses the
> > > former.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > Acked-by: David S. Miller <davem@davemloft.net>
> 
> Thanks for your Ack. My expectation was that this patch will go via a
> sparc tree. Does your Ack mean that you think it should take a different
> path?

I'll pick it up, thanks.

greg k-h

      reply	other threads:[~2021-05-14 11:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 20:14 [PATCH] sparc/vio: make remove callback return void Uwe Kleine-König
2021-05-05 20:27 ` David Miller
2021-05-06  6:11   ` Uwe Kleine-König
2021-05-14 11:45     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ5i6F4zHPAR+HCF@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).