* [PATCH intel-net v2 1/6] i40e: add correct exception tracing for XDP
2021-05-10 9:38 [PATCH intel-net v2 0/6] i40e: ice: ixgbe: ixgbevf: igb: igc: add correct exception tracing for XDP Magnus Karlsson
@ 2021-05-10 9:38 ` Magnus Karlsson
2021-05-19 16:12 ` [Intel-wired-lan] " Bhandare, KiranX
2021-05-10 9:38 ` [PATCH intel-net v2 2/6] ice: " Magnus Karlsson
` (4 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Magnus Karlsson @ 2021-05-10 9:38 UTC (permalink / raw)
To: magnus.karlsson, intel-wired-lan, anthony.l.nguyen, maciej.fijalkowski
Cc: netdev, brouer
From: Magnus Karlsson <magnus.karlsson@intel.com>
Add missing exception tracing to XDP when a number of different errors
can occur. The support was only partial. Several errors where not
logged which would confuse the user quite a lot not knowing where and
why the packets disappeared.
Fixes: 74608d17fe29 ("i40e: add support for XDP_TX action")
Fixes: 0a714186d3c0 ("i40e: add AF_XDP zero-copy Rx support")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++++++-
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 8 ++++++--
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index de70c16ef619..b883ab809df3 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -2313,15 +2313,20 @@ static int i40e_run_xdp(struct i40e_ring *rx_ring, struct xdp_buff *xdp)
case XDP_TX:
xdp_ring = rx_ring->vsi->xdp_rings[rx_ring->queue_index];
result = i40e_xmit_xdp_tx_ring(xdp, xdp_ring);
+ if (result == I40E_XDP_CONSUMED)
+ goto out_failure;
break;
case XDP_REDIRECT:
err = xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
- result = !err ? I40E_XDP_REDIR : I40E_XDP_CONSUMED;
+ if (err)
+ goto out_failure;
+ result = I40E_XDP_REDIR;
break;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
fallthrough; /* handle aborts by dropping packet */
case XDP_DROP:
diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 46d884417c63..68f177a86403 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -162,9 +162,10 @@ static int i40e_run_xdp_zc(struct i40e_ring *rx_ring, struct xdp_buff *xdp)
if (likely(act == XDP_REDIRECT)) {
err = xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
- result = !err ? I40E_XDP_REDIR : I40E_XDP_CONSUMED;
+ if (err)
+ goto out_failure;
rcu_read_unlock();
- return result;
+ return I40E_XDP_REDIR;
}
switch (act) {
@@ -173,11 +174,14 @@ static int i40e_run_xdp_zc(struct i40e_ring *rx_ring, struct xdp_buff *xdp)
case XDP_TX:
xdp_ring = rx_ring->vsi->xdp_rings[rx_ring->queue_index];
result = i40e_xmit_xdp_tx_ring(xdp, xdp_ring);
+ if (result == I40E_XDP_CONSUMED)
+ goto out_failure;
break;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
fallthrough; /* handle aborts by dropping packet */
case XDP_DROP:
--
2.29.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* RE: [Intel-wired-lan] [PATCH intel-net v2 1/6] i40e: add correct exception tracing for XDP
2021-05-10 9:38 ` [PATCH intel-net v2 1/6] i40e: " Magnus Karlsson
@ 2021-05-19 16:12 ` Bhandare, KiranX
0 siblings, 0 replies; 14+ messages in thread
From: Bhandare, KiranX @ 2021-05-19 16:12 UTC (permalink / raw)
To: Magnus Karlsson, Karlsson, Magnus, intel-wired-lan, Nguyen,
Anthony L, Fijalkowski, Maciej
Cc: netdev, brouer
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Magnus Karlsson
> Sent: Monday, May 10, 2021 3:09 PM
> To: Karlsson, Magnus <magnus.karlsson@intel.com>; intel-wired-
> lan@lists.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen@intel.com>;
> Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
> Cc: netdev@vger.kernel.org; brouer@redhat.com
> Subject: [Intel-wired-lan] [PATCH intel-net v2 1/6] i40e: add correct exception
> tracing for XDP
>
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Add missing exception tracing to XDP when a number of different errors can
> occur. The support was only partial. Several errors where not logged which
> would confuse the user quite a lot not knowing where and why the packets
> disappeared.
>
> Fixes: 74608d17fe29 ("i40e: add support for XDP_TX action")
> Fixes: 0a714186d3c0 ("i40e: add AF_XDP zero-copy Rx support")
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++++++-
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 8 ++++++--
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com> A Contingent Worker at Intel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH intel-net v2 2/6] ice: add correct exception tracing for XDP
2021-05-10 9:38 [PATCH intel-net v2 0/6] i40e: ice: ixgbe: ixgbevf: igb: igc: add correct exception tracing for XDP Magnus Karlsson
2021-05-10 9:38 ` [PATCH intel-net v2 1/6] i40e: " Magnus Karlsson
@ 2021-05-10 9:38 ` Magnus Karlsson
2021-05-19 16:14 ` [Intel-wired-lan] " Bhandare, KiranX
2021-05-10 9:38 ` [PATCH intel-net v2 3/6] ixgbe: " Magnus Karlsson
` (3 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Magnus Karlsson @ 2021-05-10 9:38 UTC (permalink / raw)
To: magnus.karlsson, intel-wired-lan, anthony.l.nguyen, maciej.fijalkowski
Cc: netdev, brouer
From: Magnus Karlsson <magnus.karlsson@intel.com>
Add missing exception tracing to XDP when a number of different
errors can occur. The support was only partial. Several errors
where not logged which would confuse the user quite a lot not
knowing where and why the packets disappeared.
Fixes: efc2214b6047 ("ice: Add support for XDP")
Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
---
drivers/net/ethernet/intel/ice/ice_txrx.c | 12 +++++++++---
drivers/net/ethernet/intel/ice/ice_xsk.c | 8 ++++++--
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
index e2b4b29ea207..93e5d9ebfd74 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
@@ -523,7 +523,7 @@ ice_run_xdp(struct ice_ring *rx_ring, struct xdp_buff *xdp,
struct bpf_prog *xdp_prog)
{
struct ice_ring *xdp_ring;
- int err;
+ int err, result;
u32 act;
act = bpf_prog_run_xdp(xdp_prog, xdp);
@@ -532,14 +532,20 @@ ice_run_xdp(struct ice_ring *rx_ring, struct xdp_buff *xdp,
return ICE_XDP_PASS;
case XDP_TX:
xdp_ring = rx_ring->vsi->xdp_rings[smp_processor_id()];
- return ice_xmit_xdp_buff(xdp, xdp_ring);
+ result = ice_xmit_xdp_buff(xdp, xdp_ring);
+ if (result == ICE_XDP_CONSUMED)
+ goto out_failure;
+ return result;
case XDP_REDIRECT:
err = xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
- return !err ? ICE_XDP_REDIR : ICE_XDP_CONSUMED;
+ if (err)
+ goto out_failure;
+ return ICE_XDP_REDIR;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
fallthrough;
case XDP_DROP:
diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c
index faa7b8d96adb..7228e4d427bc 100644
--- a/drivers/net/ethernet/intel/ice/ice_xsk.c
+++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
@@ -473,9 +473,10 @@ ice_run_xdp_zc(struct ice_ring *rx_ring, struct xdp_buff *xdp)
if (likely(act == XDP_REDIRECT)) {
err = xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
- result = !err ? ICE_XDP_REDIR : ICE_XDP_CONSUMED;
+ if (err)
+ goto out_failure;
rcu_read_unlock();
- return result;
+ return ICE_XDP_REDIR;
}
switch (act) {
@@ -484,11 +485,14 @@ ice_run_xdp_zc(struct ice_ring *rx_ring, struct xdp_buff *xdp)
case XDP_TX:
xdp_ring = rx_ring->vsi->xdp_rings[rx_ring->q_index];
result = ice_xmit_xdp_buff(xdp, xdp_ring);
+ if (result == ICE_XDP_CONSUMED)
+ goto out_failure;
break;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
fallthrough;
case XDP_DROP:
--
2.29.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* RE: [Intel-wired-lan] [PATCH intel-net v2 2/6] ice: add correct exception tracing for XDP
2021-05-10 9:38 ` [PATCH intel-net v2 2/6] ice: " Magnus Karlsson
@ 2021-05-19 16:14 ` Bhandare, KiranX
0 siblings, 0 replies; 14+ messages in thread
From: Bhandare, KiranX @ 2021-05-19 16:14 UTC (permalink / raw)
To: Magnus Karlsson, Karlsson, Magnus, intel-wired-lan, Nguyen,
Anthony L, Fijalkowski, Maciej
Cc: netdev, brouer
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Magnus Karlsson
> Sent: Monday, May 10, 2021 3:09 PM
> To: Karlsson, Magnus <magnus.karlsson@intel.com>; intel-wired-
> lan@lists.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen@intel.com>;
> Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
> Cc: netdev@vger.kernel.org; brouer@redhat.com
> Subject: [Intel-wired-lan] [PATCH intel-net v2 2/6] ice: add correct exception
> tracing for XDP
>
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Add missing exception tracing to XDP when a number of different errors can
> occur. The support was only partial. Several errors where not logged which
> would confuse the user quite a lot not knowing where and why the packets
> disappeared.
>
> Fixes: efc2214b6047 ("ice: Add support for XDP")
> Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_txrx.c | 12 +++++++++---
> drivers/net/ethernet/intel/ice/ice_xsk.c | 8 ++++++--
> 2 files changed, 15 insertions(+), 5 deletions(-)
>
Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com> A Contingent Worker at Intel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH intel-net v2 3/6] ixgbe: add correct exception tracing for XDP
2021-05-10 9:38 [PATCH intel-net v2 0/6] i40e: ice: ixgbe: ixgbevf: igb: igc: add correct exception tracing for XDP Magnus Karlsson
2021-05-10 9:38 ` [PATCH intel-net v2 1/6] i40e: " Magnus Karlsson
2021-05-10 9:38 ` [PATCH intel-net v2 2/6] ice: " Magnus Karlsson
@ 2021-05-10 9:38 ` Magnus Karlsson
2021-05-28 4:16 ` [Intel-wired-lan] " Jambekar, Vishakha
2021-05-10 9:38 ` [PATCH intel-net v2 4/6] igb: " Magnus Karlsson
` (2 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Magnus Karlsson @ 2021-05-10 9:38 UTC (permalink / raw)
To: magnus.karlsson, intel-wired-lan, anthony.l.nguyen, maciej.fijalkowski
Cc: netdev, brouer
From: Magnus Karlsson <magnus.karlsson@intel.com>
Add missing exception tracing to XDP when a number of different
errors can occur. The support was only partial. Several errors
where not logged which would confuse the user quite a lot not
knowing where and why the packets disappeared.
Fixes: 33fdc82f0883 ("ixgbe: add support for XDP_TX action")
Fixes: d0bcacd0a130 ("ixgbe: add AF_XDP zero-copy Rx support")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++++++++--------
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 14 ++++++++------
2 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index c5ec17d19c59..2ac5b82676f3 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -2213,23 +2213,23 @@ static struct sk_buff *ixgbe_run_xdp(struct ixgbe_adapter *adapter,
break;
case XDP_TX:
xdpf = xdp_convert_buff_to_frame(xdp);
- if (unlikely(!xdpf)) {
- result = IXGBE_XDP_CONSUMED;
- break;
- }
+ if (unlikely(!xdpf))
+ goto out_failure;
result = ixgbe_xmit_xdp_ring(adapter, xdpf);
+ if (result == IXGBE_XDP_CONSUMED)
+ goto out_failure;
break;
case XDP_REDIRECT:
err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog);
- if (!err)
- result = IXGBE_XDP_REDIR;
- else
- result = IXGBE_XDP_CONSUMED;
+ if (err)
+ goto out_failure;
+ result = IXGBE_XDP_REDIR;
break;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
fallthrough; /* handle aborts by dropping packet */
case XDP_DROP:
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
index 91ad5b902673..f72d2978263b 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
@@ -106,9 +106,10 @@ static int ixgbe_run_xdp_zc(struct ixgbe_adapter *adapter,
if (likely(act == XDP_REDIRECT)) {
err = xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
- result = !err ? IXGBE_XDP_REDIR : IXGBE_XDP_CONSUMED;
+ if (err)
+ goto out_failure;
rcu_read_unlock();
- return result;
+ return IXGBE_XDP_REDIR;
}
switch (act) {
@@ -116,16 +117,17 @@ static int ixgbe_run_xdp_zc(struct ixgbe_adapter *adapter,
break;
case XDP_TX:
xdpf = xdp_convert_buff_to_frame(xdp);
- if (unlikely(!xdpf)) {
- result = IXGBE_XDP_CONSUMED;
- break;
- }
+ if (unlikely(!xdpf))
+ goto out_failure;
result = ixgbe_xmit_xdp_ring(adapter, xdpf);
+ if (result == IXGBE_XDP_CONSUMED)
+ goto out_failure;
break;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
fallthrough; /* handle aborts by dropping packet */
case XDP_DROP:
--
2.29.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* RE: [Intel-wired-lan] [PATCH intel-net v2 3/6] ixgbe: add correct exception tracing for XDP
2021-05-10 9:38 ` [PATCH intel-net v2 3/6] ixgbe: " Magnus Karlsson
@ 2021-05-28 4:16 ` Jambekar, Vishakha
0 siblings, 0 replies; 14+ messages in thread
From: Jambekar, Vishakha @ 2021-05-28 4:16 UTC (permalink / raw)
To: Magnus Karlsson, Karlsson, Magnus, intel-wired-lan, Nguyen,
Anthony L, Fijalkowski, Maciej
Cc: netdev, brouer
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Magnus Karlsson
> Sent: Monday, May 10, 2021 3:09 PM
> To: Karlsson, Magnus <magnus.karlsson@intel.com>; intel-wired-
> lan@lists.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen@intel.com>;
> Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
> Cc: netdev@vger.kernel.org; brouer@redhat.com
> Subject: [Intel-wired-lan] [PATCH intel-net v2 3/6] ixgbe: add correct
> exception tracing for XDP
>
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Add missing exception tracing to XDP when a number of different errors can
> occur. The support was only partial. Several errors where not logged which
> would confuse the user quite a lot not knowing where and why the packets
> disappeared.
>
> Fixes: 33fdc82f0883 ("ixgbe: add support for XDP_TX action")
> Fixes: d0bcacd0a130 ("ixgbe: add AF_XDP zero-copy Rx support")
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++++++++--------
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 14 ++++++++------
> 2 files changed, 16 insertions(+), 14 deletions(-)
>
Tested-by: Vishakha Jambekar<vishakha.jambekar@intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH intel-net v2 4/6] igb: add correct exception tracing for XDP
2021-05-10 9:38 [PATCH intel-net v2 0/6] i40e: ice: ixgbe: ixgbevf: igb: igc: add correct exception tracing for XDP Magnus Karlsson
` (2 preceding siblings ...)
2021-05-10 9:38 ` [PATCH intel-net v2 3/6] ixgbe: " Magnus Karlsson
@ 2021-05-10 9:38 ` Magnus Karlsson
2021-05-21 11:44 ` [Intel-wired-lan] " Jambekar, Vishakha
2021-05-10 9:38 ` [PATCH intel-net v2 5/6] ixgbevf: " Magnus Karlsson
2021-05-10 9:38 ` [PATCH intel-net v2 6/6] igc: " Magnus Karlsson
5 siblings, 1 reply; 14+ messages in thread
From: Magnus Karlsson @ 2021-05-10 9:38 UTC (permalink / raw)
To: magnus.karlsson, intel-wired-lan, anthony.l.nguyen, maciej.fijalkowski
Cc: netdev, brouer
From: Magnus Karlsson <magnus.karlsson@intel.com>
Add missing exception tracing to XDP when a number of different
errors can occur. The support was only partial. Several errors
where not logged which would confuse the user quite a lot not
knowing where and why the packets disappeared.
Fixes: 9cbc948b5a20 ("igb: add XDP support")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 038a9fd1af44..004a5b15fadb 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -8401,18 +8401,20 @@ static struct sk_buff *igb_run_xdp(struct igb_adapter *adapter,
break;
case XDP_TX:
result = igb_xdp_xmit_back(adapter, xdp);
+ if (result == IGB_XDP_CONSUMED)
+ goto out_failure;
break;
case XDP_REDIRECT:
err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog);
- if (!err)
- result = IGB_XDP_REDIR;
- else
- result = IGB_XDP_CONSUMED;
+ if (err)
+ goto out_failure;
+ result = IGB_XDP_REDIR;
break;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
fallthrough;
case XDP_DROP:
--
2.29.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* RE: [Intel-wired-lan] [PATCH intel-net v2 4/6] igb: add correct exception tracing for XDP
2021-05-10 9:38 ` [PATCH intel-net v2 4/6] igb: " Magnus Karlsson
@ 2021-05-21 11:44 ` Jambekar, Vishakha
0 siblings, 0 replies; 14+ messages in thread
From: Jambekar, Vishakha @ 2021-05-21 11:44 UTC (permalink / raw)
To: Magnus Karlsson, Karlsson, Magnus, intel-wired-lan, Nguyen,
Anthony L, Fijalkowski, Maciej
Cc: netdev, brouer
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Magnus Karlsson
> Sent: Monday, May 10, 2021 3:09 PM
> To: Karlsson, Magnus <magnus.karlsson@intel.com>; intel-wired-
> lan@lists.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen@intel.com>;
> Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
> Cc: netdev@vger.kernel.org; brouer@redhat.com
> Subject: [Intel-wired-lan] [PATCH intel-net v2 4/6] igb: add correct exception
> tracing for XDP
>
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Add missing exception tracing to XDP when a number of different errors can
> occur. The support was only partial. Several errors where not logged which
> would confuse the user quite a lot not knowing where and why the packets
> disappeared.
>
> Fixes: 9cbc948b5a20 ("igb: add XDP support")
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
Tested-by: Vishakha Jambekar<vishakha.jambekar@intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH intel-net v2 5/6] ixgbevf: add correct exception tracing for XDP
2021-05-10 9:38 [PATCH intel-net v2 0/6] i40e: ice: ixgbe: ixgbevf: igb: igc: add correct exception tracing for XDP Magnus Karlsson
` (3 preceding siblings ...)
2021-05-10 9:38 ` [PATCH intel-net v2 4/6] igb: " Magnus Karlsson
@ 2021-05-10 9:38 ` Magnus Karlsson
2021-05-21 11:42 ` [Intel-wired-lan] " Jambekar, Vishakha
2021-05-10 9:38 ` [PATCH intel-net v2 6/6] igc: " Magnus Karlsson
5 siblings, 1 reply; 14+ messages in thread
From: Magnus Karlsson @ 2021-05-10 9:38 UTC (permalink / raw)
To: magnus.karlsson, intel-wired-lan, anthony.l.nguyen, maciej.fijalkowski
Cc: netdev, brouer
From: Magnus Karlsson <magnus.karlsson@intel.com>
Add missing exception tracing to XDP when a number of different
errors can occur. The support was only partial. Several errors
where not logged which would confuse the user quite a lot not
knowing where and why the packets disappeared.
Fixes: 21092e9ce8b1 ("ixgbevf: Add support for XDP_TX action")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index ba2ed8a43d2d..0e733cc15c58 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -1067,11 +1067,14 @@ static struct sk_buff *ixgbevf_run_xdp(struct ixgbevf_adapter *adapter,
case XDP_TX:
xdp_ring = adapter->xdp_ring[rx_ring->queue_index];
result = ixgbevf_xmit_xdp_ring(xdp_ring, xdp);
+ if (result == IXGBEVF_XDP_CONSUMED)
+ goto out_failure;
break;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
fallthrough; /* handle aborts by dropping packet */
case XDP_DROP:
--
2.29.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* RE: [Intel-wired-lan] [PATCH intel-net v2 5/6] ixgbevf: add correct exception tracing for XDP
2021-05-10 9:38 ` [PATCH intel-net v2 5/6] ixgbevf: " Magnus Karlsson
@ 2021-05-21 11:42 ` Jambekar, Vishakha
0 siblings, 0 replies; 14+ messages in thread
From: Jambekar, Vishakha @ 2021-05-21 11:42 UTC (permalink / raw)
To: Magnus Karlsson, Karlsson, Magnus, intel-wired-lan, Nguyen,
Anthony L, Fijalkowski, Maciej
Cc: netdev, brouer
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Magnus Karlsson
> Sent: Monday, May 10, 2021 3:09 PM
> To: Karlsson, Magnus <magnus.karlsson@intel.com>; intel-wired-
> lan@lists.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen@intel.com>;
> Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
> Cc: netdev@vger.kernel.org; brouer@redhat.com
> Subject: [Intel-wired-lan] [PATCH intel-net v2 5/6] ixgbevf: add correct
> exception tracing for XDP
>
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Add missing exception tracing to XDP when a number of different errors can
> occur. The support was only partial. Several errors where not logged which
> would confuse the user quite a lot not knowing where and why the packets
> disappeared.
>
> Fixes: 21092e9ce8b1 ("ixgbevf: Add support for XDP_TX action")
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Tested-by: Vishakha Jambekar<vishakha.jambekar@intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH intel-net v2 6/6] igc: add correct exception tracing for XDP
2021-05-10 9:38 [PATCH intel-net v2 0/6] i40e: ice: ixgbe: ixgbevf: igb: igc: add correct exception tracing for XDP Magnus Karlsson
` (4 preceding siblings ...)
2021-05-10 9:38 ` [PATCH intel-net v2 5/6] ixgbevf: " Magnus Karlsson
@ 2021-05-10 9:38 ` Magnus Karlsson
2021-05-24 10:05 ` [Intel-wired-lan] " Dvora Fuxbrumer
2021-05-24 10:08 ` Dvora Fuxbrumer
5 siblings, 2 replies; 14+ messages in thread
From: Magnus Karlsson @ 2021-05-10 9:38 UTC (permalink / raw)
To: magnus.karlsson, intel-wired-lan, anthony.l.nguyen, maciej.fijalkowski
Cc: netdev, brouer
From: Magnus Karlsson <magnus.karlsson@intel.com>
Add missing exception tracing to XDP when a number of different
errors can occur. The support was only partial. Several errors
where not logged which would confuse the user quite a lot not
knowing where and why the packets disappeared.
Fixes: 73f1071c1d29 ("igc: Add support for XDP_TX action")
Fixes: 4ff320361092 ("igc: Add support for XDP_REDIRECT action")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 069471b7ffb0..f1adf154ec4a 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -2047,20 +2047,19 @@ static struct sk_buff *igc_xdp_run_prog(struct igc_adapter *adapter,
break;
case XDP_TX:
if (igc_xdp_xmit_back(adapter, xdp) < 0)
- res = IGC_XDP_CONSUMED;
- else
- res = IGC_XDP_TX;
+ goto out_failure;
+ res = IGC_XDP_TX;
break;
case XDP_REDIRECT:
if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0)
- res = IGC_XDP_CONSUMED;
- else
- res = IGC_XDP_REDIRECT;
+ goto out_failure;
+ res = IGC_XDP_REDIRECT;
break;
default:
bpf_warn_invalid_xdp_action(act);
fallthrough;
case XDP_ABORTED:
+out_failure:
trace_xdp_exception(adapter->netdev, prog, act);
fallthrough;
case XDP_DROP:
--
2.29.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [Intel-wired-lan] [PATCH intel-net v2 6/6] igc: add correct exception tracing for XDP
2021-05-10 9:38 ` [PATCH intel-net v2 6/6] igc: " Magnus Karlsson
@ 2021-05-24 10:05 ` Dvora Fuxbrumer
2021-05-24 10:08 ` Dvora Fuxbrumer
1 sibling, 0 replies; 14+ messages in thread
From: Dvora Fuxbrumer @ 2021-05-24 10:05 UTC (permalink / raw)
To: Magnus Karlsson, magnus.karlsson, intel-wired-lan,
anthony.l.nguyen, maciej.fijalkowski
Cc: netdev, brouer
On 10/05/2021 12:38, Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Add missing exception tracing to XDP when a number of different
> errors can occur. The support was only partial. Several errors
> where not logged which would confuse the user quite a lot not
> knowing where and why the packets disappeared.
>
> Fixes: 73f1071c1d29 ("igc: Add support for XDP_TX action")
> Fixes: 4ff320361092 ("igc: Add support for XDP_REDIRECT action")
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
> Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Intel-wired-lan] [PATCH intel-net v2 6/6] igc: add correct exception tracing for XDP
2021-05-10 9:38 ` [PATCH intel-net v2 6/6] igc: " Magnus Karlsson
2021-05-24 10:05 ` [Intel-wired-lan] " Dvora Fuxbrumer
@ 2021-05-24 10:08 ` Dvora Fuxbrumer
1 sibling, 0 replies; 14+ messages in thread
From: Dvora Fuxbrumer @ 2021-05-24 10:08 UTC (permalink / raw)
To: Magnus Karlsson, magnus.karlsson, intel-wired-lan,
anthony.l.nguyen, maciej.fijalkowski
Cc: netdev, brouer
On 10/05/2021 12:38, Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Add missing exception tracing to XDP when a number of different
> errors can occur. The support was only partial. Several errors
> where not logged which would confuse the user quite a lot not
> knowing where and why the packets disappeared.
>
> Fixes: 73f1071c1d29 ("igc: Add support for XDP_TX action")
> Fixes: 4ff320361092 ("igc: Add support for XDP_REDIRECT action")
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread