* [PATCH][next] net: hns3: Fix return of uninitialized variable ret
@ 2021-05-21 10:01 Colin King
2021-05-21 21:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-05-21 10:01 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, David S . Miller, Jakub Kicinski,
Huazhong Tan, Hao Chen, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
In the unlikely event that rule_cnt is zero the variable ret is
not assigned a value and function hclge_dbg_dump_fd_tcam can end
up returning an unitialized value in ret. Fix this by explicitly
setting ret to zero before the for-loop.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: b5a0b70d77b9 ("net: hns3: refactor dump fd tcam of debugfs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
index dd9eb6e6f5a7..0b7c6838d905 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
@@ -1519,6 +1519,7 @@ static int hclge_dbg_dump_fd_tcam(struct hclge_dev *hdev, char *buf, int len)
goto out;
}
+ ret = 0;
for (i = 0; i < rule_cnt; i++) {
tcam_msg.stage = HCLGE_FD_STAGE_1;
tcam_msg.loc = rule_locs[i];
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] net: hns3: Fix return of uninitialized variable ret
2021-05-21 10:01 [PATCH][next] net: hns3: Fix return of uninitialized variable ret Colin King
@ 2021-05-21 21:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-21 21:00 UTC (permalink / raw)
To: Colin King
Cc: yisen.zhuang, salil.mehta, davem, kuba, tanhuazhong, chenhao288,
netdev, kernel-janitors, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 21 May 2021 11:01:46 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the unlikely event that rule_cnt is zero the variable ret is
> not assigned a value and function hclge_dbg_dump_fd_tcam can end
> up returning an unitialized value in ret. Fix this by explicitly
> setting ret to zero before the for-loop.
>
> [...]
Here is the summary with links:
- [next] net: hns3: Fix return of uninitialized variable ret
https://git.kernel.org/netdev/net-next/c/030c8198d744
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-21 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 10:01 [PATCH][next] net: hns3: Fix return of uninitialized variable ret Colin King
2021-05-21 21:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).