[PATCH RESEND 0/2] Add GMAC_AHB_RESET to ipq8064 ethernet resets

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH RESEND 0/2] Add GMAC_AHB_RESET to ipq8064 ethernet resets
@ 2021-06-09 23:09 Matthew Hagan
  2021-06-09 23:09 ` [PATCH RESEND 1/2] ARM: dts: qcom: add ahb reset to ipq806x-gmac Matthew Hagan
  2021-06-09 23:09 ` [PATCH RESEND 2/2] dt-bindings: net: stmmac: add ahb reset to example Matthew Hagan
  0 siblings, 2 replies; 4+ messages in thread
From: Matthew Hagan @ 2021-06-09 23:09 UTC (permalink / raw)
  Cc: Philipp Zabel, Matthew Hagan, David S. Miller, Jakub Kicinski,
	Rob Herring, Andy Gross, Bjorn Andersson, netdev, devicetree,
	linux-kernel, linux-arm-msm

These two additional patches were dropped at v2, v3 by error and
should have been included with "net: stmmac: explicitly deassert
GMAC_AHB_RESET". These add GMAC_AHB_RESET to the ipq8064 ethernet
reset definitions and documentation.

Apologies for the oversight.

Matthew Hagan (2):
  ARM: dts: qcom: add ahb reset to ipq806x-gmac
  dt-bindings: net: stmmac: add ahb reset to example

 .../devicetree/bindings/net/ipq806x-dwmac.txt |  5 +++--
 arch/arm/boot/dts/qcom-ipq8064.dtsi           | 20 +++++++++++--------
 2 files changed, 15 insertions(+), 10 deletions(-)

-- 
2.26.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH RESEND 1/2] ARM: dts: qcom: add ahb reset to ipq806x-gmac
  2021-06-09 23:09 [PATCH RESEND 0/2] Add GMAC_AHB_RESET to ipq8064 ethernet resets Matthew Hagan
@ 2021-06-09 23:09 ` Matthew Hagan
  2021-06-09 23:09 ` [PATCH RESEND 2/2] dt-bindings: net: stmmac: add ahb reset to example Matthew Hagan
  1 sibling, 0 replies; 4+ messages in thread
From: Matthew Hagan @ 2021-06-09 23:09 UTC (permalink / raw)
  Cc: Philipp Zabel, Matthew Hagan, David S. Miller, Jakub Kicinski,
	Rob Herring, Andy Gross, Bjorn Andersson, netdev, devicetree,
	linux-kernel, linux-arm-msm

Add GMAC_AHB_RESET to the resets property of each GMAC node.

Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
---
 arch/arm/boot/dts/qcom-ipq8064.dtsi | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 98995ead4413..1dbceaf3454b 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
@@ -643,8 +643,9 @@ gmac0: ethernet@37000000 {
 			clocks = <&gcc GMAC_CORE1_CLK>;
 			clock-names = "stmmaceth";
 
-			resets = <&gcc GMAC_CORE1_RESET>;
-			reset-names = "stmmaceth";
+			resets = <&gcc GMAC_CORE1_RESET>,
+				 <&gcc GMAC_AHB_RESET>;
+			reset-names = "stmmaceth", "ahb";
 
 			status = "disabled";
 		};
@@ -666,8 +667,9 @@ gmac1: ethernet@37200000 {
 			clocks = <&gcc GMAC_CORE2_CLK>;
 			clock-names = "stmmaceth";
 
-			resets = <&gcc GMAC_CORE2_RESET>;
-			reset-names = "stmmaceth";
+			resets = <&gcc GMAC_CORE2_RESET>,
+				 <&gcc GMAC_AHB_RESET>;
+			reset-names = "stmmaceth", "ahb";
 
 			status = "disabled";
 		};
@@ -689,8 +691,9 @@ gmac2: ethernet@37400000 {
 			clocks = <&gcc GMAC_CORE3_CLK>;
 			clock-names = "stmmaceth";
 
-			resets = <&gcc GMAC_CORE3_RESET>;
-			reset-names = "stmmaceth";
+			resets = <&gcc GMAC_CORE3_RESET>,
+				 <&gcc GMAC_AHB_RESET>;
+			reset-names = "stmmaceth", "ahb";
 
 			status = "disabled";
 		};
@@ -712,8 +715,9 @@ gmac3: ethernet@37600000 {
 			clocks = <&gcc GMAC_CORE4_CLK>;
 			clock-names = "stmmaceth";
 
-			resets = <&gcc GMAC_CORE4_RESET>;
-			reset-names = "stmmaceth";
+			resets = <&gcc GMAC_CORE4_RESET>,
+				 <&gcc GMAC_AHB_RESET>;
+			reset-names = "stmmaceth", "ahb";
 
 			status = "disabled";
 		};
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH RESEND 2/2] dt-bindings: net: stmmac: add ahb reset to example
  2021-06-09 23:09 [PATCH RESEND 0/2] Add GMAC_AHB_RESET to ipq8064 ethernet resets Matthew Hagan
  2021-06-09 23:09 ` [PATCH RESEND 1/2] ARM: dts: qcom: add ahb reset to ipq806x-gmac Matthew Hagan
@ 2021-06-09 23:09 ` Matthew Hagan
  2021-06-18 21:18   ` Rob Herring
  1 sibling, 1 reply; 4+ messages in thread
From: Matthew Hagan @ 2021-06-09 23:09 UTC (permalink / raw)
  Cc: Philipp Zabel, Matthew Hagan, David S. Miller, Jakub Kicinski,
	Rob Herring, Andy Gross, Bjorn Andersson, netdev, devicetree,
	linux-kernel, linux-arm-msm

Add ahb reset to the reset properties within the example GMAC node.

Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
---
 Documentation/devicetree/bindings/net/ipq806x-dwmac.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/ipq806x-dwmac.txt b/Documentation/devicetree/bindings/net/ipq806x-dwmac.txt
index 6d7ab4e524d4..ef5fd9f0b156 100644
--- a/Documentation/devicetree/bindings/net/ipq806x-dwmac.txt
+++ b/Documentation/devicetree/bindings/net/ipq806x-dwmac.txt
@@ -30,6 +30,7 @@ Example:
 		clocks = <&gcc GMAC_CORE1_CLK>;
 		clock-names = "stmmaceth";
 
-		resets = <&gcc GMAC_CORE1_RESET>;
-		reset-names = "stmmaceth";
+		resets = <&gcc GMAC_CORE1_RESET>,
+			 <&gcc GMAC_AHB_RESET>;
+		reset-names = "stmmaceth", "ahb";
 	};
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH RESEND 2/2] dt-bindings: net: stmmac: add ahb reset to example
  2021-06-09 23:09 ` [PATCH RESEND 2/2] dt-bindings: net: stmmac: add ahb reset to example Matthew Hagan
@ 2021-06-18 21:18   ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-06-18 21:18 UTC (permalink / raw)
  To: Matthew Hagan
  Cc: David S. Miller, devicetree, linux-arm-msm, netdev, Andy Gross,
	linux-kernel, Jakub Kicinski, Bjorn Andersson, Rob Herring,
	Philipp Zabel

On Thu, 10 Jun 2021 00:09:45 +0100, Matthew Hagan wrote:
> Add ahb reset to the reset properties within the example GMAC node.
> 
> Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/ipq806x-dwmac.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-18 21:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 23:09 [PATCH RESEND 0/2] Add GMAC_AHB_RESET to ipq8064 ethernet resets Matthew Hagan
2021-06-09 23:09 ` [PATCH RESEND 1/2] ARM: dts: qcom: add ahb reset to ipq806x-gmac Matthew Hagan
2021-06-09 23:09 ` [PATCH RESEND 2/2] dt-bindings: net: stmmac: add ahb reset to example Matthew Hagan
2021-06-18 21:18   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).