* [PATCH] cxgb4: fix wrong shift.
@ 2021-06-15 9:56 Pavel Machek
2021-06-15 10:17 ` Greg KH
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Pavel Machek @ 2021-06-15 9:56 UTC (permalink / raw)
To: kernel list, Colin Ian King, David S. Miller, Raju Rangoju,
Jakub Kicinski, netdev
Cc: stable
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
value. Fix that.
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 22c9ac922eba..6260b3bebd2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
WORD_MASK, f->fs.nat_lip[3] |
f->fs.nat_lip[2] << 8 |
f->fs.nat_lip[1] << 16 |
- (u64)f->fs.nat_lip[0] << 25, 1);
+ (u64)f->fs.nat_lip[0] << 24, 1);
}
}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] cxgb4: fix wrong shift.
2021-06-15 9:56 [PATCH] cxgb4: fix wrong shift Pavel Machek
@ 2021-06-15 10:17 ` Greg KH
2021-06-15 18:22 ` David Miller
2021-06-18 9:29 ` [PATCHv2] " Pavel Machek
2 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-06-15 10:17 UTC (permalink / raw)
To: Pavel Machek
Cc: kernel list, Colin Ian King, David S. Miller, Raju Rangoju,
Jakub Kicinski, netdev, stable
On Tue, Jun 15, 2021 at 11:56:51AM +0200, Pavel Machek wrote:
> While fixing coverity warning, commit
> dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
> value. Fix that.
>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> index 22c9ac922eba..6260b3bebd2b 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> @@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
> WORD_MASK, f->fs.nat_lip[3] |
> f->fs.nat_lip[2] << 8 |
> f->fs.nat_lip[1] << 16 |
> - (u64)f->fs.nat_lip[0] << 25, 1);
> + (u64)f->fs.nat_lip[0] << 24, 1);
> }
> }
>
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] cxgb4: fix wrong shift.
2021-06-15 9:56 [PATCH] cxgb4: fix wrong shift Pavel Machek
2021-06-15 10:17 ` Greg KH
@ 2021-06-15 18:22 ` David Miller
2021-06-18 9:30 ` Pavel Machek
2021-06-18 9:29 ` [PATCHv2] " Pavel Machek
2 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2021-06-15 18:22 UTC (permalink / raw)
To: pavel; +Cc: linux-kernel, colin.king, rajur, kuba, netdev, stable
From: Pavel Machek <pavel@denx.de>
Date: Tue, 15 Jun 2021 11:56:51 +0200
> While fixing coverity warning, commit
> dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
> value. Fix that.
>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
Please repost with an appropriate Fixes: tag, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cxgb4: fix wrong shift.
2021-06-15 18:22 ` David Miller
@ 2021-06-18 9:30 ` Pavel Machek
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2021-06-18 9:30 UTC (permalink / raw)
To: David Miller; +Cc: pavel, linux-kernel, colin.king, rajur, kuba, netdev, stable
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
On Tue 2021-06-15 11:22:42, David Miller wrote:
> From: Pavel Machek <pavel@denx.de>
> Date: Tue, 15 Jun 2021 11:56:51 +0200
>
> > While fixing coverity warning, commit
> > dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
> > value. Fix that.
> >
> > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
>
> Please repost with an appropriate Fixes: tag, thank you.
Done, you should have PATCHv2 in your inbox.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCHv2] cxgb4: fix wrong shift.
2021-06-15 9:56 [PATCH] cxgb4: fix wrong shift Pavel Machek
2021-06-15 10:17 ` Greg KH
2021-06-15 18:22 ` David Miller
@ 2021-06-18 9:29 ` Pavel Machek
2021-06-18 19:00 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 6+ messages in thread
From: Pavel Machek @ 2021-06-18 9:29 UTC (permalink / raw)
To: David S. Miller
Cc: kernel list, Colin Ian King, Raju Rangoju, Jakub Kicinski,
netdev, stable
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
While fixing coverity warning, commit dd2c79677375 introduced typo in
shift value. Fix that.
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
Fixes: dd2c79677375 ("cxgb4: Fix unintentional sign extension issues")
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 22c9ac922eba..6260b3bebd2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
WORD_MASK, f->fs.nat_lip[3] |
f->fs.nat_lip[2] << 8 |
f->fs.nat_lip[1] << 16 |
- (u64)f->fs.nat_lip[0] << 25, 1);
+ (u64)f->fs.nat_lip[0] << 24, 1);
}
}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCHv2] cxgb4: fix wrong shift.
2021-06-18 9:29 ` [PATCHv2] " Pavel Machek
@ 2021-06-18 19:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-18 19:00 UTC (permalink / raw)
To: Pavel Machek; +Cc: davem, linux-kernel, colin.king, rajur, kuba, netdev, stable
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 18 Jun 2021 11:29:48 +0200 you wrote:
> While fixing coverity warning, commit dd2c79677375 introduced typo in
> shift value. Fix that.
>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> Fixes: dd2c79677375 ("cxgb4: Fix unintentional sign extension issues")
Here is the summary with links:
- [PATCHv2] cxgb4: fix wrong shift.
https://git.kernel.org/netdev/net/c/39eb028183bc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-18 19:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 9:56 [PATCH] cxgb4: fix wrong shift Pavel Machek
2021-06-15 10:17 ` Greg KH
2021-06-15 18:22 ` David Miller
2021-06-18 9:30 ` Pavel Machek
2021-06-18 9:29 ` [PATCHv2] " Pavel Machek
2021-06-18 19:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).