[PATCH net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features

[PATCH net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features

[Jakub Kicinski]

Currently UDP tunnel devices on top of VLANs lose the ability
to offload UDP GSO. Widen the pass thru features from TSO
to all GSO_SOFTWARE.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 net/8021q/vlan.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/8021q/vlan.h b/net/8021q/vlan.h
index fa3ad3d4d58c..edb6acde6b6f 100644
--- a/net/8021q/vlan.h
+++ b/net/8021q/vlan.h
@@ -108,7 +108,8 @@ static inline netdev_features_t vlan_tnl_features(struct net_device *real_dev)
 	netdev_features_t ret;
 
 	ret = real_dev->hw_enc_features &
-	      (NETIF_F_CSUM_MASK | NETIF_F_ALL_TSO | NETIF_F_GSO_ENCAP_ALL);
+	      (NETIF_F_CSUM_MASK | NETIF_F_GSO_SOFTWARE |
+	       NETIF_F_GSO_ENCAP_ALL);
 
 	if ((ret & NETIF_F_GSO_ENCAP_ALL) && (ret & NETIF_F_CSUM_MASK))
 		return (ret & ~NETIF_F_CSUM_MASK) | NETIF_F_HW_CSUM;
-- 
2.31.1

Re: [PATCH net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features

[Willem de Bruijn]

On Fri, Jun 18, 2021 at 12:56 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Currently UDP tunnel devices on top of VLANs lose the ability
> to offload UDP GSO. Widen the pass thru features from TSO
> to all GSO_SOFTWARE.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Willem de Bruijn <willemb@google.com>

Re: [PATCH net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 17 Jun 2021 21:55:56 -0700 you wrote:
> Currently UDP tunnel devices on top of VLANs lose the ability
> to offload UDP GSO. Widen the pass thru features from TSO
> to all GSO_SOFTWARE.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  net/8021q/vlan.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features
    https://git.kernel.org/netdev/net-next/c/9d72b8da9f13

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html