* [PATCH] ptp: Relocate lookup cookie to correct block.
@ 2021-07-07 0:27 Jonathan Lemon
2021-07-07 14:16 ` Richard Cochran
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Lemon @ 2021-07-07 0:27 UTC (permalink / raw)
To: davem, richardcochran, olteanv; +Cc: netdev, kernel-team
An earlier commit set the pps_lookup cookie, but the line
was somehow added to the wrong code block. Correct this.
Fixes: 8602e40fc813 ("ptp: Set lookup cookie when creating a PTP PPS source.")
Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
drivers/ptp/ptp_clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index a23a37a4d5dc..7e01f7359081 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -218,7 +218,6 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
pr_err("failed to create ptp aux_worker %d\n", err);
goto kworker_err;
}
- ptp->pps_source->lookup_cookie = ptp;
}
err = ptp_populate_pin_groups(ptp);
@@ -238,6 +237,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
pr_err("failed to register pps source\n");
goto no_pps;
}
+ ptp->pps_source->lookup_cookie = ptp;
}
/* Initialize a new device of our class in our clock structure. */
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ptp: Relocate lookup cookie to correct block.
2021-07-07 0:27 [PATCH] ptp: Relocate lookup cookie to correct block Jonathan Lemon
@ 2021-07-07 14:16 ` Richard Cochran
0 siblings, 0 replies; 2+ messages in thread
From: Richard Cochran @ 2021-07-07 14:16 UTC (permalink / raw)
To: Jonathan Lemon; +Cc: davem, olteanv, netdev, kernel-team
On Tue, Jul 06, 2021 at 05:27:12PM -0700, Jonathan Lemon wrote:
> An earlier commit set the pps_lookup cookie, but the line
> was somehow added to the wrong code block. Correct this.
>
> Fixes: 8602e40fc813 ("ptp: Set lookup cookie when creating a PTP PPS source.")
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-07 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 0:27 [PATCH] ptp: Relocate lookup cookie to correct block Jonathan Lemon
2021-07-07 14:16 ` Richard Cochran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).