From: Vladimir Oltean <olteanv@gmail.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: dsa: tag_ksz: dont let the hardware process the layer 4 checksum
Date: Mon, 19 Jul 2021 11:24:20 +0300 [thread overview]
Message-ID: <20210719082420.d7qid2hld26v6kdb@skbuf> (raw)
In-Reply-To: <trinity-e0322d42-d4ca-43a6-96d6-cfe89112ad9e-1626682813094@3c-app-gmx-bap33>
On Mon, Jul 19, 2021 at 10:20:13AM +0200, Lino Sanfilippo wrote:
> Should I then resend the series with patch 1 handling the NETIF_F_SG and
> NETIF_F_FRAGLIST flags (i.e. deleting them if tailroom is needed) in
> dsa_slave_setup_tagger() as you suggested and patch 2 as it is?
Yup. The TX checksum offload flag on DSA interfaces is definitely
net-next material if we want to do it properly, so we can revisit it
there. Thanks.
next prev parent reply other threads:[~2021-07-19 9:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 19:17 [PATCH 0/2] Fixes for KSZ DSA switch Lino Sanfilippo
2021-07-14 19:17 ` [PATCH 1/2] net: dsa: tag_ksz: linearize SKB before adding DSA tag Lino Sanfilippo
2021-07-14 19:17 ` [PATCH 2/2] net: dsa: tag_ksz: dont let the hardware process the layer 4 checksum Lino Sanfilippo
2021-07-14 19:48 ` Vladimir Oltean
2021-07-14 20:15 ` Andrew Lunn
2021-07-15 6:54 ` Vladimir Oltean
2021-07-15 11:16 ` Aw: " Lino Sanfilippo
2021-07-15 11:49 ` Vladimir Oltean
2021-07-15 13:04 ` Aw: " Lino Sanfilippo
2021-07-15 13:12 ` Vladimir Oltean
2021-07-15 13:34 ` Aw: " Lino Sanfilippo
2021-07-15 13:08 ` Andrew Lunn
2021-07-15 14:36 ` Vladimir Oltean
2021-07-15 15:50 ` Andrew Lunn
2021-07-19 8:20 ` Aw: " Lino Sanfilippo
2021-07-19 8:24 ` Vladimir Oltean [this message]
2021-07-15 16:24 ` Florian Fainelli
2021-07-15 23:23 ` [PATCH 0/2] Fixes for KSZ DSA switch Florian Fainelli
2021-07-16 8:49 ` Aw: " Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719082420.d7qid2hld26v6kdb@skbuf \
--to=olteanv@gmail.com \
--cc=LinoSanfilippo@gmx.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).