From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Aw: Re: [PATCH 2/2] net: dsa: tag_ksz: dont let the hardware process the layer 4 checksum
Date: Thu, 15 Jul 2021 15:34:12 +0200 [thread overview]
Message-ID: <trinity-3bd0a864-e313-4403-8f8b-46fa344c80a4-1626356052833@3c-app-gmx-bap31> (raw)
In-Reply-To: <20210715131251.zhtcsjkat267yrtl@skbuf>
> Gesendet: Donnerstag, 15. Juli 2021 um 15:12 Uhr
> Von: "Vladimir Oltean" <olteanv@gmail.com>
> An: "Lino Sanfilippo" <LinoSanfilippo@gmx.de>
> Cc: "Andrew Lunn" <andrew@lunn.ch>, woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, vivien.didelot@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH 2/2] net: dsa: tag_ksz: dont let the hardware process the layer 4 checksum
>
> On Thu, Jul 15, 2021 at 03:04:31PM +0200, Lino Sanfilippo wrote:
> > Please note that skb_put() asserts that the SKB is linearized. So I think we
> > should rather clear both NETIF_F_FRAGLIST and NETIF_F_SG unconditionally since also
> > header taggers use some form of skb_put() dont they?
>
> The tail taggers use skb_put() as part of the routine to make room for
> the tail tag.
>
> Some of the header taggers use __skb_put_padto() when the packets are
> too small (under ETH_ZLEN). When they are so small they are definitely
> linear already.
>
> We don't have a third form/use of skb_put().
>
Ah ok, I see. Then it should be fine do clear both flags only in case of
tail taggers.
Regards,
Lino
next prev parent reply other threads:[~2021-07-15 13:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 19:17 [PATCH 0/2] Fixes for KSZ DSA switch Lino Sanfilippo
2021-07-14 19:17 ` [PATCH 1/2] net: dsa: tag_ksz: linearize SKB before adding DSA tag Lino Sanfilippo
2021-07-14 19:17 ` [PATCH 2/2] net: dsa: tag_ksz: dont let the hardware process the layer 4 checksum Lino Sanfilippo
2021-07-14 19:48 ` Vladimir Oltean
2021-07-14 20:15 ` Andrew Lunn
2021-07-15 6:54 ` Vladimir Oltean
2021-07-15 11:16 ` Aw: " Lino Sanfilippo
2021-07-15 11:49 ` Vladimir Oltean
2021-07-15 13:04 ` Aw: " Lino Sanfilippo
2021-07-15 13:12 ` Vladimir Oltean
2021-07-15 13:34 ` Lino Sanfilippo [this message]
2021-07-15 13:08 ` Andrew Lunn
2021-07-15 14:36 ` Vladimir Oltean
2021-07-15 15:50 ` Andrew Lunn
2021-07-19 8:20 ` Aw: " Lino Sanfilippo
2021-07-19 8:24 ` Vladimir Oltean
2021-07-15 16:24 ` Florian Fainelli
2021-07-15 23:23 ` [PATCH 0/2] Fixes for KSZ DSA switch Florian Fainelli
2021-07-16 8:49 ` Aw: " Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-3bd0a864-e313-4403-8f8b-46fa344c80a4-1626356052833@3c-app-gmx-bap31 \
--to=linosanfilippo@gmx.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).