From: Cai Huoqing <caihuoqing@baidu.com>
To: <saeedm@nvidia.com>, <leon@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
Cai Huoqing <caihuoqing@baidu.com>
Subject: [PATCH v2] net/mlx5e: Make use of mlx5_core_warn()
Date: Mon, 9 Aug 2021 20:19:31 +0800 [thread overview]
Message-ID: <20210809121931.2519-1-caihuoqing@baidu.com> (raw)
to replace printk(KERN_WARNING ...) with mlx5_core_warn() kindly
if we use mlx5_core_warn(), the prefix "mlx5:" not needed
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index e5c4344a114e..304cca0f54d3 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -2702,7 +2702,8 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
if (s_mask && a_mask) {
NL_SET_ERR_MSG_MOD(extack,
"can't set and add to the same HW field");
- printk(KERN_WARNING "mlx5: can't set and add to the same HW field (%x)\n", f->field);
+ mlx5_core_warn(priv->mdev,
+ "can't set and add to the same HW field (%x)\n", f->field);
return -EOPNOTSUPP;
}
@@ -2741,8 +2742,9 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
if (first < next_z && next_z < last) {
NL_SET_ERR_MSG_MOD(extack,
"rewrite of few sub-fields isn't supported");
- printk(KERN_WARNING "mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
- mask);
+ mlx5_core_warn(priv->mdev,
+ "rewrite of few sub-fields (mask %lx) isn't offloaded\n",
+ mask);
return -EOPNOTSUPP;
}
--
2.25.1
next reply other threads:[~2021-08-09 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 12:19 Cai Huoqing [this message]
2021-08-09 12:28 ` [PATCH v2] net/mlx5e: Make use of mlx5_core_warn() Leon Romanovsky
2021-08-09 20:39 ` Saeed Mahameed
2021-08-10 6:58 ` Leon Romanovsky
2021-08-10 8:22 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809121931.2519-1-caihuoqing@baidu.com \
--to=caihuoqing@baidu.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).