From: Leon Romanovsky <leon@kernel.org>
To: Saeed Mahameed <saeedm@nvidia.com>
Cc: "caihuoqing@baidu.com" <caihuoqing@baidu.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v2] net/mlx5e: Make use of mlx5_core_warn()
Date: Tue, 10 Aug 2021 09:58:40 +0300 [thread overview]
Message-ID: <YRIjoCbxAo+3SemG@unreal> (raw)
In-Reply-To: <7b7dba6e8d62e39343fd6e4dcbd0503aadfb9e40.camel@nvidia.com>
On Mon, Aug 09, 2021 at 08:39:10PM +0000, Saeed Mahameed wrote:
> On Mon, 2021-08-09 at 20:19 +0800, Cai Huoqing wrote:
> > to replace printk(KERN_WARNING ...) with mlx5_core_warn() kindly
> > if we use mlx5_core_warn(), the prefix "mlx5:" not needed
>
> in mlx5e it is netdev stack so netdev_warn(priv->netdev, "foo bar");
Saeed,
That file is full of mlx5_core_* prints, even in the same function where
Cai is changing, you will find mlx5_core_warn().
Thanks
> please.
next prev parent reply other threads:[~2021-08-10 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 12:19 [PATCH v2] net/mlx5e: Make use of mlx5_core_warn() Cai Huoqing
2021-08-09 12:28 ` Leon Romanovsky
2021-08-09 20:39 ` Saeed Mahameed
2021-08-10 6:58 ` Leon Romanovsky [this message]
2021-08-10 8:22 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRIjoCbxAo+3SemG@unreal \
--to=leon@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).