* [PATCH net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list
@ 2021-11-18 1:57 Eric Dumazet
2021-11-18 12:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2021-11-18 1:57 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski
Cc: netdev, Eric Dumazet, Eric Dumazet, Stephen Rothwell
From: Eric Dumazet <edumazet@google.com>
Add missing entries to fix these "make htmldocs" warnings.
./include/linux/skbuff.h:953: warning: Function parameter or member 'll_node' not described in 'sk_buff'
./include/net/sock.h:540: warning: Function parameter or member 'defer_list' not described in 'sock'
Fixes: f35f821935d8 ("tcp: defer skb freeing after socket lock is released")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/skbuff.h | 1 +
include/net/sock.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index b8b806512e1615fad2bc9935baba3fff14996012..100fd604fbc9a32180a6f43626249d19bf415c4f 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -627,6 +627,7 @@ typedef unsigned char *sk_buff_data_t;
* for retransmit timer
* @rbnode: RB tree node, alternative to next/prev for netem/tcp
* @list: queue head
+ * @ll_node: anchor in an llist (eg socket defer_list)
* @sk: Socket we are owned by
* @ip_defrag_offset: (aka @sk) alternate use of @sk, used in
* fragmentation management
diff --git a/include/net/sock.h b/include/net/sock.h
index f09c0c4736c46a18b820949ba3c8ea4e7c6fee57..a79fc772324e5da7b9f489de2e06698695d3e7d7 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -292,6 +292,7 @@ struct bpf_local_storage;
* @sk_pacing_shift: scaling factor for TCP Small Queues
* @sk_lingertime: %SO_LINGER l_linger setting
* @sk_backlog: always used with the per-socket spinlock held
+ * @defer_list: head of llist storing skbs to be freed
* @sk_callback_lock: used with the callbacks in the end of this struct
* @sk_error_queue: rarely used
* @sk_prot_creator: sk_prot of original sock creator (see ipv6_setsockopt,
--
2.34.0.rc1.387.gb447b232ab-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list
2021-11-18 1:57 [PATCH net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list Eric Dumazet
@ 2021-11-18 12:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-18 12:10 UTC (permalink / raw)
To: Eric Dumazet; +Cc: davem, kuba, netdev, edumazet, sfr
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 17 Nov 2021 17:57:29 -0800 you wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Add missing entries to fix these "make htmldocs" warnings.
>
> ./include/linux/skbuff.h:953: warning: Function parameter or member 'll_node' not described in 'sk_buff'
> ./include/net/sock.h:540: warning: Function parameter or member 'defer_list' not described in 'sock'
>
> [...]
Here is the summary with links:
- [net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list
https://git.kernel.org/netdev/net-next/c/df6160deb3de
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-18 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 1:57 [PATCH net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list Eric Dumazet
2021-11-18 12:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).